Content-Type: multipart/alternative;
 boundary="------------yiE700foDrs3nFtM3v2i6jXb"
Message-ID: <a71c30b3-b3b2-49c3-82fa-56f5a1a253a5@shaw.ca>
Date: Thu, 3 Oct 2024 10:20:28 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: How to handle "could not find function xml_is_well_formed" when
 restoring database in Version 17
Content-Language: en-US
To: "pgsql-general@postgresql.org" <pgsql-general@postgresql.org>
References: <eea7fa46-f273-413f-897e-9613591a4f08@shaw.ca>
 <1865149.1727803723@sss.pgh.pa.us>
From: George Weaver <gweaver@shaw.ca>
Organization: Cleartag Software, Inc.
In-Reply-To: <1865149.1727803723@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/a71c30b3-b3b2-49c3-82fa-56f5a1a253a5%40shaw.ca>
Precedence: bulk

This is a multi-part message in MIME format.
--------------yiE700foDrs3nFtM3v2i6jXb
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Thanks Tom and Christoph,

Got it!

The function xml_valid is also gone.  Does xml_is_well_formed accomplish 
the same objective?

Thanks,

George

On 01/10/2024 12:28 p.m., Tom Lane wrote:
> George Weaver<gweaver@shaw.ca>  writes:
>> I am testing upgrading from Version 13 to Version 17.  I am getting the
>> following error when trying to restore a database in Version 17 (the
>> database was backed up from Version 13 using the Version 17 pg_dump):
>>      pg_Restore: error: could not execute query: ERROR:  could not find
>>      function "xml_is_well_formed" in file "C:/Program
>>      Files/PostgreSQL/17/lib/pgxml.dll"
>>      Command was: CREATE FUNCTION public.xml_is_well_formed(text) RETURNS
>>      boolean
>>           LANGUAGE c IMMUTABLE STRICT
>>           AS '$libdir/pgxml', 'xml_is_well_formed';
> What you appear to have here is a pre-9.1 version of the xml2
> extension.  That is so old that you're going to have difficulty
> modernizing it.  We used to provide scripts for converting those
> loose objects into extensions, but we got rid of them in v13,
> figuring that after ten years their usefulness had passed.
>
> I think what you will have to do is manually drop all the xml2
> functions (look for pg_proc entries with '$libdir/pgxml' in probin)
> from the v13 database, then upgrade, then install the xml2 extension
> if you still want it.  Fortunately that module only provided functions
> not datatypes, so this shouldn't be too painful.  (Another way could
> be to manually remove those CREATE FUNCTION commands from the dump
> script.)
>
> I'm betting that this database has a lot of other deferred
> maintenance that you ought to think about while you're at it.
> If there are any other old-style extensions in there, better
> fix them up.
>
> 			regards, tom lane

--------------yiE700foDrs3nFtM3v2i6jXb
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Thanks Tom and Christoph,</p>
    <p>Got it!</p>
    <p>The function xml_valid is also gone.  Does <span
      style="white-space: pre-wrap">xml_is_well_formed accomplish the same objective?</span></p>
    <p><span style="white-space: pre-wrap">Thanks,</span></p>
    <p><span style="white-space: pre-wrap">George
</span></p>
    <div class="moz-cite-prefix">On 01/10/2024 12:28 p.m., Tom Lane
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:1865149.1727803723@sss.pgh.pa.us">
      <pre class="moz-quote-pre" wrap="">George Weaver <a class="moz-txt-link-rfc2396E" href="mailto:gweaver@shaw.ca">&lt;gweaver@shaw.ca&gt;</a> writes:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">I am testing upgrading from Version 13 to Version 17.  I am getting the 
following error when trying to restore a database in Version 17 (the 
database was backed up from Version 13 using the Version 17 pg_dump):
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">    pg_Restore: error: could not execute query: ERROR:  could not find
    function "xml_is_well_formed" in file "C:/Program
    Files/PostgreSQL/17/lib/pgxml.dll"
    Command was: CREATE FUNCTION public.xml_is_well_formed(text) RETURNS
    boolean
         LANGUAGE c IMMUTABLE STRICT
         AS '$libdir/pgxml', 'xml_is_well_formed';
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
What you appear to have here is a pre-9.1 version of the xml2
extension.  That is so old that you're going to have difficulty
modernizing it.  We used to provide scripts for converting those
loose objects into extensions, but we got rid of them in v13,
figuring that after ten years their usefulness had passed.

I think what you will have to do is manually drop all the xml2
functions (look for pg_proc entries with '$libdir/pgxml' in probin)
from the v13 database, then upgrade, then install the xml2 extension
if you still want it.  Fortunately that module only provided functions
not datatypes, so this shouldn't be too painful.  (Another way could
be to manually remove those CREATE FUNCTION commands from the dump
script.)

I'm betting that this database has a lot of other deferred
maintenance that you ought to think about while you're at it.
If there are any other old-style extensions in there, better
fix them up.

			regards, tom lane
</pre>
    </blockquote>
    <pre class="moz-signature" cols="72">
</pre>
  </body>
</html>

--------------yiE700foDrs3nFtM3v2i6jXb--