Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 16 Sep 2025 08:59:15 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
	Dominique Devienne <ddevienne@gmail.com>,
	pgsql-general@postgresql.org
Subject: Re: Latest patches break one of our unit-test, related to RLS
Message-ID: <aMioU500pBYs_mBz@paquier.xyz>
References: <CAFCRh--M1y2YpJJMb6undzvyvhd4geKtRWFkDyr1shHvvoOkpQ@mail.gmail.com>
 <CAFCRh-_OBKtabe8MO0vUocNSq_O3_b852AXknPiNhL0tNUBGQg@mail.gmail.com>
 <CAFCRh-_U+8fmRoc-sYM5ahp=9dNjs=Dri1LFLcHCgEJX8Zq_oA@mail.gmail.com>
 <2109533.1757686026@sss.pgh.pa.us>
 <2c58dcdba889f5b28df5ad9d21b5ea2d0ac63a9a.camel@cybertec.at>
 <2673230.1757722323@sss.pgh.pa.us>
 <501ee89ad54184804d14b416781dafd340c789d3.camel@cybertec.at>
 <2683918.1757728397@sss.pgh.pa.us>
 <b6fd9d698792d570e1e45117d44e72d19104fcc1.camel@cybertec.at>
 <296006.1757797220@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="i6/BKdm2W1x86K4G"
Content-Disposition: inline
In-Reply-To: <296006.1757797220@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/aMioU500pBYs_mBz%40paquier.xyz>
Precedence: bulk


--i6/BKdm2W1x86K4G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 13, 2025 at 05:00:20PM -0400, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > I came up with the attached patch set.
>=20
> I did some more work on the comments, adjusted a couple of places that
> could be simplified, and pushed it.

My apologies for the silence here.

The timing of the events is interesting.  I have been pinged about
this issue on Friday evening/night time here:
https://www.postgresql.org/message-id/202509121631.dtn5kw5er2m5@alvherre.pg=
sql

For a fix applied as of cdf7feb96562 roughly 24 hours after this ping.
The timing was a bit bad for me, because I was already gone for what
was a long weekend in Japan, just back today.  So it was a bit hard
for me to look at anything

> I didn't really love the "fix it and then explain it afterward"
> approach.  It's hard to review a patch if you don't understand the
> logic.  I considered swapping the order of the two patches, but
> eventually just merged them into one.

Merging both things makes sense as well here.

Ugh, yes.  That was wrong.  With the fix, '%' is translated:
-   Filter: (f1 ~ '^(?:[\a].*)$'::text)
Before the fix, not translated.
+   Filter: (f1 ~ '^(?:[\a]%)$'::text)

Thanks for the report, the analysis, and the commit.
--
Michael

--i6/BKdm2W1x86K4G
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmjIqFMACgkQnvQgOdby
QH2uGA/+OHZekXukxXUxFPodjFTND2Vy5/zAtdTrUMmMUI+D9Cc+nEFOYDUyudXQ
Svn+OAIUUeSzXI7BDIP2s8LHkoeoaDZHIjwUmd8tmPkBkShdY1FAEEmLXox1kmaS
rqWqSIOioiuHV8CHfjeLp1YFTv6WJfOOZ7S+kTtOI3npr7V5KSOp0dolkOC3CCDb
V1XQoDQ/Od48urx5Wo1l5c53bRcm3y5JOA0QlIlJNluIEzik1SfmkA+Jc3TyBud0
mmrOwJ+UDsh+uup7qhJYoMFQdwFDkD8aJWsHeu7K53z3nWMXclpTJtwe/munfwL5
aquagnQVZk03Knp5DodXo8gjLfQn7g/8Bg40dBbVSkc0GZtanMYP5mvVxySV6hYU
SwRL7TkTy7YmeoaDzLCH+bE6kdYCPFwOwR5lCONfzl1KWa0jem4cKvdeQABdw8wF
+7M/R5XaobiwehWxl1qoqej8/IRFszbOI08Tw+OFbvM7pUJqMnSx3EC7kIi7UiP2
3+1GCQLUzeQePktZbhJhJ30eHvZsdTCqup2jjtNaq7hUy3bnlUDGYwlcakMbsW2G
z+6cKtK8tlDCkmGevhbatHXpqYKGb72pBSuJiLe19Q7O1roGBU67gT3JdX50qanG
QLEYSKUYDT4xDjC+C0m/2LjdjB0Kflo4TbjXZmL2CqRgupcN23o=
=V0+j
-----END PGP SIGNATURE-----

--i6/BKdm2W1x86K4G--