Message-ID: <ad3adb5df84c50d78e9c1d118f55a06f753dd7dd.camel@cybertec.at>
Subject: Re: analyze-in-stages post upgrade questions
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Mircea Cadariu <cadariu.mircea@gmail.com>, "Zechman, Derek S"
	 <Derek.S.Zechman@snapon.com>, Adrian Klaver <adrian.klaver@aklaver.com>, 
	pgsql-hackers@lists.postgresql.org
Date: Mon, 18 Aug 2025 08:40:02 +0200
In-Reply-To: <CAHGQGwGje3mv5sOmyCJ0NroNPF8938OYCOHMJZbegTekccZZ=g@mail.gmail.com>
References: 
	<CO1PR04MB8281387B9AD9DE30976966BBC045A@CO1PR04MB8281.namprd04.prod.outlook.com>
	 <6add2a9a-7cf2-4d1b-8f3e-2e26a7ebe883@aklaver.com>
	 <4d8122febd3007143504e4b6034b4253f7000761.camel@cybertec.at>
	 <PH0PR04MB82943D67CD179002714AA503C044A@PH0PR04MB8294.namprd04.prod.outlook.com>
	 <f2ebeef82fddaf8a8152383f8ff62e75f20aac3c.camel@cybertec.at>
	 <PH0PR04MB8294E796D6297D4E3BE4EFB6C049A@PH0PR04MB8294.namprd04.prod.outlook.com>
	 <08d943a83590308cbb9be594d80b4e19ca80e08e.camel@cybertec.at>
	 <2505eef1-b6aa-4518-baff-861a2e6a507b@gmail.com>
	 <b65126bf381d4b41f561afe691000b77ac7b8cc2.camel@cybertec.at>
	 <a018a729-9b18-444f-baed-be0d6d8ecb80@gmail.com>
	 <2c1f1834107045dfa8b32417771b56bab0cffc56.camel@cybertec.at>
	 <2cce9851-327a-4b1a-ab8e-531c2f92532b@gmail.com>
	 <CAHGQGwEvwpydO7hjnB51Q2zgS0ydv31X4HCFLNzMeqLr=poS8w@mail.gmail.com>
	 <9c9cb744-b8c7-4d75-acad-595b3faba187@gmail.com>
	 <CAHGQGwEj8PCk1OVveJ_F1sj_COrV95N-mfu_tLUn4gdcAM24kA@mail.gmail.com>
	 <9a93cffe79e2be1d9450a36e773a39dc456c241e.camel@cybertec.at>
	 <CAHGQGwGje3mv5sOmyCJ0NroNPF8938OYCOHMJZbegTekccZZ=g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/ad3adb5df84c50d78e9c1d118f55a06f753dd7dd.camel%40cybertec.at>
Precedence: bulk

On Mon, 2025-08-18 at 11:38 +0900, Fujii Masao wrote:
> Thanks! So I've updated the patch based on my earlier comments.
> Unless there are objections, I'll commit the attached version to master o=
nly.

I am fine with your patch.

One suggestion:

> --- a/doc/src/sgml/ref/vacuumdb.sgml
> +++ b/doc/src/sgml/ref/vacuumdb.sgml
> @@ -397,6 +397,15 @@ PostgreSQL documentation
>          Multiple tables can be vacuumed by writing multiple
>          <option>-t</option> switches.
>         </para>
> +       <para>
> +        If no tables are specified with the <option>--table</option> opt=
ion,
> +        <application>vacuumdb</application> will clean all regular table=
s
> +        and materialized views in the connected database.
> +        If <option>--analyze-only</option> or
> +        <option>--analyze-in-stages</option> is also specified,
> +        it will analyze all regular tables, partitioned tables,
> +        and materialized views (but not foreign tables).
> +       </para>

I suggest replacing "clean" with "process", since VACUUM does so much more =
than
clean up dead tuples.

Concerning backpatching, I voted against, but I suggest that this be backpa=
tched
to v18.  I don't feel very strongly about it though.

Yours,
Laurenz Albe