Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vODLd-00EzlO-2V for pgsql-general@arkaria.postgresql.org; Wed, 26 Nov 2025 11:06:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vODKc-00FgsQ-37 for pgsql-general@arkaria.postgresql.org; Wed, 26 Nov 2025 11:05:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vODKc-00FgsH-0G for pgsql-general@lists.postgresql.org; Wed, 26 Nov 2025 11:05:06 +0000 Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1vODKZ-001YcA-2o for pgsql-general@lists.postgresql.org; Wed, 26 Nov 2025 11:05:05 +0000 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id AC9CC1D0014A; Wed, 26 Nov 2025 06:05:03 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Wed, 26 Nov 2025 06:05:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1764155103; x=1764241503; bh=GVcvj/O5ZC0vZDWjGt0TAuFjevcynyj3 TeJxZxq+lrY=; b=mkOGsusYY1SFs9WpX0M0oM7DbzJLpSvfJ1gnDYjFbK0A3rug hA1ogfSMXrQDFW+IpceV46FJLztFYe09XA0zAXejBQgskFykSau7/pTJvkQtfkU1 PRNmQM70+8wQKyvRmmc2GuOx1JaQJNm8DxXXxCK07cTpV4wjPqKOplF65SpXqyuR 1f1tkQn+zAO21pLdPZe/FLAuNDvz06E8bb/OuJBl5U2crgmWUk4cTHIQJOP9A8GH RKXhk57JSum8GeFhIKfm3btXd131edCT90dAqfjYHnTcK6j96KrjbCaDP7iJFHVg 6Xy0qU3VzdU8/85ZVzz5WJLYJoMcRctsokkpPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1764155103; x= 1764241503; bh=GVcvj/O5ZC0vZDWjGt0TAuFjevcynyj3TeJxZxq+lrY=; b=c 7r4TXX1R+7U2Qq9iyLg5Zi7v1UQmXsA69BvIgOFd0CBGR/bNgd0vSeC09+vWdGc1 o12dC60hAM3u8ZYUPto2kERQz5+Fmi38e2/2mntj+Y6JoroICe84JxfwsXIh9J7h EIdZVkGOhz1/qIJxJu52pgnU7wRZwdJbh6SGHA466jA6tkqPLfDimlqLwTyjfI3D 2oPA59jh9isgVwOWyApX2n+0a2cBQUSLkTAqBeIQYE/yIRoT11AJSsBj0mtznO6b bHDS+HVY1mUo73wvnPsr4N0KWLcNBxxzsriFocgj9uGmpNLcsYGWEx1HQJXOTpyM LwANi3CBDsZtX5Jy7fGKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeegudekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefrvghtvghr ucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgheqne cuggftrfgrthhtvghrnhepgfejtdfhkeeftdeugfeileehteeljeeghfeuledthfeutedv ffdukeefjefhgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegurghnihgvlheshigvshhqlh drshgvpdhrtghpthhtohepsggvrhhnihgtvgdrshhouhhthhgvhiesghhmrghilhdrtgho mhdprhgtphhtthhopehpghhsqhhlqdhgvghnvghrrghlsehlihhsthhsrdhpohhsthhgrh gvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Nov 2025 06:05:01 -0500 (EST) Message-ID: Date: Wed, 26 Nov 2025 12:05:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Indentation in a patch To: Daniel Gustafsson , Bernice Southey Cc: pgsql-general@lists.postgresql.org References: <2595B96D-0A6E-472D-964A-8E87EC3B1C6B@yesql.se> Content-Language: de-DE, en-US From: Peter Eisentraut In-Reply-To: <2595B96D-0A6E-472D-964A-8E87EC3B1C6B@yesql.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 25.11.25 19:58, Daniel Gustafsson wrote: >> On 25 Nov 2025, at 19:14, Bernice Southey wrote: > >> .. for my first ever patch attempt. > > Awesome, we love to see new contributors! > >> I'm tempted to submit my patch without indenting the >> if-block, and an explanation. > > That's perfectly fine, an incorrectly indentend diff is fine to submit if it > makes it more readable (especially when coupled with a note explaining why). Alternatively or additionally, git diff -w/--ignore-all-space can be useful in situations like this.