Message-ID: <d10adba2-e028-44c1-b5a5-96ff922f546f@iki.fi>
Date: Tue, 3 Sep 2024 00:11:48 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: PG17 optimizations to vacuum
To: Peter Geoghegan <pg@bowt.ie>, Pavel Luzanov <p.luzanov@postgrespro.ru>
Cc: Melanie Plageman <melanieplageman@gmail.com>,
 "pgsql-generallists.postgresql.org" <pgsql-general@lists.postgresql.org>
References: <3bda0d10-0d60-42b7-9600-abe23d54bb16@postgrespro.ru>
 <CAH2-Wz=pCtsB3v42RB5dLnzEn3tQLUJ8fJMn+si-9A8s6v=B1A@mail.gmail.com>
 <CAAKRu_aBthDxatwzR-wQ8bWfYehuxYgAO0g6AMPFyVgdOxfS4g@mail.gmail.com>
 <CAH2-Wznqbnc8en8+B26obp-pmTKXi_HS_h_yRt4HVtqLOCKxLQ@mail.gmail.com>
 <CAAKRu_YF9UeFnfsgDiFybAss2YQtmEHU+xjngqwmwwyQjCDvxQ@mail.gmail.com>
 <7bc8da54-fe4f-4ff2-aa4e-b54fc91df586@postgrespro.ru>
 <7760d3e3-15cc-4abf-ab33-027008c17d53@iki.fi>
 <CAH2-Wzm7b-dJB7VChcdUZR9Mm6Wa5uY1k_2-h5U60XTUYdsF=w@mail.gmail.com>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <CAH2-Wzm7b-dJB7VChcdUZR9Mm6Wa5uY1k_2-h5U60XTUYdsF=w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/d10adba2-e028-44c1-b5a5-96ff922f546f%40iki.fi>
Precedence: bulk

On 03/09/2024 00:01, Peter Geoghegan wrote:
> On Mon, Sep 2, 2024 at 4:58 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> Do you have any non-default settings? "select name,
>> current_setting(name), source  from pg_settings where setting <>
>> boot_val;" would show that.
> 
> What about page checksums?
> 
> One simple explanation is that we're writing extra FPIs to set hint
> bits. But that explanation only works if you assume that page-level
> checksums are in use (or that wal_log_hints is turned on).

Hmm, yeah, that might be it. With chceksums enabled, I see ~120k WAL 
records, vs ~90k without checksums. But there's no difference between 
v16 and master.

Pavel, did you test v17 with checksums enabled and v16 with checksums 
disabled, by any chance?

-- 
Heikki Linnakangas
Neon (https://neon.tech)