Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDLTl-0002tk-9j for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Jul 2022 07:47:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLTi-0003tl-RN for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Jul 2022 07:47:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDLTi-0003tO-HZ for pgsql-hackers@lists.postgresql.org; Mon, 18 Jul 2022 07:47:42 +0000 Received: from mout-b-203.mailbox.org ([2001:67c:2050:102:465::203]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDLTf-0005Mh-Ie for pgsql-hackers@lists.postgresql.org; Mon, 18 Jul 2022 07:47:41 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-203.mailbox.org (Postfix) with ESMTPS id 4LmYw470sPz9sc7; Mon, 18 Jul 2022 09:47:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aboutsource.net; s=MBO0001; t=1658130452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/owFaQT8OCNOYfWR4+dI4H4y/fo/jF5yUeRTZAVDAeU=; b=vkVlso3lOGZoo7w4F6VEO2ObTD+K/ZdNkuP2W0ReJi+9QfuhwPhHkXarR02HT+1QTYq/Ek nXMXtiLAqQJ4xO+aGARx72v45Ml7roCS1gFze7VkEiHoOyXTa7NYlEkrqB5gWMnwnw6tZP rDLimiTdtHiQ/DQ2wtw/TQmmpfc5RLD7SRs5xmPSf5dNWRJw4w6KCZUYS5nFr1Zjm4antP zp7L70afz19wGhk5Fa/jcbCB4uncwG71rIFZHZwHisSw3ywooW/1l8HNIGyYLewdPfS1Ea xnqR1b+cu0hDkdhKx2a+rOHLRzCwv6EehpOzjR6+1M/dxpEegzGV0R5oV1yk9w== Content-Type: multipart/mixed; boundary="------------0ntGaCxM2sfEDBxqGiAfEdAp" Message-ID: Date: Mon, 18 Jul 2022 09:47:30 +0200 MIME-Version: 1.0 Subject: Re: Proposal to introduce a shuffle function to intarray extension Content-Language: de-DE To: Tom Lane Cc: Thomas Munro , PostgreSQL Hackers References: <9d160a44-7675-51e8-60cf-6d64b76db831@aboutsource.net> <4073858.1658027909@sss.pgh.pa.us> <4077925.1658029046@sss.pgh.pa.us> <5ef15c6f-e108-53af-3d82-587fac394f1a@aboutsource.net> <463181.1658097987@sss.pgh.pa.us> <5b7a1ee9-f942-2502-3a0c-e9fc12511139@aboutsource.net> <469954.1658100033@sss.pgh.pa.us> From: Martin Kalcher In-Reply-To: <469954.1658100033@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------0ntGaCxM2sfEDBxqGiAfEdAp Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Am 18.07.22 um 01:20 schrieb Tom Lane: > (Having said that, even if we were going to implement it with that > definition, I should think that it'd be easiest to do so on the > array-of-Datums representation produced by deconstruct_array. > That way you don't need to do different things for different element > types.) Thank you Tom, here is a patch utilising deconstruct_array(). If we agree, that this is the way to go, i would like to add array_sample() (good name?), some test cases, and documentation. One more question. How do i pick a Oid for the functions? Martin --------------0ntGaCxM2sfEDBxqGiAfEdAp Content-Type: text/x-patch; charset=UTF-8; name="0001-introduce-array_shuffle.patch" Content-Disposition: attachment; filename="0001-introduce-array_shuffle.patch" Content-Transfer-Encoding: base64 RnJvbSBiYWVjMDgxNjgzNTcwOTgyODczNDJjOTI2NzJlZjk3MzYxYTkxMzcxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gS2FsY2hlciA8bWFydGluLmthbGNoZXJA YWJvdXRzb3VyY2UubmV0PgpEYXRlOiBTdW4sIDE3IEp1bCAyMDIyIDE4OjA2OjA0ICswMjAw ClN1YmplY3Q6IFtQQVRDSF0gaW50cm9kdWNlIGFycmF5X3NodWZmbGUoKQoKLS0tCiBzcmMv YmFja2VuZC91dGlscy9hZHQvYXJyYXlmdW5jcy5jIHwgNjEgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrCiBzcmMvaW5jbHVkZS9jYXRhbG9nL3BnX3Byb2MuZGF0ICAgIHwgIDMg KysKIDIgZmlsZXMgY2hhbmdlZCwgNjQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3Ny Yy9iYWNrZW5kL3V0aWxzL2FkdC9hcnJheWZ1bmNzLmMgYi9zcmMvYmFja2VuZC91dGlscy9h ZHQvYXJyYXlmdW5jcy5jCmluZGV4IGZiMTY3ZjIyNmEuLmUxODVjMWVmNzQgMTAwNjQ0Ci0t LSBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9hcnJheWZ1bmNzLmMKKysrIGIvc3JjL2JhY2tl bmQvdXRpbHMvYWR0L2FycmF5ZnVuY3MuYwpAQCAtNjg3MiwzICs2ODcyLDY0IEBAIHRyaW1f YXJyYXkoUEdfRlVOQ1RJT05fQVJHUykKIAogCVBHX1JFVFVSTl9EQVRVTShyZXN1bHQpOwog fQorCitEYXR1bQorYXJyYXlfc2h1ZmZsZShQR19GVU5DVElPTl9BUkdTKQoreworCUFycmF5 VHlwZQkJKmFycmF5LAorCQkJCQkqcmVzdWx0OworCWludDE2CQkJZWxtbGVuOworCWJvb2wJ CQllbG1ieXZhbDsKKwljaGFyCQkJZWxtYWxpZ247CisJT2lkICAgICAgICAgICAgIGVsbXR5 cDsKKwlUeXBlQ2FjaGVFbnRyeQkqdHlwZW50cnk7CisJRGF0dW0JCQkqZWxtcywKKwkJCQkJ ZWxtOworCWJvb2wJCQkqbnVscywKKwkJCQkJbnVsOworCWludCAgICAgICAgIAluZWxtcywK KwkJCQkJaSwKKwkJCQkJajsKKworCWFycmF5ID0gUEdfR0VUQVJHX0FSUkFZVFlQRV9QKDAp OworCisJaWYgKEFycmF5R2V0Tkl0ZW1zKEFSUl9ORElNKGFycmF5KSwgQVJSX0RJTVMoYXJy YXkpKSA8IDIpCisJCVBHX1JFVFVSTl9BUlJBWVRZUEVfUChhcnJheSk7CisKKwllbG10eXAg PSBBUlJfRUxFTVRZUEUoYXJyYXkpOworCisJdHlwZW50cnkgPSAoVHlwZUNhY2hlRW50cnkg KikgZmNpbmZvLT5mbGluZm8tPmZuX2V4dHJhOworCisJaWYgKHR5cGVudHJ5ID09IE5VTEwg fHwgdHlwZW50cnktPnR5cGVfaWQgIT0gZWxtdHlwKQorCXsKKwkJdHlwZW50cnkgPSBsb29r dXBfdHlwZV9jYWNoZShlbG10eXAsIDApOworCQlmY2luZm8tPmZsaW5mby0+Zm5fZXh0cmEg PSAodm9pZCAqKSB0eXBlbnRyeTsKKwl9CisJZWxtbGVuID0gdHlwZW50cnktPnR5cGxlbjsK KwllbG1ieXZhbCA9IHR5cGVudHJ5LT50eXBieXZhbDsKKwllbG1hbGlnbiA9IHR5cGVudHJ5 LT50eXBhbGlnbjsKKworCWRlY29uc3RydWN0X2FycmF5KGFycmF5LCBlbG10eXAsIGVsbWxl biwgZWxtYnl2YWwsIGVsbWFsaWduLAorCQkJCQkgICZlbG1zLCAmbnVscywgJm5lbG1zKTsK KworCWZvciAoaSA9IG5lbG1zIC0gMTsgaSA+IDA7IGktLSkKKwl7CisJCWogPSByYW5kb20o KSAlIChpICsgMSk7CisJCWVsbSA9IGVsbXNbaV07CisJCW51bCA9IG51bHNbaV07CisJCWVs bXNbaV0gPSBlbG1zW2pdOworCQludWxzW2ldID0gbnVsc1tqXTsKKwkJZWxtc1tqXSA9IGVs bTsKKwkJbnVsc1tqXSA9IG51bDsKKwl9CisKKwlyZXN1bHQgPSBjb25zdHJ1Y3RfbWRfYXJy YXkoZWxtcywgbnVscywKKwkJCQkJCQkJQVJSX05ESU0oYXJyYXkpLCBBUlJfRElNUyhhcnJh eSksIEFSUl9MQk9VTkQoYXJyYXkpLAorCQkJCQkJCQllbG10eXAsIGVsbWxlbiwgZWxtYnl2 YWwsIGVsbWFsaWduKTsKKworCXBmcmVlKGVsbXMpOworCXBmcmVlKG51bHMpOworCVBHX0ZS RUVfSUZfQ09QWShhcnJheSwgMCk7CisKKwlQR19SRVRVUk5fQVJSQVlUWVBFX1AocmVzdWx0 KTsKK30KZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL2NhdGFsb2cvcGdfcHJvYy5kYXQgYi9z cmMvaW5jbHVkZS9jYXRhbG9nL3BnX3Byb2MuZGF0CmluZGV4IDJlNDFmNGQ5ZTguLjU2YWZm NTUxZDMgMTAwNjQ0Ci0tLSBhL3NyYy9pbmNsdWRlL2NhdGFsb2cvcGdfcHJvYy5kYXQKKysr IGIvc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19wcm9jLmRhdApAQCAtMTY4MSw2ICsxNjgxLDkg QEAKICAgcHJvbmFtZSA9PiAnYXJyYXljb250am9pbnNlbCcsIHByb3ZvbGF0aWxlID0+ICdz JywgcHJvcmV0dHlwZSA9PiAnZmxvYXQ4JywKICAgcHJvYXJndHlwZXMgPT4gJ2ludGVybmFs IG9pZCBpbnRlcm5hbCBpbnQyIGludGVybmFsJywKICAgcHJvc3JjID0+ICdhcnJheWNvbnRq b2luc2VsJyB9LAoreyBvaWQgPT4gJzc3NzcnLCBkZXNjciA9PiAnc2h1ZmZsZSBhcnJheScs CisgIHByb25hbWUgPT4gJ2FycmF5X3NodWZmbGUnLCBwcm9pc3N0cmljdCA9PiAnZicsIHBy b3JldHR5cGUgPT4gJ2FueWFycmF5JywKKyAgcHJvYXJndHlwZXMgPT4gJ2FueWFycmF5Jywg cHJvc3JjID0+ICdhcnJheV9zaHVmZmxlJyB9LAogCiB7IG9pZCA9PiAnNzY0JywgZGVzY3Ig PT4gJ2xhcmdlIG9iamVjdCBpbXBvcnQnLAogICBwcm9uYW1lID0+ICdsb19pbXBvcnQnLCBw cm92b2xhdGlsZSA9PiAndicsIHByb3BhcmFsbGVsID0+ICd1JywKLS0gCjIuMzcuMQoK --------------0ntGaCxM2sfEDBxqGiAfEdAp--