X-Original-To: pgsql-hackers-pitr-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.2]) by svr1.postgresql.org (Postfix) with ESMTP id 91A09D1D298 for ; Fri, 13 Feb 2004 01:25:37 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (neptune.hub.org [200.46.204.2]) (amavisd-new, port 10024) with ESMTP id 90397-02 for ; Thu, 12 Feb 2004 21:25:36 -0400 (AST) Received: from jinx.internetstaff.com (jinx.internetstaff.com [63.214.174.240]) by svr1.postgresql.org (Postfix) with ESMTP id 679CDD1D2E0 for ; Thu, 12 Feb 2004 21:25:33 -0400 (AST) Received: from localhost (localhost [127.0.0.1]) by jinx.internetstaff.com (Postfix) with ESMTP id D7B594BC0B4; Thu, 12 Feb 2004 18:25:36 -0700 (MST) Received: from jinx.internetstaff.com ([127.0.0.1]) by localhost (jinx [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 31366-01-5; Thu, 12 Feb 2004 18:25:36 -0700 (MST) Subject: Re: Review of last summer's PITR patch From: Cott Lang To: Tom Lane Cc: pgsql-hackers-pitr@postgresql.org In-Reply-To: <25866.1076634863@sss.pgh.pa.us> References: <25856.1076553698@sss.pgh.pa.us> <1076633300.4312.214.camel@blackbox> <25866.1076634863@sss.pgh.pa.us> Content-Type: text/plain Message-Id: <1076635535.4314.1.camel@blackbox> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) Date: Thu, 12 Feb 2004 18:25:35 -0700 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at internetstaff.com X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200402/10 X-Sequence-Number: 10 On Thu, 2004-02-12 at 18:14, Tom Lane wrote: > Cott Lang writes: > > * The ability to force a WAL log switch to ensure all changes during the > > backup are flushed to archived logs and copied. > > Why does that require a log switch? You can copy the active log file in > any case. (There was actually code to do that in J.R.'s patch, which I > disregarded because I see no point in it ...) Maybe it doesn't, I'm certainly no expert in PG internals. :) It just seems like a Good Thing (TM) to ensure that any possible changes to the data files during the backup are in the logs that are copied to the archive destination and backed up as part of the hot backup.