X-Original-To: pgsql-hackers-win32-postgresql.org@localhost.postgresql.org Received: from localhost (av.hub.org [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id E059CD8A69; Thu, 8 Sep 2005 20:49:55 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 60810-10; Thu, 8 Sep 2005 23:49:52 +0000 (GMT) Received: from yass.opencloud.co.nz (yass.opencloud.co.nz [203.79.85.162]) by svr1.postgresql.org (Postfix) with ESMTP id 3D726D8A54; Thu, 8 Sep 2005 20:49:53 -0300 (ADT) Received: from 203-79-104-60.cable.paradise.net.nz ([203.79.104.60] helo=[192.168.0.20]) by yass.opencloud.co.nz with asmtp (TLS-1.0:DHE_RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1EDW9S-0000mY-Mb; Fri, 09 Sep 2005 11:49:54 +1200 Message-ID: <4320CE22.4070408@opencloud.com> Date: Fri, 09 Sep 2005 11:49:54 +1200 From: Oliver Jowett User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050324) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tom Lane Cc: Merlin Moncure , pgsql-patches@postgresql.org, pgsql-hackers-win32@postgresql.org Subject: Re: [PATCHES] Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL References: <6EE64EF3AB31D5448D0007DD34EEB3417DD2C6@Herge.rcsinc.local> <4320C4BE.7010306@opencloud.com> <26590.1126221622@sss.pgh.pa.us> <4320CA2E.1000104@opencloud.com> <26710.1126222815@sss.pgh.pa.us> In-Reply-To: <26710.1126222815@sss.pgh.pa.us> X-Enigmail-Version: 0.90.2.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.008 required=5 tests=[AWL=0.008] X-Spam-Level: X-Archive-Number: 200509/12 X-Sequence-Number: 3378 Tom Lane wrote: > Oliver Jowett writes: > >>The assumption I'm making is that if the TCP_* values are present at >>compile time, then you can make a setsockopt() call and get a sane error >>code back if there's no support -- rather than a segfault, or having the >>OS spontaneously do weird things to the connection, or anything like >>that. Is that a reasonable thing to assume? > > > Well, on a sane OS it's reasonable. I dunno about Windows ;-) > > One question to ask is whether we should treat the setsockopt failure > as fatal or not. It seems to me that aborting the connection could > reasonably be called an overreaction to a bad parameter setting; > couldn't we just set the GUC variable to zero and keep going? There's no real reason why not; currently the code looks like this: > /* Set default keepalive parameters. This should also catch > * misconfigurations (non-zero values when socket options aren't > * supported) > */ > if (pq_setkeepalivesidle(tcp_keepalives_idle, port) != STATUS_OK) > return STATUS_ERROR; > > if (pq_setkeepalivesinterval(tcp_keepalives_interval, port) != STATUS_OK) > return STATUS_ERROR; > > if (pq_setkeepalivescount(tcp_keepalives_count, port) != STATUS_OK) > return STATUS_ERROR; We could just log (already done inside pq_*, IIRC) and continue, instead of erroring out. It's just the way it is because I personally prefer misconfigurations to break loudly, so you have to fix them ;-) -O