From: "Regina Obe" <lr@pcorp.us>
To: <strk@kbt.io>,
	<pgsql-hackers@postgresql.org>,
	"'Laurenz Albe'" <laurenz.albe@cybertec.at>,
	"'Tom Lane'" <tgl@sss.pgh.pa.us>
References: <YgakFklJyM5pNdt+@c19> <001d01d87211$edbd5b50$c93811f0$@pcorp.us>
 <d3924670ba8fefa42f4bd462c5b7f6349d63f4d3.camel@cybertec.at>
 <Ypsj95RJSARwfQt6@c19> <YyJPHOfwLIjxxi9u@c19> <YyJPicrQVVXOs2QE@c19>
In-Reply-To: <YyJPicrQVVXOs2QE@c19>
Subject: RE: [PATCH] Support % wildcard in extension upgrade filenames
Date: Mon, 31 Oct 2022 01:55:05 -0400
Message-ID: <000001d8eced$539c5bf0$fad513d0$@pcorp.us>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: 
 AQGYmaaUCwtlrmE55CHyCSUXu9VHkgJQLI/iAiPUhQ4CZFddqQJAUCuyAcAiYiOuUco5cA==
Content-Language: en-us
Archived-At: 
 <https://www.postgresql.org/message-id/000001d8eced%24539c5bf0%24fad513d0%24%40pcorp.us>
Precedence: bulk

Just to reiterate the main impetus for this patch is to save PostGIS from
shipping 100s of duplicate extension files for each release. 

> And now with the actual patch attached ... (sorry)
> 
> --strk;
> 

Sandro, can you submit an updated version of this patch.
I was testing it out and looked good first time.

But I retried just now testing against master, and it fails with 

commands/extension.o: In function `file_exists':
postgresql-git\src\backend\commands/extension.c:3430: undefined reference to
`AssertArg'

It seems 2 days ago AssertArg and AssertState were removed.

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=b1099eca8f38f
f5cfaf0901bb91cb6a22f909bc6

So your use of AssertArg needs to be replaced with Assert I guess. 
I did that and was able to test again with a sample extension I made

Called:

wildtest

1) The wildcard patch in its current state only does anything if 

wildcard_upgrades = true 

is in the control file. If it's false or missing, then the behavior of
extension upgrades doesn't change.


2) It only understands % as a complete wildcard for a version number

So this is legal
wildtest--%--2.0.sql

This does nothing
wildtest--2%--2.0.sql

3) I confirmed that if you have a path such as

wildtest--2.0--2.2.sql
wildtest--%--2.2.sql

then the exact match trumps the wildcard. In the above case if I am on 2.0
and going to 2.2, the wildtest--2.0--2.2.sql script is used instead of the
wildtest--% one.

4) It is not possible to downgrade with the wildcard.  For example I had
paths
wildtest--%--2.1.sql  

and I was unable to go from a version 2.2 down to a version 2.1.  I didn't
check why that was so, but probably a good thing.

If everyone is okay with this patch, we'll go ahead and add tests and
documentation to go with it.

Thanks,
Regina