From: "Regina Obe" <lr@pcorp.us>
To: "'Christoph Berg'" <cb@df7cb.de>,
	<pgsql-hackers@lists.postgresql.org>,
	<pgsql-hackers@postgresql.org>
Cc: "'Sandro Santilli'" <strk@kbt.io>,
	"'Laurenz Albe'" <laurenz.albe@cybertec.at>,
	"'Tom Lane'" <tgl@sss.pgh.pa.us>,
	"'Paul Ramsey'" <pramsey@cleverelephant.ca>
References: <YgakFklJyM5pNdt+@c19> <001d01d87211$edbd5b50$c93811f0$@pcorp.us>
 <d3924670ba8fefa42f4bd462c5b7f6349d63f4d3.camel@cybertec.at>
 <Ypsj95RJSARwfQt6@c19> <YyJPHOfwLIjxxi9u@c19> <Y25zMZG45ENExfNL@msg.df7cb.de>
In-Reply-To: <Y25zMZG45ENExfNL@msg.df7cb.de>
Subject: RE: [PATCH] Support % wildcard in extension upgrade filenames
Date: Sun, 13 Nov 2022 23:46:50 -0500
Message-ID: <000001d8f7e4$1c840d50$558c27f0$@pcorp.us>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: 
 AQGYmaaUCwtlrmE55CHyCSUXu9VHkgJQLI/iAiPUhQ4CZFddqQJAUCuyAqHyhvWuYLOwEA==
Content-Language: en-us
Archived-At: 
 <https://www.postgresql.org/message-id/000001d8f7e4%241c840d50%24558c27f0%24%40pcorp.us>
Precedence: bulk

> Re: Sandro Santilli
> > I'm attaching an updated version of the patch. This time the patch is
> > tested. Nothing changes unless the .control file for the subject
> > extension doesn't have a "wildcard_upgrades = true" statement.
> >
> > When wildcard upgrades are enabled, a file with a "%" symbol as the
> > "source" part of the upgrade path will match any version and
> 
> Fwiw I believe wildcard_upgrades isn't necessary in the .control file.
> If there are no % files, none would be used anyway, and if there are, it's
clear
> it's meant as wildcard since % won't appear in any remotely sane version
> number.
> 
> Christoph

I also like the idea of skipping the wildcard_upgrades syntax.
Then there is no need to have a conditional control file for PG 16 vs. older
versions.

Thanks,
Regina