From: "Regina Obe" <lr@pcorp.us>
To: "'Gregory Stark \(as CFM\)'" <stark.cfm@gmail.com>,
	"'Sandro Santilli'" <strk@kbt.io>
Cc: <pgsql-hackers@lists.postgresql.org>,
	"'Regina Obe'" <r@pcorp.us>
References: <003001d8f4ae$402282c0$c0678840$@pcorp.us> <000401d94bc8$48dff700$da9fe500$@pcorp.us> <167762779361.628976.14009177203307564086.pgcf@coridan.postgresql.org> <CAM-w4HP91M-r=h4nExwonHf03SRwKyNYnvFHX2FFoFMv0pRQBA@mail.gmail.com>
In-Reply-To: <CAM-w4HP91M-r=h4nExwonHf03SRwKyNYnvFHX2FFoFMv0pRQBA@mail.gmail.com>
Subject: RE: Ability to reference other extensions by schema in extension scripts
Date: Mon, 6 Mar 2023 16:40:29 -0500
Message-ID: <001201d95074$46135200$d239f600$@pcorp.us>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQFgXZxpr0yOB+9uS1Xwc1lFBKthIAFb3UkpAlqGOBEBdWkveq+2zk3w
Content-Language: en-us
Archived-At: <https://www.postgresql.org/message-id/001201d95074%2446135200%24d239f600%24%40pcorp.us>
Precedence: bulk

> It looks like this patch needs a quick rebase, there's a conflict in =
the
> meson.build.
>=20
> I'll leave the state since presumably this would be easy to resolve =
but it would
> be more likely to get attention if it's actually building cleanly.
>=20
> http://cfbot.cputube.org/patch_42_4023.log
>=20
> On Tue, 28 Feb 2023 at 18:44, Sandro Santilli <strk@kbt.io> wrote:
> >
> > The following review has been posted through the commitfest =
application:
> > make installcheck-world:  tested, failed
> > Implements feature:       tested, passed
> > Spec compliant:           tested, passed
> > Documentation:            tested, passed
> >
> > I've applied the patch attached to message
> > https://www.postgresql.org/message-
> id/000401d94bc8%2448dff700%24da9fe5
> > 00%24%40pcorp.us (md5sum a7d45a32c054919d94cd4a26d7d07c20) onto
> > current tip of the master branch being
> > 128dd9f9eca0b633b51ffcd5b0f798fbc48ec4c0
> >
> > The review written in https://www.postgresql.org/message-
> id/20230228224608.ak7br5shev4wic5a%40c19 all still applies.
> >
> > The `make installcheck-world`  test fails for me but the failures =
seem
> unrelated to the patch (many occurrences of "+ERROR:  function
> pg_input_error_info(unknown, unknown) does not exist" in the
> regression.diff).
> >
> > Documentation exists for the new feature
> >
> > The new status of this patch is: Ready for Committer
>=20
>=20
>=20
> --
> Gregory Stark
> As Commitfest Manager

Just sent a note about the wildcard one.  Was this conflicting with the =
wildcard one or some other.
I can rebase if it was conflicting with another one, if it was the =
wildcard one, then maybe we should commit this one and we'll rebase the =
wildcard one.

We would like to submit the wildcard one too, but I think Tom had some =
reservations on that one.

Thanks,
Regina