From: "Regina Obe" <lr@pcorp.us>
To: <strk@kbt.io>,
	"'Mat Arye'" <mat@timescaledb.com>
Cc: "'Yurii Rashkovskii'" <yrashk@gmail.com>,
	"'Tom Lane'" <tgl@sss.pgh.pa.us>,
	"'Regina Obe'" <r@pcorp.us>,
	<pgsql-hackers@lists.postgresql.org>
References: <166914379479.1121.7549798686571352890.pgcf@coridan.postgresql.org> <55512.1673304709@sss.pgh.pa.us> <CA+RLCQwWpMuKtqg7eBOjvzpJc-hE708WpHG2=z5B969xncQS3w@mail.gmail.com> <20230409204629.sf4fptx672iehcau@c19> <000501d96c23$0f05bdf0$2d1139d0$@pcorp.us> <20230411184823.s3cctaf63qvfeqlj@c19> <006201d96cb5$3d23b150$b76b13f0$@pcorp.us> <20230411212737.phtzffycglbdhmpx@c19> <002201d96e57$e50461a0$af0d24e0$@pcorp.us> <CADsUR0AfzAcSEL4z4NzjQ2Kp16LXQx=dCc0oVvZuS_C_iNW1nQ@mail.gmail.com> <20230427104957.knkkt3klh5uabzke@c19>
In-Reply-To: <20230427104957.knkkt3klh5uabzke@c19>
Subject: RE: [PATCH] Support % wildcard in extension upgrade filenames
Date: Fri, 28 Apr 2023 08:10:00 -0400
Message-ID: <001201d979ca$5c2a21c0$147e6540$@pcorp.us>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQFbcZ7/grqD0vV/EmaJv8lLJWaGegMCsC7JAZ9uEBECbwDxTgKlQDfPAYNb38QC93uYewJX2puLASlKzDAB1ZCGvAEnViIPr5c1l9A=
Content-Language: en-us
Archived-At: <https://www.postgresql.org/message-id/001201d979ca%245c2a21c0%24147e6540%24%40pcorp.us>
Precedence: bulk

> 
> > As for Tom's concern about downgrades, I think it's valid but it's a
> > case that is easy to test for in Plpgsql and either handle or error.
> > For example, we use semver so testing for a downgrade at the top of
> > the upgrade script is trivial.
> 

I was thinking about this more.  The extension model as it stands doesn't
allow an extension author to define version hierarchy.  We handle this
internally in our scripts to detect a downgrade attempt and stop it similar
to what Mat is saying.

Most of that is basically converting our version string to a numeric number
which we largely do with a regex pattern.

I was thinking if there were some way to codify that regex pattern in our
control file, then wild cards can only be applied if such a pattern is
defined and the 

%--<target version>

The % has to be numerically before the target version.


Thanks,
Regina