Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1svxZG-000z2G-9G for pgsql-hackers@arkaria.postgresql.org; Wed, 02 Oct 2024 11:30:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1svxZF-00EZNA-M2 for pgsql-hackers@arkaria.postgresql.org; Wed, 02 Oct 2024 11:30:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1svxZE-00EZMx-4h for pgsql-hackers@lists.postgresql.org; Wed, 02 Oct 2024 11:30:53 +0000 Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1svxZA-0027pv-Sb for pgsql-hackers@postgresql.org; Wed, 02 Oct 2024 11:30:50 +0000 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id 73CBC13800F0 for ; Wed, 2 Oct 2024 07:30:47 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Wed, 02 Oct 2024 07:30:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm1; t=1727868647; x=1727955047; bh=7AaEtpvQ34DQtgOhrjW+TPGJamAMS7pk IrZQSib/7gM=; b=Hrws01XmX/ody++PxzfODbQW0WX6GB6BJER7+dhj1yt6VX1v rWy9alUd+IUHlnu1sF1ueznxuTYlfMsjt/G77/L2OIXvX16/gw2+Be9aqF7u0ilN 6JU7wlXtTRnNiJY27qGtBViB23iK1hWWJOmsVKI+kse5qUGjbBcCul9RRWw+Mcdp Aclh4XuOaf+53OoX/rY6Zfs48+BEPcVdsjWj/qJDWr4RtBGTnaOlXHmGNvBfzDnQ C2W+ijnXq1f8vMODaTFUqISsStipeUUAbWkHLv5yXPgQOaKEMtk/rjzueEWybSZw yofe5+3q+NRjIkr/qFj9sxxHIZYAsignnJA04Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1727868647; x=1727955047; bh=7AaEtpvQ34DQtgOhrjW+TPGJamAMS7pkIrZ QSib/7gM=; b=IB1JUCZTbcm04X0rxZSeFL2UpuSwdM1Ae1dAGm5bin/H3k4mpQf bG2V49objMZ/ZHjK9Ev8KJGfbDyN7HJgmX50xrdNIZ8bphXYEfiICa85yOrTqeLh FXUA5qaLQDOSDK8JjYif5351Euf4gF/G7kXPYH7pkiedREWKzfM+wUBhKh2i/azX 7dYzqwYZRiR17BW/KNYy0ND67FUfiMSbql7gq2Ny7lgB8xwLhCunrMuRWOLWlh0K Fi7faMn6Ezt2FTD7EkWINIoQvbaWor0cUoXvD9q0d17lvm+rnb8aR6RdvccpzrxN uBR7FawPEmXCt3nwp6zCyKm9vl1TUdqvaag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdduledgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpegtkfffgg gfhffuvfesmhdtreertddvjeenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhht uceophgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgqeenucggtffrrghtthgvrhhnpe ehteekudegtdehtedttefhudekjefgudeiheeiteffuedtteffkeekgfelvdffleenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrse gvihhsvghnthhrrghuthdrohhrghdpnhgspghrtghpthhtohepuddpmhhouggvpehsmhht phhouhhtpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrshesphhoshhtghhrvghsqh hlrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 2 Oct 2024 07:30:46 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------DK8U1Tr78BcbhgPNBa5wvQ8L" Message-ID: <001d457e-c118-4219-8132-e1846c2ae3c9@eisentraut.org> Date: Wed, 2 Oct 2024 07:30:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Peter Eisentraut Subject: Rename PageData to XLogPageData To: pgsql-hackers List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------DK8U1Tr78BcbhgPNBa5wvQ8L Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I was fiddling a bit with making some Page-related APIs const-proof, which might involve changing something like "Page p" to "const PageData *p", but I was surprised that a type PageData exists but it's an unrelated type local to generic_xlog.c. This patch renames that type to a more specific name XLogPageData. This makes room for possibly adding another PageData type with the earlier meaning, but that's not done here. But I think even without that, this patch is a useful little cleanup that makes the code more consistent and clear. --------------DK8U1Tr78BcbhgPNBa5wvQ8L Content-Type: text/plain; charset=UTF-8; name="0001-Rename-PageData-to-XLogPageData.patch" Content-Disposition: attachment; filename="0001-Rename-PageData-to-XLogPageData.patch" Content-Transfer-Encoding: base64 RnJvbSA1ZDEzMjM5ZThhMjhmMjkwOWMwM2Y1NDYyY2Y5MTJiYjcxMjQ5NTQ1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogV2VkLCAyIE9jdCAyMDI0IDA3OjE2OjU1IC0wNDAwClN1YmplY3Q6 IFtQQVRDSF0gUmVuYW1lIFBhZ2VEYXRhIHRvIFhMb2dQYWdlRGF0YQoKSW4gdGhlIFBvc3Rn cmVTUUwgQyB0eXBlIG5hbWluZyBzY2hlbWEsIHRoZSB0eXBlIFBhZ2VEYXRhIHNob3VsZCBi ZQp3aGF0IHRoZSBwb2ludGVyIG9mIHR5cGUgUGFnZSBwb2ludHMgdG8uICBCdXQgaW4gdGhp cyBjYXNlIGl0J3MKYWN0dWFsbHkgYW4gdW5yZWxhdGVkIHR5cGUgbG9jYWwgdG8gZ2VuZXJp Y194bG9nLmMuICBSZW5hbWUgdGhhdCB0byBhCm1vcmUgc3BlY2lmaWMgbmFtZS4gIFRoaXMg bWFrZXMgcm9vbSB0byBwb3NzaWJsZSBhZGQgYSBQYWdlRGF0YSB0eXBlCndpdGggdGhlIG1l bnRpb25lZCBtZWFuaW5nLCBidXQgdGhpcyBpcyBub3QgZG9uZSBoZXJlLgotLS0KIHNyYy9i YWNrZW5kL2FjY2Vzcy90cmFuc2FtL2dlbmVyaWNfeGxvZy5jIHwgMjQgKysrKysrKysrKyst LS0tLS0tLS0tLS0KIHNyYy90b29scy9wZ2luZGVudC90eXBlZGVmcy5saXN0ICAgICAgICAg IHwgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0vZ2VuZXJp Y194bG9nLmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS9nZW5lcmljX3hsb2cuYwpp bmRleCBlODUyMjc4MTYzMS4uYjY1NzJjMjhhMzQgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5k L2FjY2Vzcy90cmFuc2FtL2dlbmVyaWNfeGxvZy5jCisrKyBiL3NyYy9iYWNrZW5kL2FjY2Vz cy90cmFuc2FtL2dlbmVyaWNfeGxvZy5jCkBAIC01NSw3ICs1NSw3IEBAIHR5cGVkZWYgc3Ry dWN0CiAJY2hhcgkgICAqaW1hZ2U7CQkJLyogY29weSBvZiBwYWdlIGltYWdlIGZvciBtb2Rp ZmljYXRpb24sIGRvIG5vdAogCQkJCQkJCQkgKiBkbyBpdCBpbi1wbGFjZSB0byBoYXZlIGFs aWduZWQgbWVtb3J5IGNodW5rICovCiAJY2hhcgkJZGVsdGFbTUFYX0RFTFRBX1NJWkVdOwkv KiBkZWx0YSBiZXR3ZWVuIHBhZ2UgaW1hZ2VzICovCi19IFBhZ2VEYXRhOworfSBYTG9nUGFn ZURhdGE7CiAKIC8qCiAgKiBTdGF0ZSBvZiBnZW5lcmljIHhsb2cgcmVjb3JkIGNvbnN0cnVj dGlvbi4gIE11c3QgYmUgYWxsb2NhdGVkIGF0IGFuIEkvTwpAQCAtNjYsMTcgKzY2LDE3IEBA IHN0cnVjdCBHZW5lcmljWExvZ1N0YXRlCiAJLyogUGFnZSBpbWFnZXMgKHByb3Blcmx5IGFs aWduZWQsIG11c3QgYmUgZmlyc3QpICovCiAJUEdJT0FsaWduZWRCbG9jayBpbWFnZXNbTUFY X0dFTkVSSUNfWExPR19QQUdFU107CiAJLyogSW5mbyBhYm91dCBlYWNoIHBhZ2UsIHNlZSBh Ym92ZSAqLwotCVBhZ2VEYXRhCXBhZ2VzW01BWF9HRU5FUklDX1hMT0dfUEFHRVNdOworCVhM b2dQYWdlRGF0YSBwYWdlc1tNQVhfR0VORVJJQ19YTE9HX1BBR0VTXTsKIAlib29sCQlpc0xv Z2dlZDsKIH07CiAKLXN0YXRpYyB2b2lkIHdyaXRlRnJhZ21lbnQoUGFnZURhdGEgKnBhZ2VE YXRhLCBPZmZzZXROdW1iZXIgb2Zmc2V0LAorc3RhdGljIHZvaWQgd3JpdGVGcmFnbWVudChY TG9nUGFnZURhdGEgKnBhZ2VEYXRhLCBPZmZzZXROdW1iZXIgb2Zmc2V0LAogCQkJCQkJICBP ZmZzZXROdW1iZXIgbGVuZ3RoLCBjb25zdCBjaGFyICpkYXRhKTsKLXN0YXRpYyB2b2lkIGNv bXB1dGVSZWdpb25EZWx0YShQYWdlRGF0YSAqcGFnZURhdGEsCitzdGF0aWMgdm9pZCBjb21w dXRlUmVnaW9uRGVsdGEoWExvZ1BhZ2VEYXRhICpwYWdlRGF0YSwKIAkJCQkJCQkgICBjb25z dCBjaGFyICpjdXJwYWdlLCBjb25zdCBjaGFyICp0YXJnZXRwYWdlLAogCQkJCQkJCSAgIGlu dCB0YXJnZXRTdGFydCwgaW50IHRhcmdldEVuZCwKIAkJCQkJCQkgICBpbnQgdmFsaWRTdGFy dCwgaW50IHZhbGlkRW5kKTsKLXN0YXRpYyB2b2lkIGNvbXB1dGVEZWx0YShQYWdlRGF0YSAq cGFnZURhdGEsIFBhZ2UgY3VycGFnZSwgUGFnZSB0YXJnZXRwYWdlKTsKK3N0YXRpYyB2b2lk IGNvbXB1dGVEZWx0YShYTG9nUGFnZURhdGEgKnBhZ2VEYXRhLCBQYWdlIGN1cnBhZ2UsIFBh Z2UgdGFyZ2V0cGFnZSk7CiBzdGF0aWMgdm9pZCBhcHBseVBhZ2VSZWRvKFBhZ2UgcGFnZSwg Y29uc3QgY2hhciAqZGVsdGEsIFNpemUgZGVsdGFTaXplKTsKIAogCkBAIC04Nyw3ICs4Nyw3 IEBAIHN0YXRpYyB2b2lkIGFwcGx5UGFnZVJlZG8oUGFnZSBwYWdlLCBjb25zdCBjaGFyICpk ZWx0YSwgU2l6ZSBkZWx0YVNpemUpOwogICogYWN0dWFsIGRhdGEgKG9mIGxlbmd0aCBsZW5n dGgpLgogICovCiBzdGF0aWMgdm9pZAotd3JpdGVGcmFnbWVudChQYWdlRGF0YSAqcGFnZURh dGEsIE9mZnNldE51bWJlciBvZmZzZXQsIE9mZnNldE51bWJlciBsZW5ndGgsCit3cml0ZUZy YWdtZW50KFhMb2dQYWdlRGF0YSAqcGFnZURhdGEsIE9mZnNldE51bWJlciBvZmZzZXQsIE9m ZnNldE51bWJlciBsZW5ndGgsCiAJCQkgIGNvbnN0IGNoYXIgKmRhdGEpCiB7CiAJY2hhcgkg ICAqcHRyID0gcGFnZURhdGEtPmRlbHRhICsgcGFnZURhdGEtPmRlbHRhTGVuOwpAQCAtMTE4 LDcgKzExOCw3IEBAIHdyaXRlRnJhZ21lbnQoUGFnZURhdGEgKnBhZ2VEYXRhLCBPZmZzZXRO dW1iZXIgb2Zmc2V0LCBPZmZzZXROdW1iZXIgbGVuZ3RoLAogICogYWJvdXQgdGhlIGRhdGEt bWF0Y2hpbmcgbG9vcHMuCiAgKi8KIHN0YXRpYyB2b2lkCi1jb21wdXRlUmVnaW9uRGVsdGEo UGFnZURhdGEgKnBhZ2VEYXRhLAorY29tcHV0ZVJlZ2lvbkRlbHRhKFhMb2dQYWdlRGF0YSAq cGFnZURhdGEsCiAJCQkJICAgY29uc3QgY2hhciAqY3VycGFnZSwgY29uc3QgY2hhciAqdGFy Z2V0cGFnZSwKIAkJCQkgICBpbnQgdGFyZ2V0U3RhcnQsIGludCB0YXJnZXRFbmQsCiAJCQkJ ICAgaW50IHZhbGlkU3RhcnQsIGludCB2YWxpZEVuZCkKQEAgLTIyNSw3ICsyMjUsNyBAQCBj b21wdXRlUmVnaW9uRGVsdGEoUGFnZURhdGEgKnBhZ2VEYXRhLAogICogYW5kIHN0b3JlIGl0 IGluIHBhZ2VEYXRhJ3MgZGVsdGEgZmllbGQuCiAgKi8KIHN0YXRpYyB2b2lkCi1jb21wdXRl RGVsdGEoUGFnZURhdGEgKnBhZ2VEYXRhLCBQYWdlIGN1cnBhZ2UsIFBhZ2UgdGFyZ2V0cGFn ZSkKK2NvbXB1dGVEZWx0YShYTG9nUGFnZURhdGEgKnBhZ2VEYXRhLCBQYWdlIGN1cnBhZ2Us IFBhZ2UgdGFyZ2V0cGFnZSkKIHsKIAlpbnQJCQl0YXJnZXRMb3dlciA9ICgoUGFnZUhlYWRl cikgdGFyZ2V0cGFnZSktPnBkX2xvd2VyLAogCQkJCXRhcmdldFVwcGVyID0gKChQYWdlSGVh ZGVyKSB0YXJnZXRwYWdlKS0+cGRfdXBwZXIsCkBAIC0zMDMsNyArMzAzLDcgQEAgR2VuZXJp Y1hMb2dSZWdpc3RlckJ1ZmZlcihHZW5lcmljWExvZ1N0YXRlICpzdGF0ZSwgQnVmZmVyIGJ1 ZmZlciwgaW50IGZsYWdzKQogCS8qIFNlYXJjaCBhcnJheSBmb3IgZXhpc3RpbmcgZW50cnkg b3IgZmlyc3QgdW51c2VkIHNsb3QgKi8KIAlmb3IgKGJsb2NrX2lkID0gMDsgYmxvY2tfaWQg PCBNQVhfR0VORVJJQ19YTE9HX1BBR0VTOyBibG9ja19pZCsrKQogCXsKLQkJUGFnZURhdGEg ICAqcGFnZSA9ICZzdGF0ZS0+cGFnZXNbYmxvY2tfaWRdOworCQlYTG9nUGFnZURhdGEgKnBh Z2UgPSAmc3RhdGUtPnBhZ2VzW2Jsb2NrX2lkXTsKIAogCQlpZiAoQnVmZmVySXNJbnZhbGlk KHBhZ2UtPmJ1ZmZlcikpCiAJCXsKQEAgLTM1Miw3ICszNTIsNyBAQCBHZW5lcmljWExvZ0Zp bmlzaChHZW5lcmljWExvZ1N0YXRlICpzdGF0ZSkKIAkJICovCiAJCWZvciAoaSA9IDA7IGkg PCBNQVhfR0VORVJJQ19YTE9HX1BBR0VTOyBpKyspCiAJCXsKLQkJCVBhZ2VEYXRhICAgKnBh Z2VEYXRhID0gJnN0YXRlLT5wYWdlc1tpXTsKKwkJCVhMb2dQYWdlRGF0YSAqcGFnZURhdGEg PSAmc3RhdGUtPnBhZ2VzW2ldOwogCQkJUGFnZQkJcGFnZTsKIAkJCVBhZ2VIZWFkZXIJcGFn ZUhlYWRlcjsKIApAQCAtNDAxLDcgKzQwMSw3IEBAIEdlbmVyaWNYTG9nRmluaXNoKEdlbmVy aWNYTG9nU3RhdGUgKnN0YXRlKQogCQkvKiBTZXQgTFNOICovCiAJCWZvciAoaSA9IDA7IGkg PCBNQVhfR0VORVJJQ19YTE9HX1BBR0VTOyBpKyspCiAJCXsKLQkJCVBhZ2VEYXRhICAgKnBh Z2VEYXRhID0gJnN0YXRlLT5wYWdlc1tpXTsKKwkJCVhMb2dQYWdlRGF0YSAqcGFnZURhdGEg PSAmc3RhdGUtPnBhZ2VzW2ldOwogCiAJCQlpZiAoQnVmZmVySXNJbnZhbGlkKHBhZ2VEYXRh LT5idWZmZXIpKQogCQkJCWNvbnRpbnVlOwpAQCAtNDE1LDcgKzQxNSw3IEBAIEdlbmVyaWNY TG9nRmluaXNoKEdlbmVyaWNYTG9nU3RhdGUgKnN0YXRlKQogCQlTVEFSVF9DUklUX1NFQ1RJ T04oKTsKIAkJZm9yIChpID0gMDsgaSA8IE1BWF9HRU5FUklDX1hMT0dfUEFHRVM7IGkrKykK IAkJewotCQkJUGFnZURhdGEgICAqcGFnZURhdGEgPSAmc3RhdGUtPnBhZ2VzW2ldOworCQkJ WExvZ1BhZ2VEYXRhICpwYWdlRGF0YSA9ICZzdGF0ZS0+cGFnZXNbaV07CiAKIAkJCWlmIChC dWZmZXJJc0ludmFsaWQocGFnZURhdGEtPmJ1ZmZlcikpCiAJCQkJY29udGludWU7CmRpZmYg LS1naXQgYS9zcmMvdG9vbHMvcGdpbmRlbnQvdHlwZWRlZnMubGlzdCBiL3NyYy90b29scy9w Z2luZGVudC90eXBlZGVmcy5saXN0CmluZGV4IDVmYWJiMTI3ZDdlLi41MzExZjEwMWM0MCAx MDA2NDQKLS0tIGEvc3JjL3Rvb2xzL3BnaW5kZW50L3R5cGVkZWZzLmxpc3QKKysrIGIvc3Jj L3Rvb2xzL3BnaW5kZW50L3R5cGVkZWZzLmxpc3QKQEAgLTE5NzUsNyArMTk3NSw2IEBAIFBY X0NvbWJvCiBQWF9ITUFDCiBQWF9NRAogUGFnZQotUGFnZURhdGEKIFBhZ2VHaXN0TlNOCiBQ YWdlSGVhZGVyCiBQYWdlSGVhZGVyRGF0YQpAQCAtMzIwNCw2ICszMjAzLDcgQEAgWExvZ0R1 bXBDb25maWcKIFhMb2dEdW1wUHJpdmF0ZQogWExvZ0xvbmdQYWdlSGVhZGVyCiBYTG9nTG9u Z1BhZ2VIZWFkZXJEYXRhCitYTG9nUGFnZURhdGEKIFhMb2dQYWdlSGVhZGVyCiBYTG9nUGFn ZUhlYWRlckRhdGEKIFhMb2dQYWdlUmVhZENCCi0tIAoyLjQ2LjIKCg== --------------DK8U1Tr78BcbhgPNBa5wvQ8L--