Content-Type: multipart/alternative;
 boundary="------------10E6xtzNZ3UfMtNR0g0qpA1Z"
Message-ID: <001f81e3-2be8-46ad-9aee-1a761686712c@dunslane.net>
Date: Wed, 5 Mar 2025 11:40:55 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: log_min_messages per backend type
To: Euler Taveira <euler@eulerto.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
References: <202502051851.2nvzh3a6ukzc@alvherre.pgsql>
 <313aa202-b5fa-4e3f-95d0-83425575c66d@app.fastmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: <313aa202-b5fa-4e3f-95d0-83425575c66d@app.fastmail.com>
Archived-At: <https://www.postgresql.org/message-id/001f81e3-2be8-46ad-9aee-1a761686712c%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------10E6xtzNZ3UfMtNR0g0qpA1Z
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2025-03-04 Tu 7:33 PM, Euler Taveira wrote:
>> I think it should be acceptable to configure one global setting with
>> exceptions for particular backend types:
>>
>> log_min_messages = WARNING, autovacuum:DEBUG1
>>
>> Right now I think the code only accepts the unadorned log level if there
>> are no other items in the list.  I think the proposal downthread is to
>> use the keyword ALL for this,
>>
>>   log_min_messages = all:WARNING, autovacuum:DEBUG1   # I don't like this
>>
>> but I think it's inferior, because then "all" is not really "all", and I
>> think it would be different if I had said
>>
>>   log_min_messages = autovacuum:DEBUG1, all:WARNING   # I don't like this
>>
>> because it looks like the "all" entry should override the one I set for
>> autovacuum before, which frankly would not make sense to me.
>
> Good point. After reflection, I agree that "all" is not a good keyword.
> This patch turns backend type as optional so WARNING means apply this
> log level as a final step to the backend types that are not specified in
> the list.
>
>> So I think these two lines,
>>
>> log_min_messages = WARNING, autovacuum:DEBUG1
>> log_min_messages = autovacuum:DEBUG1, WARNING
>>
>> should behave identically and mean "set the level for autovacuum to
>> DEBUG1, and to any other backend type to WARNING.
>
> Done.


Just bikeshedding a bit ...

I'm not mad keen on this design. I think the value should be either a 
single setting like "WARNING" or a set of type:setting pairs. I agree 
that "all" is a bad name, but I think "default" would make sense.

I can live with it but I think this just looks a bit odd.


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------10E6xtzNZ3UfMtNR0g0qpA1Z
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2025-03-04 Tu 7:33 PM, Euler Taveira
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:313aa202-b5fa-4e3f-95d0-83425575c66d@app.fastmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <title></title>
      <style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
      <blockquote type="cite" id="qt" style="">
        <div>I think it should be acceptable to configure one global
          setting with<br>
        </div>
        <div>exceptions for particular backend types:<br>
        </div>
        <div><br>
        </div>
        <div>log_min_messages = WARNING, autovacuum:DEBUG1<br>
        </div>
        <div><br>
        </div>
        <div>Right now I think the code only accepts the unadorned log
          level if there<br>
        </div>
        <div>are no other items in the list.  I think the proposal
          downthread is to<br>
        </div>
        <div>use the keyword ALL for this,<br>
        </div>
        <div><br>
        </div>
        <div>  log_min_messages = all:WARNING, autovacuum:DEBUG1   # I
          don't like this<br>
        </div>
        <div><br>
        </div>
        <div>but I think it's inferior, because then "all" is not really
          "all", and I<br>
        </div>
        <div>think it would be different if I had said<br>
        </div>
        <div><br>
        </div>
        <div>  log_min_messages = autovacuum:DEBUG1, all:WARNING   # I
          don't like this<br>
        </div>
        <div><br>
        </div>
        <div>because it looks like the "all" entry should override the
          one I set for<br>
        </div>
        <div>autovacuum before, which frankly would not make sense to
          me.<br>
        </div>
      </blockquote>
      <div><br>
      </div>
      <div>Good point. After reflection, I agree that "all" is not a
        good keyword.<br>
      </div>
      <div>This patch turns backend type as optional so WARNING means
        apply this<br style="max-width:100%;height:auto;">
      </div>
      <div>log level as a final step to the backend types that are not
        specified in<br style="max-width:100%;height:auto;">
      </div>
      <div>the list.<br style="max-width:100%;height:auto;">
      </div>
      <div><br>
      </div>
      <blockquote type="cite" id="qt" style="">
        <div>So I think these two lines,<br>
        </div>
        <div><br>
        </div>
        <div>log_min_messages = WARNING, autovacuum:DEBUG1<br>
        </div>
        <div>log_min_messages = autovacuum:DEBUG1, WARNING<br>
        </div>
        <div><br>
        </div>
        <div>should behave identically and mean "set the level for
          autovacuum to<br>
        </div>
        <div>DEBUG1, and to any other backend type to WARNING.<br>
        </div>
      </blockquote>
      <div><br>
      </div>
      <div>Done.</div>
    </blockquote>
    <p><br>
    </p>
    <p>Just bikeshedding a bit ...<br>
    </p>
    <p>I'm not mad keen on this design. I think the value should be
      either a single setting like "WARNING" or a set of type:setting
      pairs. I agree that "all" is a bad name, but I think "default"
      would make sense.</p>
    <p>I can live with it but I think this just looks a bit odd.<br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><br>
    </p>
    <p><br>
    </p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------10E6xtzNZ3UfMtNR0g0qpA1Z--