Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tweaV-00GLfF-35 for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Mar 2025 09:59:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tweaT-0007Sg-Rx for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Mar 2025 09:59:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tweaT-0007SX-Ib for pgsql-hackers@lists.postgresql.org; Mon, 24 Mar 2025 09:59:17 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tweaR-000qWf-1Y for pgsql-hackers@lists.postgresql.org; Mon, 24 Mar 2025 09:59:17 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 30A6B2D12A8 for ; Mon, 24 Mar 2025 10:59:14 +0100 (CET) Received: from s981.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 1728C2CF2CE; Mon, 24 Mar 2025 10:59:14 +0100 (CET) Received: from s471.loopia.se (unknown [172.22.191.6]) by s981.loopia.se (Postfix) with ESMTP id 10EFC22B1749; Mon, 24 Mar 2025 10:59:14 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s471.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=yesql.se Received: from s899.loopia.se ([172.22.191.6]) by s471.loopia.se (s471.loopia.se [172.22.190.35]) (amavisd-new, port 10024) with LMTP id EVxXP7BSeNR9; Mon, 24 Mar 2025 10:59:13 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s899.loopia.se (Postfix) with ESMTPSA id 8A92A2C8BA7E; Mon, 24 Mar 2025 10:59:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1742810353; bh=6IeKbNhw1+yl2GzPMdztTfAJGlYi0S2oVPaMG/uF+s0=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=sNBvRfAvvX0H2i1zQmrAE1TARru90RctDZkR68ur6lCkb7emaX2l5FECbEzsqEan1 4ZYhJPtYa/HgWYKipBRF3rSmTRgoxk1G8wPX7rt6dq5xbcvqcwqFLKZKY36TuESxLu w7q2TK/j53sZMdMFucOO99bkQEyNjEx+UO1IGu09W81ryyucLqscs1rNdhVGWEcpOi DlWQsnheW7jUhjh+1F1XY7Anz7bGK9/xqczb7TZyZ74E8RGsM13bJUTrNUo8FECOgv NOa0P36hNBWPrdgSVw3ZMkz4P2vSVbyiVYcfdkBm+oTjxDOB9LhfimCOboHS1fae7x 1MW+LRqbBKa2g== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\)) Subject: Re: Test to dump and restore objects left behind by regression From: Daniel Gustafsson In-Reply-To: Date: Mon, 24 Mar 2025 10:59:03 +0100 Cc: Alvaro Herrera , vignesh C , Michael Paquier , Tom Lane , Peter Eisentraut , PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <003E8C1D-55E3-4946-BFB4-CCAD404ABE22@yesql.se> References: <202503211807.hs67n5g4hcvn@alvherre.pgsql> To: Ashutosh Bapat X-Mailer: Apple Mail (2.3776.700.51.11.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 24 Mar 2025, at 10:54, Ashutosh Bapat = wrote: > 0003 - same as 0002 in the previous patch set. It excludes statistics > from comparison, otherwise the test will fail because of bug reported > at [1]. Ideally we shouldn't commit this patch so as to test > statistics dump and restore, but in case we need the test to pass till > the bug is fixed, we should merge this patch to 0001 before > committing. If the reported bug isn't fixed before feature freeze I think we should = commit this regardless as it has clearly shown value by finding bugs (though = perhaps under PG_TEST_EXTRA or in some disconnected till the bug is fixed to = limit the blast-radius in the buildfarm). -- Daniel Gustafsson