Received: from magus.postgresql.org (magus.postgresql.org [87.238.57.229]) by mail.postgresql.org (Postfix) with ESMTP id A4683F424B0 for ; Sun, 8 Apr 2012 23:52:40 -0300 (ADT) Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]) by magus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1SH4iZ-0005a9-9d for pgsql-hackers@postgresql.org; Mon, 09 Apr 2012 02:52:39 +0000 Received: from mfs5.rdh.ecl.ntt.co.jp (mfs5.rdh.ecl.ntt.co.jp [129.60.39.144]) by tama500.ecl.ntt.co.jp (8.14.5/8.14.5) with ESMTP id q392qGkU026039; Mon, 9 Apr 2012 11:52:16 +0900 (JST) Received: from mfs5.rdh.ecl.ntt.co.jp (localhost.localdomain [127.0.0.1]) by mfs5.rdh.ecl.ntt.co.jp (Postfix) with ESMTP id 3E472E009C; Mon, 9 Apr 2012 11:52:16 +0900 (JST) Received: from dmailsv1.y.ecl.ntt.co.jp (dmailsv1.y.ecl.ntt.co.jp [129.60.53.14]) by mfs5.rdh.ecl.ntt.co.jp (Postfix) with ESMTP id 31F6CE008F; Mon, 9 Apr 2012 11:52:16 +0900 (JST) Received: from mailsv01.y.ecl.ntt.co.jp by dmailsv1.y.ecl.ntt.co.jp (8.14.5/dmailsv1-2.1) with ESMTP id q392qGNZ010287; Mon, 9 Apr 2012 11:52:16 +0900 (JST) Received: from localhost by mailsv01.y.ecl.ntt.co.jp (8.14.5/Lab-1.9) with ESMTP id q392qFTx007651; Mon, 9 Apr 2012 11:52:15 +0900 (JST) From: "Etsuro Fujita" To: "'Tom Lane'" , "'Shigeru HANADA'" Cc: References: <4E6DE18B.4010505@lab.ntt.co.jp> <4E7861C1.2000607@gmail.com> <4E8EC1D8.3080700@lab.ntt.co.jp> <4E9C6573.8050507@gmail.com> <4E9FF04B.3050504@lab.ntt.co.jp> <4EB7C07A.5030205@gmail.com> <4EC60883.2050905@lab.ntt.co.jp> <4EC648CA.5050904@gmail.com> <4EC9CBC5.3070500@lab.ntt.co.jp> <4EE1FC38.5080707@lab.ntt.co.jp> <4EE5D862.1080809@gmail.com> <4EE74C5F.3000309@lab.ntt.co.jp> <4F7D8BBF.4050004@gmail.com> <4F7E57D9.3000807@gmail.com> <12199.1333739991@sss.pgh.pa.us> In-Reply-To: <12199.1333739991@sss.pgh.pa.us> Subject: Re: WIP: Collecting statistics on CSV file data Date: Mon, 9 Apr 2012 11:55:29 +0900 Message-ID: <004201cd15fc$38bdd800$aa398800$@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQDH22M8TJ3bfLD2JkqWimYTNEyMQQFusUtDAXPlEekBhzfukQIfPSDtASvTk8UB/uZg+gKU2tiKA2vJVF8BiuoiIAGDtUleAfmn3gAB+EarfgI8ZF+AAWa39IiXyYBEUA== Content-Language: ja X-Pg-Spam-Score: -1.9 (-) X-Archive-Number: 201204/368 X-Sequence-Number: 206171 Thanks! Best regards, Etsuro Fujita -----Original Message----- From: pgsql-hackers-owner@postgresql.org [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Tom Lane Sent: Saturday, April 07, 2012 4:20 AM To: Shigeru HANADA Cc: Etsuro Fujita; pgsql-hackers@postgresql.org Subject: Re: [HACKERS] WIP: Collecting statistics on CSV file data Shigeru HANADA writes: > Just after my post, Fujita-san posted another v7 patch[1], so I merged > v7 patches into v8 patch. I've committed a modified version of this, but right after pushing it I had a better idea about what the AnalyzeForeignTable API should do. An issue that I'd not previously figured out is how analysis of an inheritance tree could deal with foreign-table members, because it wants to estimate the members' sizes before collecting the actual sample rows. However, given that we've got the work split into a precheck phase and a sample collection phase, that's not hard to solve: we could insist that the FDW give back a size estimate in the precheck phase not the sample collection phase. I'm off to fix that up ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers