Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5dXB-0005Ya-Ms for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jul 2021 00:22:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m5dWe-0006uy-VL for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jul 2021 00:22:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5dWe-0006uq-LR for pgsql-hackers@lists.postgresql.org; Tue, 20 Jul 2021 00:22:20 +0000 Received: from mxout2.routing.net ([2a03:2900:1:a::b]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5dWc-0005VB-9N for pgsql-hackers@lists.postgresql.org; Tue, 20 Jul 2021 00:22:20 +0000 Received: from mxbox3.masterlogin.de (unknown [192.168.10.78]) by mxout2.routing.net (Postfix) with ESMTP id D0D7F5FC72; Tue, 20 Jul 2021 00:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1626740535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G5lMecEvGRZArnk0+w2CvrkYe6dehuPNo0FJkWmd4v8=; b=HCkqJEpcCHBOBQ2TiVgmBihFE3cRiWLpnbdsK/HYXktAk463nqSaqEmd0RocOJHh6NbbIQ U0/aUfRaWhFsu4dPcRcyYfCmJY/6ti9kbm7yKdQX09suc86wo50ql/Isrwp4pKtlJt5g9d d3e20ThQH5LPVxOFmcINLWmnaQuubsA= Received: from remote.index.de (p578a9a34.dip0.t-ipconnect.de [87.138.154.52]) by mxbox3.masterlogin.de (Postfix) with ESMTPSA id 578C636014D; Tue, 20 Jul 2021 00:22:15 +0000 (UTC) Received: from invidia.index-gruppe.local (192.168.3.140) by acedia.index-gruppe.local (192.168.3.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 20 Jul 2021 02:22:14 +0200 Received: from acedia.index-gruppe.local (192.168.3.121) by invidia.index-gruppe.local (192.168.3.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 20 Jul 2021 02:22:14 +0200 Received: from acedia.index-gruppe.local ([fe80::d96c:8551:78c8:d947]) by acedia.index-gruppe.local ([fe80::d96c:8551:78c8:d947%13]) with mapi id 15.01.2176.014; Tue, 20 Jul 2021 02:22:14 +0200 From: Arne Roland To: Alvaro Herrera CC: vignesh C , Zhihong Yu , Pg Hackers Subject: Re: Rename of triggers for partitioned tables Thread-Topic: Rename of triggers for partitioned tables Thread-Index: AQHWxEk1+rora/wutkWbcRQhC03q0KnbGQ2sgAAECBOATmSTgIBhAeKAgBDG6bOAACCNT4AAKOcAgAAj1kP///tHgIAEsSJngAHhzjCAhX9QJP//43kAgAAjD3T///1iAABXUKhwA1bKhQAABHSL9QDdrxEAAARjdxI= Date: Tue, 20 Jul 2021 00:22:13 +0000 Message-ID: <004683a28e714bf3beb9a413a2ffbcb9@index.de> References: <6e6491608f694ca488a5d7c404c4b98d@index.de>,<202107200003.nve6a53eixra@alvherre.pgsql> In-Reply-To: <202107200003.nve6a53eixra@alvherre.pgsql> Accept-Language: en-US, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.1.33] Content-Type: multipart/alternative; boundary="_000_004683a28e714bf3beb9a413a2ffbcb9indexde_" MIME-Version: 1.0 X-Mail-ID: bdcde224-0dce-4ff2-95a5-1ed5eebcc931 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_000_004683a28e714bf3beb9a413a2ffbcb9indexde_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi! From: Alvaro Herrera Sent: Tuesday, July 20, 2021 02:03 To: Arne Roland Cc: vignesh C; Zhihong Yu; Pg Hackers Subject: Re: Rename of triggers for partitioned tables I found this coding too convoluted, so I rewrote it in a different way. You tests pass with this, but I admit I haven't double-checked them yet; I'll do that next. Is your patch based on master? It doesn't apply at my end. I don't think we need to give a NOTICE when the trigger name does not match; it doesn't really matter that the trigger was named differently before the command, does it? I'd expect the command ALTER TRIGGER name ON table_name RENAME TO new_name; to rename a trigger named "name". We are referring the trigger via it's nam= e after all. If a child is named differently we break with that assumption.= I think informing the user about that, is very valuable. Regards Arne --_000_004683a28e714bf3beb9a413a2ffbcb9indexde_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Hi!



From: Alvaro Herrera <alvherre@alvh.no-ip.org><= br>
Sent: Tuesday, July 20, 2= 021 02:03
To: Arne Roland
Cc: vignesh C; Zhihong Yu; Pg Hackers
Subject: Re: Rename of triggers for partitioned tables
 
I found this coding too convoluted, so I rewrote i= t in a different way.
You tests pass with this, but I admit I haven't double-checked them yet; I'll do that next.

Is your patch bas= ed on master? It doesn't apply at my end.

I don't think we need to give a NOTICE when the trigger name does not
match; it doesn't really matter that the trigger was named differently
before the command, does it?

I'd expect the command
ALTER TRIGGER name ON table_name RENAME TO= new_name;
to rename a trigger named "name"= . We are referring the trigger via it's name after all. If a child is named= differently we break with that assumption. I think informing the user abou= t that, is very valuable.

Regards
Arne

--_000_004683a28e714bf3beb9a413a2ffbcb9indexde_--