Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHgpy-0005sj-Ak for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Nov 2017 02:01:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHgpx-00015s-44 for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Nov 2017 02:01:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eHgpw-00015i-UF for pgsql-hackers@lists.postgresql.org; Thu, 23 Nov 2017 02:01:56 +0000 Received: from 104-190-1-44.lightspeed.sndgca.sbcglobal.net ([104.190.1.44] helo=joeconway.com) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eHgpo-0006Tu-TM for pgsql-hackers@postgresql.org; Thu, 23 Nov 2017 02:01:56 +0000 Received: from [72.214.29.243] (account jconway@joeconway.com HELO [192.168.4.41]) by joeconway.com (CommuniGate Pro SMTP 6.1.4) with ESMTPSA id 19309330 for pgsql-hackers@postgreSQL.org; Wed, 22 Nov 2017 18:01:39 -0800 To: PostgreSQL-development From: Joe Conway Subject: has_sequence_privilege() never got the memo Openpgp: id=4EA5B4659ED59CC9538139A5332B7E68B699434A Message-ID: <005147f6-8280-42e9-5a03-dd2c1e4397ef@joeconway.com> Date: Wed, 22 Nov 2017 18:01:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Dwc32gqx2veIjo1ONjM6WPnWM6RedN89R" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Dwc32gqx2veIjo1ONjM6WPnWM6RedN89R Content-Type: multipart/mixed; boundary="FHFCLV6KNDLJ5JO1XNBoQsqeJjGqVkieS"; protected-headers="v1" From: Joe Conway To: PostgreSQL-development Message-ID: <005147f6-8280-42e9-5a03-dd2c1e4397ef@joeconway.com> Subject: has_sequence_privilege() never got the memo --FHFCLV6KNDLJ5JO1XNBoQsqeJjGqVkieS Content-Type: multipart/mixed; boundary="------------069F77F6DF5527437969D5BC" Content-Language: en-US This is a multi-part message in MIME format. --------------069F77F6DF5527437969D5BC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I just noticed that has_sequence_privilege() never got the memo about "WITH GRANT OPTION". Any objections to the attached going back to all supported versions? Joe --=20 Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development --------------069F77F6DF5527437969D5BC Content-Type: text/x-patch; name="2017.11.22.000-seq_privs-missing_grantopt.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="2017.11.22.000-seq_privs-missing_grantopt.diff" diff --git a/src/backend/utils/adt/acl.c b/src/backend/utils/adt/acl.c index fa6b792..2f2758f 100644 *** a/src/backend/utils/adt/acl.c --- b/src/backend/utils/adt/acl.c *************** convert_sequence_priv_string(text *priv_ *** 2242,2249 **** --- 2242,2252 ---- { static const priv_map sequence_priv_map[] =3D { {"USAGE", ACL_USAGE}, + {"USAGE WITH GRANT OPTION", ACL_GRANT_OPTION_FOR(ACL_USAGE)}, {"SELECT", ACL_SELECT}, + {"SELECT WITH GRANT OPTION", ACL_GRANT_OPTION_FOR(ACL_SELECT)}, {"UPDATE", ACL_UPDATE}, + {"UPDATE WITH GRANT OPTION", ACL_GRANT_OPTION_FOR(ACL_UPDATE)}, {NULL, 0} }; =20 --------------069F77F6DF5527437969D5BC-- --FHFCLV6KNDLJ5JO1XNBoQsqeJjGqVkieS-- --Dwc32gqx2veIjo1ONjM6WPnWM6RedN89R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJaFiwCAAoJEDfy90M199hlYoUQAJQijYrihM7M5wyUp9kGrzTr QNhoDhanw7R7Za5GJUTM6EhpIMY+nmgnB6pVWYov2rD0LJ7CorWpFKLSYYG0BxQK hRPu6fz8DT4aZV7Oky3wkh9XkZ4iUkkihDp6zP29hixakPM4R7ZTA8Dz+Bxb7Kew M4J7i2nYH/ZwKGA59drW/c9o+AzcsSHsdugVcHCNTvo84lc+Nx12eejeoZoWumGD Pj+XTsVdgOUpzAD3BcIcpRJVRh8lOgqI1a9s2iHAwzkgtL7vRXFZSuzL+11KzShw ETRP8PrFi8R9N1OpuL1+4QAbHvnVL839UurbqN6Pa7j1+bz+aI1iIxijC4j5mANH tsgzOzR3Pw2W1CqhjmRiOptUDBEuwTiwexWzYQg8P5jQjbZoimv6P3ccsK6d1wiS oajfSC67bXQcu3qPenpeLMhiDSqfElD2vgJiW9cZq36Ci8ZVLATrBKEs82ZHfgMK x4oEqduN6c1RKeJyfn0zYfamJbijsKov8AsBhSDXjocErs+WASzZ4/h2igxmJsD9 bn8G2cVkgY+LiL76S+WheHzimUnhcw3ypIm0TcZ4QWQZJk5N45+mCfM1Rq2YCHRp H6PfFVasA6FYb7RwxEIy4PzDZQ4X8p11jGNg/peLhmyHzc/WL3Nnr8EYQB6K3pem ul5YDUklcKISzq1HwOAL =Ta7S -----END PGP SIGNATURE----- --Dwc32gqx2veIjo1ONjM6WPnWM6RedN89R--