Subject: Re: jsonpath syntax extensions
To: David Steele <david@pgmasters.net>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <e0fe4f7b-da0b-471c-b3da-d8adaf314357@postgrespro.ru>
 <aa27cf2e-dc75-1192-2801-019c62e83b1a@pgmasters.net>
From: Nikita Glukhov <n.gluhov@postgrespro.ru>
Organization: Postgres Professional
Message-ID: <00706fa4-7ee3-bbb0-a497-e332035164f5@postgrespro.ru>
Date: Wed, 4 Mar 2020 23:18:52 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <aa27cf2e-dc75-1192-2801-019c62e83b1a@pgmasters.net>
Content-Type: multipart/alternative;
 boundary="------------47496F127B12EAE85E11BE9F"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------47496F127B12EAE85E11BE9F
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

On 04.03.2020 19:13, David Steele wrote:

> Hi Nikita,
>
> On 2/27/20 10:57 AM, Nikita Glukhov wrote:
>>
>> Attached patches implement several useful jsonpath syntax extensions.
>> I already published them two years ago in the original SQL/JSON thread,
>> but then after creation of separate threads for SQL/JSON functions and
>> JSON_TABLE I forgot about them.
>
> Are these improvements targeted at PG13 or PG14?  This seems to be a 
> pretty big change for the last CF of PG13.  I know these have been 
> submitted before but that was a few years ago so I think they count as 
> new.

I believe that some of these improvements can get into PG13.  There is no need
to review all of them, we can choose only the simplest ones.

Most of code changes in #3-#5 consist of straightforward boilerplate jsonpath
I/O code, and only changes in jsonpath_exec.c are interesting.

Only the patch #1 is mandatory, patches #3-#6 depend on it.

The patch #2 is not necessary, if jbvArray and jbvObject values would be
wrapped into jbvBinary by JsonbValueToJsonb() call in #4 and #5.

Patch #4 is the simplest one (only 20 new lines of code in jsonpath_exec.c).

Patch #6 is the most complex one, and it affects only jsonpath execution.

-- 
Nikita Glukhov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

--------------47496F127B12EAE85E11BE9F
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>On 04.03.2020 19:13, David Steele wrote:<br>
    </p>
    <blockquote type="cite"
      cite="mid:aa27cf2e-dc75-1192-2801-019c62e83b1a@pgmasters.net">Hi
      Nikita,
      <br>
      <br>
      On 2/27/20 10:57 AM, Nikita Glukhov wrote:
      <br>
      <blockquote type="cite">
        <br>
        Attached patches implement several useful jsonpath syntax
        extensions.
        <br>
        I already published them two years ago in the original SQL/JSON
        thread,
        <br>
        but then after creation of separate threads for SQL/JSON
        functions and
        <br>
        JSON_TABLE I forgot about them.
        <br>
      </blockquote>
      <br>
      Are these improvements targeted at PG13 or PG14?  This seems to be
      a pretty big change for the last CF of PG13.  I know these have
      been submitted before but that was a few years ago so I think they
      count as new.
      <br>
    </blockquote>
    <pre>
I believe that some of these improvements can get into PG13.  There is no need
to review all of them, we can choose only the simplest ones.

Most of code changes in #3-#5 consist of straightforward boilerplate jsonpath
I/O code, and only changes in jsonpath_exec.c are interesting.

Only the patch #1 is mandatory, patches #3-#6 depend on it.

The patch #2 is not necessary, if jbvArray and jbvObject values would be
wrapped into jbvBinary by JsonbValueToJsonb() call in #4 and #5.

Patch #4 is the simplest one (only 20 new lines of code in jsonpath_exec.c).

Patch #6 is the most complex one, and it affects only jsonpath execution.

</pre>
    <div class="moz-signature">-- <br>
      Nikita Glukhov<br>
      Postgres Professional: <a href="http://www.postgrespro.com">http://www.postgrespro.com</a><br>
      The Russian Postgres Company<br>
    </div>
  </body>
</html>

--------------47496F127B12EAE85E11BE9F--