From: "myungkyu.lim" <myungkyu.lim@samsung.com>
To: "'Tomas Vondra'" <tomas.vondra@2ndquadrant.com>, "'Surafel Temesgen'"
	<surafel3000@gmail.com>, "'PostgreSQL Hackers'"
	<pgsql-hackers@postgresql.org>
In-Reply-To: <b87e80a4-15dc-079c-d3d4-41ce03f55480@2ndquadrant.com>
Subject: RE: COPY FROM WHEN condition
Date: Mon, 29 Oct 2018 13:12:20 +0900
Message-ID: <009901d46f3d$9694cf50$c3be6df0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQGAh2NG6wQCnEioIlMoXqBO2rmPJAKP1NTFAcio3ueluqOCYA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 104P
References: 
 <CALAY4q_DdpWDuB5-Zyi-oTtO2uSk8pmy+dupiRe3AvAc++1imA@mail.gmail.com>
	<CGME20181028162024epcas3p221218de77c20e62e5030c0e1c0a68dc0@epcas3p2.samsung.com>
	<b87e80a4-15dc-079c-d3d4-41ce03f55480@2ndquadrant.com>
Precedence: bulk

Hello,

Basically, this patch worked very well in my tests.

> 3) For COPY TO, the WHEN clause is accepted but ignored, leading to confu=
sing cases like this:

I found same issue.

    postgres=3D=23 copy t1 to '/home/lmk/t1.data' when c1 < 1;

In the 'COPY TO' statement, 'WHEN clause' does not do any extra work.
(include error or hint)

> 4) There are some minor code style issues in copy.c - the variable is mis=
named as when_cluase, there are no spaces after 'if' etc. See the attached =
patch fixing this.

It is recommended to use 'pg tool' when you finish development.

    src/tools/pgindent/pgindent

    pgindent is used to fix the source code style to conform to pg standard=
s.

Best regards,
Myungkyu, Lim