Subject: Re: Restore replication settings when modifying a field type
To: Euler Taveira <euler.taveira@2ndquadrant.com>
References: <c70fcab2-4866-0d9f-1d01-e75e189db342@gmail.com>
 <20191028.133939.559712139043653003.horikyota.ntt@gmail.com>
 <CAHE3wgh-JX+L_RBNQ-_SLjMNbXT4K6A5FpkLKsEmEO5mCgsUTQ@mail.gmail.com>
 <61d38b0e-0831-d206-8390-2a08bb51905d@2ndquadrant.com>
 <ec12720a-b834-05d4-f7fb-ab69bcce7112@foxmail.com>
 <0b190c18-1ab0-22ab-f249-af58ee967807@foxmail.com>
 <40e3fb7b-6362-6438-03d1-6b7f9dc0f962@2ndquadrant.com>
 <CAH503wBz6re8o+JCRUNnobJ4kCCXR4-D0OnwRw2Z0m_=nh_g1g@mail.gmail.com>
Cc: Quan Zongliang <quanzongliang@foxmail.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <01068a4d-e810-cd73-10db-6b4660b9e6b9@2ndquadrant.com>
Date: Fri, 13 Mar 2020 13:32:27 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: 
 <CAH503wBz6re8o+JCRUNnobJ4kCCXR4-D0OnwRw2Z0m_=nh_g1g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2020-03-10 14:16, Euler Taveira wrote:
> On Thu, 5 Mar 2020 at 09:45, Peter Eisentraut 
> <peter.eisentraut@2ndquadrant.com 
> <mailto:peter.eisentraut@2ndquadrant.com>> wrote:
> 
>     On 2020-02-11 00:38, Quan Zongliang wrote:
>      > new patch attached.
> 
>     I didn't like so much how the updating of the replica identity was
>     hacked into the middle of ATRewriteCatalogs().  I have an alternative
>     proposal in the attached patch that queues up an ALTER TABLE ...
>     REPLICA
>     IDENTITY command into the normal ALTER TABLE processing.  I have also
>     added tests to the test suite.
> 
> LGTM. Tests are ok. I've rebased it (because 
> 61d7c7bce3686ec02bd64abac742dd35ed9b9b01). Are you planning to backpatch 
> it? IMHO you should because it is a bug (since REPLICA IDENTITY was 
> introduced in 9.4). This patch can be applied as-is in 12 but not to 
> other older branches. I attached new patches.

Thanks.  This has been committed and backpatched to 9.5.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services