Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qSvWX-007nqd-GR for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Aug 2023 08:23:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qSvWV-007qYE-SN for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Aug 2023 08:23:32 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qSvWV-007qY6-JO for pgsql-hackers@lists.postgresql.org; Mon, 07 Aug 2023 08:23:31 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qSvWT-000zRG-8N for pgsql-hackers@lists.postgresql.org; Mon, 07 Aug 2023 08:23:30 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3176a439606so3164850f8f.3 for ; Mon, 07 Aug 2023 01:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691396608; x=1692001408; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZZcfSpBaY0LTrhnQFN+lN99GaDzuMJkQM3nk9Dsf6GA=; b=GuhuJK4NO8UtHomMZ9K73YpkDaXvKQUKwkJGeanNGOnoqMu4cvna7eiGpPS1tVu9RQ 3f6es8JkmAEQJEYrYI4rmnzZvkfzavCIUDaqA/cDlXy/oR/7TV7VYnbaPfyG3KqSsjue /4hm1pIN2OiBuyTSJ6dM92UmqRNUgtQFoNH1njxWM7VPfbLKsnR5hJgloT0SChZ0LehX 6smGsk3dB5njp4campf+rIBke3iRepGF1+0zEh5QQuvfnOtLjMyVDcVUoUtxOZEOT8S4 kU4ir+vYJPWJzC+UfvAd1Z7pWTLcpsmjoYb12qWZOhCdlipquA6+yGyvzpni1Ddq0Q72 NixA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691396608; x=1692001408; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZZcfSpBaY0LTrhnQFN+lN99GaDzuMJkQM3nk9Dsf6GA=; b=Q8hcq8JjdMIR3M33vchtHlRCCE/EKLSAfzu/3tjJ7hxkaNNOexcVFYiObTrAgIuBlt EZwoXAQd+E8ZS4A8p+XkVMyS9ombvf1qGImHRk7gC6EjKOl3WuN0mnO1G6dNONtu15Q3 8iM6N/1uWrKd2Kg83us3sy0o7+EZFh92RnSFtEcO+uARjHSYwfW9s3LDlkLTWZX4Mq1v WztfU1ycrryaxhQeYkfezyBoGx7aPdIEBulU5e8jOc6WPYQ4rM++veS4ULmOipQSbqxk +5Zw+irwA2GNfvfC6POMtg21ZpDVdDcHkTYrIXRDtw2I5Rrl+Qrwu49U0J5oT4jocU4F rpGw== X-Gm-Message-State: AOJu0YxUf8xbET8HDGzVr14VrjWegEe7khx2G7yk0jOaNUn/TD3h/YHF UmpHpsG3kiO8le2kKtDj9ZuAtDDOEZE= X-Google-Smtp-Source: AGHT+IGLQTe6ZiW3QSZ/F+fnpyMWxOdNN7ry7MSHg6eSW5leXMuJo5ZadGjAvVxdojfYpIn5cxEMKg== X-Received: by 2002:a5d:4691:0:b0:307:8c47:a266 with SMTP id u17-20020a5d4691000000b003078c47a266mr4282054wrq.61.1691396607796; Mon, 07 Aug 2023 01:23:27 -0700 (PDT) Received: from ?IPV6:2a01:cb11:55e:1700:64af:2625:1417:174a? ([2a01:cb11:55e:1700:64af:2625:1417:174a]) by smtp.gmail.com with ESMTPSA id h12-20020adff4cc000000b00314367cf43asm9659966wrp.106.2023.08.07.01.23.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 01:23:27 -0700 (PDT) Message-ID: <0109438a-9672-322b-7638-04ad47c97d0f@gmail.com> Date: Mon, 7 Aug 2023 10:23:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: WIP: new system catalog pg_wait_event Content-Language: en-US To: Tom Lane Cc: PostgreSQL Hackers References: <0e2ae164-dc89-03c3-cf7f-de86378053ac@gmail.com> <3658241.1691161701@sss.pgh.pa.us> From: "Drouvot, Bertrand" In-Reply-To: <3658241.1691161701@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 8/4/23 5:08 PM, Tom Lane wrote: > "Drouvot, Bertrand" writes: >> Now that fa88928470 generates automatically code and documentation >> related to wait events, why not exposing the wait events description >> through a system catalog relation? > > I think you'd be better off making this a view over a set-returning > function. The nearby work to allow run-time extensibility of the > set of wait events is not going to be happy with a static catalog. Oh right, good point, thanks!: I'll come back with a new patch version to make use of SRF instead. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com