Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: New Object Access Type hooks
From: Mark Dilger <mark.dilger@enterprisedb.com>
In-Reply-To: <032148cd-fcdb-6d81-58b2-137a1b77e0e6@dunslane.net>
Date: Mon, 21 Mar 2022 12:58:32 -0700
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Robert Haas <robertmhaas@gmail.com>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Jeff Davis <pgsql@j-davis.com>,
 Joe Conway <joe@crunchydata.com>,
 Andrew Dunstan <andrew@dunslane.net>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0169FE2F-3448-4F13-A0D8-0982C4086EE6@enterprisedb.com>
References: <47F87A0E-C0E5-43A6-89F6-D403F2B45175@enterprisedb.com>
 <032148cd-fcdb-6d81-58b2-137a1b77e0e6@dunslane.net>
To: Joshua Brindle <joshua.brindle@crunchydata.com>
Archived-At: <https://www.postgresql.org/message-id/0169FE2F-3448-4F13-A0D8-0982C4086EE6%40enterprisedb.com>
Precedence: bulk


> On Mar 21, 2022, at 8:41 AM, Andrew Dunstan <andrew@dunslane.net> =
wrote:
>=20
> My first inclination is to say it's probably ok. The immediately =
obvious
> alternative would be to create yet another set of functions that don't
> have classId parameters. That doesn't seem attractive.
>=20
> Modulo that issue I think patch 1 is basically ok, but we should fix =
the
> comments in objectaccess.c.  Rather than "It is [the] entrypoint ..." =
we
> should have something like "Oid variant entrypoint ..." and "Name
> variant entrypoint ...", and also fix the function names in the =
comments.

Joshua,

Do you care to create a new version of this, perhaps based on the =
v2-0001 patch I just posted?

=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company