Feedback-ID: i131946ab:Fastmail
Message-ID: <017ede6e-f3e4-b778-33d9-a59d62697771@enterprisedb.com>
Date: Tue, 14 Jun 2022 20:47:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.1
Subject: Re: [RFC] building postgres with meson -v8
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
References: <20220429174633.6io23mlwphdqdakv@alap3.anarazel.de>
 <8ced34e6-7abf-b3b2-3770-0487794753c5@enterprisedb.com>
 <20220502163602.smlwfhh2cnutxora@alap3.anarazel.de>
 <b6176b65-a138-be7e-291f-ffbddd663ed1@enterprisedb.com>
 <d4629711-d124-7afd-62b9-7ccd9c9555ed@enterprisedb.com>
 <63255c46-78cb-f018-8ae0-4a14928fcfdc@enterprisedb.com>
 <20220518194827.wsmoig5jkq5pltob@alap3.anarazel.de>
 <261aa7b4-e70b-7a1a-a1e1-03c063911acc@enterprisedb.com>
 <c931a8bd-4ba9-7980-904b-f2d5be422fa4@enterprisedb.com>
 <6c684472-0dcd-7085-f3ab-a5042fb92e64@enterprisedb.com>
 <20220614182728.hhbv7lxjnizswyeo@alap3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220614182728.hhbv7lxjnizswyeo@alap3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/017ede6e-f3e4-b778-33d9-a59d62697771%40enterprisedb.com>
Precedence: bulk

On 14.06.22 20:27, Andres Freund wrote:
> One thing I'm not quite sure about: Why does the makefile need awareness of
> the stop files, but Install.pm doesn't? I suspect currently the patch leads to
> stopwords not being installed on windows anymore?

Install.pm contains this elsewhere:

         GenerateTsearchFiles($target);
         CopySetOfFiles(
             'Stopword files',
             [ glob("src\\backend\\snowball\\stopwords\\*.stop") ],
             $target . '/share/tsearch_data/');

It's a bit confusing that the "generate" function that we are patching 
also installs some of the files right away, while the rest is installed 
by the calling function.