Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kknVI-00027f-HX for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Dec 2020 12:14:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kknVH-0007Y3-Gc for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Dec 2020 12:14:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kknVG-0007Xv-Lk for pgsql-hackers@lists.postgresql.org; Thu, 03 Dec 2020 12:14:31 +0000 Received: from [66.111.4.238] (helo=forward4-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kknVB-00046a-5s for pgsql-hackers@postgresql.org; Thu, 03 Dec 2020 12:14:29 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailforward.nyi.internal (Postfix) with ESMTP id 4890719435C9; Thu, 3 Dec 2020 07:14:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 03 Dec 2020 07:14:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=lM6T373M7yd4OaQtL5wfxTmyKGo5F2eRhl9/wKP4L qc=; b=jcUKxq0zUFF2uOA8Mmuh7M/uV2bA4NrUV4v9aS6zbmZiw/upF3ByIOE5v 42wsfXbh9DRcl+tTOwSgOqv/iHNu9q57G3hSLQObKv2zVTvkTfx/VQrZsQnWOC1y oxiGZh5+uDJloR0zU+XOWkfj7BTk7BWiPxekUBH5uKcv/vKlvuL3clVyeo76ZIXs Zbdjr54hYpF6PU7lPxo+UyzOGeJuWnxQvra/46EctiH6dhjngEOl+Z678EKVUvev h7tVuaah/LdW/IAWvzcCgsrnYkugrwUZx7OX2s7BcEgCw24VmlVGdn6OCOPy0HzE uLD95M6jf2Ho1mUWEUCGOXsInBznA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeiiedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvfhfhohfkffgfgggjtgfgsehtjeertddtfeehnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeffvdeufedtgffgveff vdehjeekjeekhedvvdeuheeghfffledvgffffffffeejudenucfkphepkeejrddujeejrd ejvddrudegvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehpvghtvghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtoh hm X-ME-Proxy: Received: from april.pezone.net (p57b1488e.dip0.t-ipconnect.de [87.177.72.142]) by mail.messagingengine.com (Postfix) with ESMTPA id 3A51B1080064; Thu, 3 Dec 2020 07:14:13 -0500 (EST) Subject: Re: SELECT INTO deprecation To: Stephen Frost References: <96dc0df3-e13a-a85d-d045-d6e2c85218da@enterprisedb.com> <20201202175836.GX16415@tamriel.snowman.net> Cc: pgsql-hackers From: Peter Eisentraut Organization: EnterpriseDB Message-ID: <01923635-387c-c3fd-d9f9-7f91f20e426b@enterprisedb.com> Date: Thu, 3 Dec 2020 13:14:11 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201202175836.GX16415@tamriel.snowman.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.238 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-12-02 18:58, Stephen Frost wrote: >> I also found some gratuitous uses of SELECT INTO in various tests and >> documentation (not ecpg or plpgsql of course). Here is a patch to adjust >> those to CREATE TABLE AS. > If we aren't actually removing SELECT INTO then I don't know that it > makes sense to just stop testing it. The point here was, there is still code that actually tests SELECT INTO specifically. But unrelated test code that just wants to set up a quick table with some rows in it ought to use the preferred syntax for doing so.