Message-ID: <0198dc87-6f25-464e-ba55-a0fbac069241@uni-muenster.de>
Date: Mon, 3 Feb 2025 11:31:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Truncate logs by max_log_size
To: Kirill Gavrilov <diphantxm@gmail.com>
Cc: Kirill Reshke <reshkekirill@gmail.com>,
 "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Euler Taveira
 <euler@eulerto.com>, pgsql-hackers@lists.postgresql.org
References: <CA+E0NR4S+NC6+QHyY_vUuQZMzLhKqczMx-jJVqtjAxF6+=JwAA@mail.gmail.com>
 <94d53a41-d1f5-4fd1-8d1e-ff36ac569848@app.fastmail.com>
 <4DA5A159-39FD-47DB-95E5-A4F65BC5782A@yandex-team.ru>
 <53e96b5a-cc77-4afa-8103-79c69afef1a6@uni-muenster.de>
 <CA+E0NR4=J-pgqEAV2weymygGmk1ePym45m2AcGyi2hpa9xRvBg@mail.gmail.com>
 <CALdSSPiq+x9pRVYvYtddTQsL8=ZMvob+vSv5mHEXbe0aoPWGig@mail.gmail.com>
 <748a7ec0-9126-4f27-a2a7-e3e449d6fdd7@uni-muenster.de>
 <CA+E0NR6tnLDanSNwcqZM_-ReBXitAOFsoaBAZBqXYEx0Di+fwQ@mail.gmail.com>
 <8a240667-de9e-455b-b3e2-62f34ec80154@uni-muenster.de>
 <CA+E0NR7=V57gVR_-CHs-0W0XL7UrKdyGfT=ZiQcuCdsDcjN94g@mail.gmail.com>
 <3f1b817f-6e7a-4e01-bfc5-50ea3724225e@uni-muenster.de>
 <CA+E0NR6MJfE8Hkk2Q-MgWUkk=Yy_4fWdiiaAKW_Ux_hcAAtAFQ@mail.gmail.com>
 <d300f773-0bfa-4925-924b-f5959d47e254@uni-muenster.de>
 <CA+E0NR7XD3wpts2GEFpZpO-M8kj9f8pTrhnAKvq5n4xjtLgLKg@mail.gmail.com>
Content-Language: en-US, de-DE
From: Jim Jones <jim.jones@uni-muenster.de>
In-Reply-To: <CA+E0NR7XD3wpts2GEFpZpO-M8kj9f8pTrhnAKvq5n4xjtLgLKg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/0198dc87-6f25-464e-ba55-a0fbac069241%40uni-muenster.de>
Precedence: bulk

Hi Kirill

On 31.01.25 11:46, Kirill Gavrilov wrote:
> Sorry for the long silence.  I fixed the indentation and a trailing
> whitespace. Should look fine now.


The patch applies cleanly, the documentation is clear, and all tests pass.

It is possible to change this new parameter session-wise, which is nice!

postgres=# SET max_log_size TO 7;
SET
postgres=# SHOW max_log_size;
 max_log_size
--------------
 7B
(1 row)


The default value now is clear and it corresponds to the value set on
postgresql.conf:

#max_log_size = 0       # max size of logged statement 

postgres=# SHOW max_log_size;
 max_log_size
--------------
 0
(1 row)


Logs are truncated as expected:

postgres=# SET max_log_size TO 6;
SET
postgres=# SELECT length('CALL xyz;');
 length
--------
      9
(1 row)

postgres=# CALL xyz;
ERROR:  syntax error at or near ";"
LINE 1: CALL xyz;


log entry:

2025-02-03 10:58:19.975 CET [123945] ERROR:  syntax error at or near ";"
at character 9
2025-02-03 10:58:19.975 CET [123945] STATEMENT:  CALL x


The issue with log entry sizes for queries containing special characters
was resolved by setting the unit to bytes.

Overall, everythingLGTM.

The new status of this patch is: Ready for Committer

Jim