Feedback-ID: i131946ab:Fastmail
Message-ID: <01bd779a-87a2-7217-a1ff-4f6d6727819a@enterprisedb.com>
Date: Fri, 12 May 2023 10:28:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <20230108030956.5q6ptk3boeisibjq@awork3.anarazel.de>
 <20230204105703.gt2j47vdn3s2gylt@alap3.anarazel.de>
 <CAH2-Wzkrh1OmRy=xNQbx4Yb708j152tZ-oPKS1S7fNURVxKTOg@mail.gmail.com>
 <20230206210205.uaaoe2l26fv256hs@awork3.anarazel.de>
 <20230309001558.b7shzvio645ebdta@awork3.anarazel.de>
 <E244808B-83A5-4E50-93BF-DF8D5544505A@enterprisedb.com>
 <20230311232226.fm442j4odhixy75p@awork3.anarazel.de>
 <ED5BB5D4-4C4D-4838-8D42-3A03CFB16791@enterprisedb.com>
 <20230311234121.qnlxuzijeqdxmzu2@awork3.anarazel.de>
 <af5567a1-aea6-fbdb-7e4b-d1e23a43c43b@enterprisedb.com>
 <20230510180408.bzxtaneotuy3hyk4@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20230510180408.bzxtaneotuy3hyk4@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/01bd779a-87a2-7217-a1ff-4f6d6727819a%40enterprisedb.com>
Precedence: bulk

On 10.05.23 20:04, Andres Freund wrote:
>> This commit adds a test
>>
>> is(scalar @lp_off, $ROWCOUNT, "acquired row offsets");
>>
>> *before* that skip_all call.  This appears to be invalid.  If the skip_all
>> happens, you get a complaint like
>>
>> t/004_verify_heapam.pl (Wstat: 0 Tests: 1 Failed: 0)
>>    Parse errors: Bad plan.  You planned 0 tests but ran 1.
>>
>> We could move the is() test after all the skip_all's.  Any thoughts?
> 
> I think the easiest fix is to just die if we can't get the offsets - it's not
> like we can really continue afterwards...

This should do it:

-is(scalar @lp_off, $ROWCOUNT, "acquired row offsets");
+scalar @lp_off == $ROWCOUNT or BAIL_OUT("row offset counts mismatch");

But I'm not sure what the latest thinking on BAIL_OUT is.  It is used 
nearby in a similar way though.