Feedback-ID: ie0a040ee:Fastmail
Message-ID: <01d19f04-9eb4-4dba-8513-2ce875335eea@eisentraut.org>
Date: Wed, 1 Jul 2026 09:07:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: vectorized CRC on ARM64
To: John Naylor <johncnaylorls@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CANWCAZaKhE+RD5KKouUFoxx1EbUNrNhcduM1VQ=DkSDadNEFng@mail.gmail.com>
 <CANWCAZYAKWTFW_1byMq44t57urk6YKoDh1z1Zp6fk5-4dOPy-w@mail.gmail.com>
 <CANWCAZZj35DGtjSX3umT1XHM49T4-v5ysc20TXPLcfn1oHGHfA@mail.gmail.com>
 <acwQpqLKzH0Ft-I3@nathan>
 <CANWCAZYhe8jtH4QTy-VUqZcTHw6OjfBzO6vYLm-JU9ZcYwXq_g@mail.gmail.com>
 <ac04uCXJOPEAwE1Z@nathan>
 <CANWCAZaRuJC6vb+VKqimeEPLV-d_fUk8AO1-jL1Pwx4STM4J+A@mail.gmail.com>
 <ac6Q9JduymhuxcNt@nathan> <ac6WfKIKshE3AmWr@nathan>
 <CANWCAZa-4WN8_bPV=GKZii2b5kdwffdWreuykP6ogT_dRYhPdQ@mail.gmail.com>
 <d42db427-0b1e-41c8-b3fd-db7f85aec70a@eisentraut.org>
 <CANWCAZYUq2WUp48Q7oCah2v7y0QCCNnYE04ogwhASH3mNXHY7A@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CANWCAZYUq2WUp48Q7oCah2v7y0QCCNnYE04ogwhASH3mNXHY7A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/01d19f04-9eb4-4dba-8513-2ce875335eea%40eisentraut.org>
Precedence: bulk

On 29.06.26 11:35, John Naylor wrote:
> On Mon, Jun 29, 2026 at 3:52 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> It looks like this patch was developed concurrently with the switch from
>> pg_attribute_aligned to C11 standard alignas, and it ended up being
>> committed with the "old" style.  I propose the attached patch to update
>> that.  It's only a stylistic change, but good for consistency and as an
>> example for future code.
> 
> Looks good to me.

Committed.