Subject: Re: bulk typos
To: Justin Pryzby <pryzby@telsasoft.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <heikki.linnakangas@iki.fi>,
 Surafel Temesgen <surafel3000@gmail.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Pavel Stehule <pavel.stehule@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>
References: <20180331105640.GK28454@telsasoft.com>
 <20201025194849.GM9241@telsasoft.com>
From: Heikki Linnakangas <hlinnaka@iki.fi>
Message-ID: <01de8ba3-7cce-af94-536b-dec3da7c9cdf@iki.fi>
Date: Sun, 25 Oct 2020 23:00:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <20201025194849.GM9241@telsasoft.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/10/2020 21:48, Justin Pryzby wrote:
> On Sat, Mar 31, 2018 at 05:56:40AM -0500, Justin Pryzby wrote:
>> I needed another distraction so bulk-checked for typos, limited to comments in
>> *.[ch].
>>
>> I'm not passionate about this, but it serves the purpose of reducing the
>> overhead of fixing them individually.
> 
> I happened across this old patch, so ran this again to find new typos.

Nice script.

> There's a few that I don't know how best to fix.
> 
> Heikki, do you remember what this means ?
> +++ b/src/backend/catalog/storage.c
> + * NOTE: the list is kept in TopMemoryContext to be sure it won't disappear
> + * unbetimes.  It'd probably be OK to keep it in TopTransactionContext,
> + * but I'm being paranoid.

Heh, even though I was the last one to touch that line according to git 
blame, I just moved it from smgr.c. Looks like Tom wrote it in 2004. I 
guess it means "too early". That would make sense from the context. 
Google only gives a few hits but they seem to agree with "too early". A 
very rare word, for sure. Might be good to change it to "too early", but 
it's not wrong, and the poet in me kind of likes "unbetimes" :-).

- Heikki