MIME-Version: 1.0
Date: Wed, 22 Jan 2025 16:54:40 +0300
From: m.litsarev@postgrespro.ru
To: Ivan Kush <ivan.kush@tantorlabs.com>, samimseih@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_stat_statements: improve loading and saving routines for the
 dump file
In-Reply-To: <e3071cfc-7a9e-4476-81fd-8ff1095baabd@tantorlabs.com>
References: <192f7185defa370d083e3a237727b066@postgrespro.ru>
 <63fd7f0d-2d49-4952-b1ec-fa877bbf0765@tantorlabs.com>
 <181d7759a2ed7d819add4e0086e7a7f9@postgrespro.ru>
 <e3071cfc-7a9e-4476-81fd-8ff1095baabd@tantorlabs.com>
Message-ID: <0231a188cf457095458ba9759ac21ea1@postgrespro.ru>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/0231a188cf457095458ba9759ac21ea1%40postgrespro.ru>
Precedence: bulk

> What does this patch give on aglobal scale? Does it save much memory or 
> increase performance? How many times?

This patch makes the code semantically more correct and we don't lose 
anything. It is obviously not about performance or memory optimisation.

> This will only reduce the size of the
> $PGDATA/pg_stat/pg_stat_statements.txt file. Even with
> 100k entries, the most I have seen pg_stat_statements.max
> set to, that will be less than 1 MB of disk saving. The default
> config of 5k entries will be much less.

Perfectly agree. I would just add that statistics are dropped into the 
pg_stat_statements.txt file at server stop which is not a very frequent 
event.

Respectfully,

Mikhail Litsarev,
Postgres Professional: https://postgrespro.com