public inbox for [email protected]  

help / color / mirror / Atom feed

From: Joel Jacobson <[email protected]>
To: Alexander Lakhin <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Optimize LISTEN/NOTIFY
Date: Wed, 20 May 2026 04:47:09 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAE7r3MLivh1sHWF06hrVXkiQbw-KChPcQsh+9CheXprm5vRVMQ@mail.gmail.com>
	<14865EB6-0BF4-462B-9<[email protected]>
	<[email protected]>

On Sat, Apr 18, 2026, at 21:00, Alexander Lakhin wrote:
> While browsing through new inconsistencies and typos, I came across one
> which I'm not sure what to do with. Could you help, please?
>
> async-notify.spec contains:
> # Check ChannelHashAddListener array growth.
> permutation listenc llisten l2listen l3listen lslisten
>
> But as far as I can see, ChannelHashAddListener() was eliminated in
> 0002-optimize_listen_notify-v13.patch upthread [1]:
>
>> > Or thinking a little bigger: why are we maintaining the set of
>> > channels-listened-to both as a list and a hash? Could we remove
>> > the list form? 
>> Yes, it was indeed possible to remove the list form.
>> 
>
> So, maybe the comment or perhaps even the test case should be changed/
> removed?

Yes, that test is a leftover from a previous patch version.
I'll post a patch to remove it in a separate thread.

Thanks for spotting.

/Joel

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Optimize LISTEN/NOTIFY
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox