Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIzPP-0004Ck-9W for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Aug 2022 21:26:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oIzPN-0004aO-Dp for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Aug 2022 21:26:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIzPN-0004aF-43 for pgsql-hackers@lists.postgresql.org; Tue, 02 Aug 2022 21:26:33 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oIzPK-0001Rz-Nq for pgsql-hackers@lists.postgresql.org; Tue, 02 Aug 2022 21:26:31 +0000 Received: by mail-pf1-x42f.google.com with SMTP id 17so14759595pfy.0 for ; Tue, 02 Aug 2022 14:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timescale.com; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=2ZJCz0k/BCqEmmNxV5GDg7drmYvo4ew41efPlp+Nt/c=; b=Vb9XdE2YdCN173r2twiz2W50+k2AjrgpJx6130i02TAIfI6sdvSAeQecXEQ5Enj2/n mqanE9lK/2kTpp153H4apEUiZJgUtvlD/V13G/diHD5ggLCfJQ7+nXhEwk7WQUT/025B URxlyV43JMIJyiTSWv99o0DO68Fs9jB83KRPO6sm25g2MhOe6gRGQ3R+Hzm1x00lgZHh 5Q4dr78TfMBIqHyFLEb+mhIX/EVA/WOLaIdixDa2LsL97n8anlMGqVLT1MDJuAdBeI2k Azv/Gqk4FCa9+V5Ptg27eXXAYUHKAN4EREAJ0s93YYZRbxpV+RV+eNMN7+NPkEzsI5Sp c3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=2ZJCz0k/BCqEmmNxV5GDg7drmYvo4ew41efPlp+Nt/c=; b=vmlh4/WUwwrdDA8O5hbdoBPTMphE5OrXm1i0vajb+hL4uXVfd7+rsFnABFGnw5xuD+ mgbEPCOVzquNWjIhx+APOVCpybmkx/8bBNl0mah53n6ijs0Tj4Oz1fYu6tAnJoYRj/+l ngD9U4AWKolwmQOj/QyIx9WyMjVOcafhW4nIFK+LvkNrKGU9X6TUzsCLrm1v4ZMZB5oU UZOBCPnckpFRfFV1M2BpXw5EzXQ/At6eIqZ+LoXyqbhugNLPKyruz11bt3VUxWkGEAnl oSmwmPpFZtge6zyFyHQeSIa8UyGMYJ3lY3bQkVn/KG0hY2V0eidJNn0ef6SeUhSeRVUI dTBA== X-Gm-Message-State: AJIora84mRXZs6xhPjlGJ0DncjbhHOHQKdnelGCX7mDN4BDrTWxXk3Hk Ep1/9+e0u56QpxmxMjc+mGDHe3AUl8nU9i8H X-Google-Smtp-Source: AGRyM1s00XI77TLEfCoGz59r4b1ZMwKeU1/dOXD6qIl66UEbq7iy28ldkiRjhANgNHg37/iAaCx4hw== X-Received: by 2002:a63:4608:0:b0:41a:617f:e194 with SMTP id t8-20020a634608000000b0041a617fe194mr19223158pga.152.1659475589182; Tue, 02 Aug 2022 14:26:29 -0700 (PDT) Received: from [192.168.1.21] ([50.39.205.221]) by smtp.gmail.com with ESMTPSA id c136-20020a621c8e000000b0052ab54a4711sm9078049pfc.150.2022.08.02.14.26.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 14:26:28 -0700 (PDT) Message-ID: <02abb1b9-cbbb-c62d-ed05-4db90397fc88@timescale.com> Date: Tue, 2 Aug 2022 14:26:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] minor reloption regression tests improvement Content-Language: en-US From: Jacob Champion To: Nikolay Shaplov Cc: PostgreSQL Hackers References: <4563991.km65PDbjlG@thinkpad-pgpro> <165653872847.1152.5920509051824255715.pgcf@coridan.postgresql.org> <2590342.64y9vfTr7p@thinkpad-pgpro> <12182567.IpiZAh8j0P@thinkpad-pgpro> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 6/30/22 16:16, Jacob Champion wrote: > [CFM hat] Since you feel strongly about the patch, and we're short on > time before the commitfest starts, I have re-registered this. That way > there can be an explicit decision as opposed to a pocket veto by me. [CFM hat] Okay, with another CF come and gone without review I feel much more confident about closing this as Returned with Feedback. [dev hat] Specifically I don't think this patch is reviewable alone; it needs to be grouped with the functionality change that needed the additional coverage. That way it'll be much easier for a reviewer to decide whether 1) it's covering the right spots and 2) it's an overall useful addition. That doesn't mean you have to smash it into another commit; it can be a separate test commit as part of a bigger patchset, and the commit message can include the motivation for why you wrote the new test. Thanks, --Jacob