Message-ID: <02e28438bd448ff4ee8f6fd78e6b74e657172d73.camel@j-davis.com>
Subject: Re: Avoid orphaned objects dependencies, take 3
From: Jeff Davis <pgsql@j-davis.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Heikki Linnakangas
	 <hlinnaka@iki.fi>
Cc: Robert Haas <robertmhaas@gmail.com>, Roman Eskin <r.eskin@arenadata.io>,
  Michael Paquier <michael@paquier.xyz>, Alexander Lakhin
 <exclusion@gmail.com>, pgsql-hackers@lists.postgresql.org,  Tom Lane
 <tgl@sss.pgh.pa.us>
Date: Thu, 04 Jun 2026 10:03:22 -0700
In-Reply-To: <ah1PIyqtT+427dWb@bdtpg>
References: 
	<CA+TgmoZh8yXoQ2AF-VFSTswhin0o+BZ78AaOsWZskCW1GHBd6g@mail.gmail.com>
	 <aEJ+oNANWutG8aDv@ip-10-97-1-34.eu-west-3.compute.internal>
	 <9f5f0dd4-96d5-4d90-9436-62d96e0298f9@arenadata.io>
	 <ad/awXLnMuc6Rf5M@bdtpg> <afCXPVNuvpf5ECGZ@bdtpg>
	 <CA+TgmobtzkG9HzGtDXbgb3KVE46qHuSvGcuKHgAGQ1aejCoLLw@mail.gmail.com>
	 <agsCqlLTytZCudMv@bdtpg> <aebf583b-b904-4035-a1c1-a4c5ad064dec@iki.fi>
	 <ahYAKgbx05IQdjwR@bdtpg> <3963e573-4852-4d25-b741-7c5c7e1f9140@iki.fi>
	 <ah1PIyqtT+427dWb@bdtpg>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.3-0ubuntu1.1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/02e28438bd448ff4ee8f6fd78e6b74e657172d73.camel%40j-davis.com>
Precedence: bulk

On Mon, 2026-06-01 at 09:21 +0000, Bertrand Drouvot wrote:
> The tracking array lives in a dedicated AclCheckTrackContext memory
> context
> (child of TopMemoryContext). The context is reset at the start of
> each
> top-level utility statement, which frees all prior allocations and
> provides
> clean lifetime management.
>=20
> Recording is gated by aclcheck_tracking_active, which is set to true
> only
> during top-level utility statement execution. This ensures DML and
> queries pay
> no cost. The flag is cleared both at normal completion of
> ProcessUtility and in
> AbortTransaction to handle the error path.

This could use some better high-level comments in the code. Something
like:

"DDL performs ACL checks on referenced objects before acquiring a lock
on them. The lock is acquired much later, when recording dependencies.
Track the ACL checks, so that we can re-check them after acquiring the
lock. XXX: consider refactoring so that we perform the name lookup,
acquire the lock, and check ACLs all in unison, like
RangeVarGetRelidExtended()."

Assuming I understand correctly.

Regards,
	Jeff Davis