public inbox for [email protected]
help / color / mirror / Atom feedFrom: Álvaro Herrera <[email protected]>
To: Chao Li <[email protected]>
To: Ashutosh Bapat <[email protected]>
Cc: L. pgsql-hackers <[email protected]>
Subject: Re: Property graph: fix error handling when dropping non-existent label property
Date: Wed, 29 Apr 2026 11:51:55 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CAExHW5s1q7eyp4qJLPzCgnsE9tQ8uKdLyOwKt3cijdMR_0E+Cg@mail.gmail.com>
<[email protected]>
<CAExHW5s-4MHjo0wn=bNGQQd=Q+3SW_HGxJCFnoBF+hiy5ni8wA@mail.gmail.com>
<[email protected]>
On 2026-04-29, Chao Li wrote:
>> Looks good to me. However, I did change OidIsValid() and !OidIsValid()
>> back to (oid) and (!oid) conditions to be consistent with the rest of
>> the code.
>
> In the file, I also see:
> ```
> if (pgrelid == InvalidOid)
> ```
>
> Should we take this opportunity to change to use OidIsValid()
> everywhere in the file? As this feature is new to PG19, we can cleanup
> the inconsistency before releasing v19. Otherwise some people might
> also file a cleanup patch for this in the future.
Yeah, I find "if (oid)" a rather terrible coding pattern. The negative one is perhaps not so bad, but I'd keep both cases similar by using the macro in both, for consistency.
--
Álvaro Herrera
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Property graph: fix error handling when dropping non-existent label property
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox