Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjLRO-000828-DA for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Apr 2023 14:45:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pjLRM-0004Pv-Ty for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Apr 2023 14:45:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjLRM-0004Pk-Jk for pgsql-hackers@lists.postgresql.org; Mon, 03 Apr 2023 14:45:48 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pjLRE-000eDg-Ix for pgsql-hackers@lists.postgresql.org; Mon, 03 Apr 2023 14:45:47 +0000 Received: by mail-ed1-x52c.google.com with SMTP id h8so118379706ede.8 for ; Mon, 03 Apr 2023 07:45:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1680533139; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6XVHe8MEYJy6zVCMEEoW5M0ZjN0WVK4B9rCoQd3afvg=; b=cqdXfmqLHTnrcH44DA8IYk2TqqDdFdbi7hlt91JWYMY0TM99gRIL4Dmmx26QwmDrmu OK0V1cneWEquiklAT9aojggwSjz7czDC56dhYH/ziNNyMWsit5E0o7vloFKtYvxnc9fP x+9LL2MTjwxZcqYu3E/h2lKf/xxIBOk8YWOjnSA7uFBc9tXFPbIApryQfTM5/byIpmG7 BKFp3YKYFY27/3iENPW5QsE67kEZVT937hJNkQ82xjhrDuVSYe+7Y7KmB4uVMsscMCTu oeKkC0/U6n+3Cebof7nyxHT5xJnpwzKy9vDB8LJZSUS7wy9apq6soUtTmwcQh0b8hrcF XBtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680533139; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6XVHe8MEYJy6zVCMEEoW5M0ZjN0WVK4B9rCoQd3afvg=; b=OWOe5M0EM3ptcia5oO6msBWR2RToqV3xNGUIMrhrk5Ey52bmtfB3Lx3kwmA+CWFfzx NfAj6GhDoeEduTyWaqlxGxAPu7EoQwxpea1o+84KPduznbxe7bujburV4CHc/QaBntHS EXe8ZIK8DSj9aGGSF96fLWAFWvNBVqzNH6MlpOyKxaGp1LWtETXZlpsiflkFFgfjAi50 CgQX1PzkGOlhJrnOhWJiPMRbSRWM2nvUAknjSSMPl6cw8Gd5p2AzI4C53wT+tHIw49Bg mFCmZ2kiWRBVqCoC+IuBRfiOSLdKzsRwlpQKNhkCrW2oTyNKEgUArEXLc2rSVeqpCyqK pnWA== X-Gm-Message-State: AAQBX9dTLhoOSuG3/jHNxqjs5i9CeHnGE6iyei+EnH1yluqn08njI2oz Ps3kl9MiR9lNpmTCMdThTSfkhuLPtALc/Ul4aoo7Li0Nlvp5nvXRL5F/IRxTH9hxJAZ4xysgKgx F8fitGdOTH8KxOTkD9kQ6GJoIkw7T0o4n0+3+s+m3s9fZUI69Cs3qPBH0fVagjOTJK2ER5ooT8I 1uQUzPtC37g0xdqLYkJiVRcQ9r8GKmIsRKdVtzVNJcZhk6OXlLa0qa X-Google-Smtp-Source: AKy350ZIgEschrcuLGehsV2WVHekU0nspndCg+bfZJIFu108sPVq35dCsaegKU08ZshCwlcIteSc3w== X-Received: by 2002:a17:906:6882:b0:930:6ead:f81 with SMTP id n2-20020a170906688200b009306ead0f81mr34248430ejr.71.1680533139108; Mon, 03 Apr 2023 07:45:39 -0700 (PDT) Received: from [10.137.0.17] (ip-86-49-228-162.bb.vodafone.cz. [86.49.228.162]) by smtp.gmail.com with ESMTPSA id j3-20020a170906050300b00947a40ded80sm4486758eja.104.2023.04.03.07.45.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 07:45:38 -0700 (PDT) Message-ID: <037c6b65-019e-7e4b-4fd0-77973ea75a9f@enterprisedb.com> Date: Mon, 3 Apr 2023 16:45:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: daitch_mokotoff module Content-Language: en-US To: Dag Lem , Andres Freund Cc: Alvaro Herrera , Paul Ramsey , PostgreSQL Hackers References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql> <53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com> <20230211025830.twigy3l65bc27cyw@awork3.anarazel.de> From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 4/3/23 15:19, Dag Lem wrote: > Dag Lem writes: > >> I sincerely hope this resolves any blocking issues with copyright / >> legalese / credits. >> > > Can this now be considered ready for commiter, so that Paul or someone > else can flip the bit? > Hi, I think from the technical point of view it's sound and ready for commit. The patch stalled on the copyright/credit stuff, which is somewhat separate and mostly non-technical aspect of patches. Sorry for that, I'm sure it's annoying/frustrating :-( I see the current patch has two simple lines: * This module was originally sponsored by Finance Norway / * Trafikkforsikringsforeningen, and implemented by Dag Lem Any objections to this level of attribution in commnents? regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company