Feedback-ID: ic6394509:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-431-g1d6a3ebb56-fm-20230511.001-g1d6a3ebb
Mime-Version: 1.0
Message-Id: <0400a90b-ff40-4be5-8f90-6c205c9cd99b@app.fastmail.com>
In-Reply-To: <fd88c4f8-a6f7-a111-c4e9-80b6a71ff451@dunslane.net>
References: <748b7bfc-9f16-4bea-b7e1-4a59dc9354f5@app.fastmail.com>
 <fd88c4f8-a6f7-a111-c4e9-80b6a71ff451@dunslane.net>
Date: Sat, 20 May 2023 08:59:46 +0200
From: "Joel Jacobson" <joel@compiler.org>
To: "Andrew Dunstan" <andrew@dunslane.net>, pgsql-hackers@lists.postgresql.org
Subject: Re: New COPY options: DELIMITER NONE and QUOTE NONE
Content-Type: multipart/alternative;
 boundary=e2b1bf7b48074775abc3b1fb0988ee90
Archived-At: <https://www.postgresql.org/message-id/0400a90b-ff40-4be5-8f90-6c205c9cd99b%40app.fastmail.com>
Precedence: bulk

--e2b1bf7b48074775abc3b1fb0988ee90
Content-Type: text/plain

On Fri, May 19, 2023, at 19:03, Andrew Dunstan wrote:
> I think you've been a bit too cute with the grammar changes, but as you say this is a POC.

Thanks for feedback.

The approach I took for the new grammar rules was inspired by previous commits,
such as de7531a971b, which introduced support for 'FORCE QUOTE '*''. In that
case, a new separate grammar rule was crafted.

Not sure what you mean with it being "too cute", but maybe you think it's a bit
verbose with another grammar rule and it would be better to integrate it into
the existing one?

Example:

| DELIMITER opt_as (Sconst | NONE)
        {
                if ($3 == NONE)
                        $$ = makeDefElem("delimiter", (Node *) makeString("\0"), @1);
                else
                        $$ = makeDefElem("delimiter", (Node *) makeString($3), @1);
        }

/Joel

--e2b1bf7b48074775abc3b1fb0988ee90
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Fri, Ma=
y 19, 2023, at 19:03, Andrew Dunstan wrote:<br></div><div>&gt; I think y=
ou've been a bit too cute with the grammar changes, but as you say this =
is a POC.<br></div><div><br></div><div>Thanks for feedback.<br></div><di=
v><br></div><div>The approach I took for the new grammar rules was inspi=
red by previous commits,<br></div><div>such as de7531a971b, which introd=
uced support for 'FORCE QUOTE '*''. In that<br></div><div>case, a new se=
parate grammar rule was crafted.<br></div><div><br></div><div>Not sure w=
hat you mean with it being "too cute", but maybe you think it's a bit<br=
></div><div>verbose with another grammar rule and it would be better to =
integrate it into<br></div><div>the existing one?<br></div><div><br></di=
v><div>Example:<br></div><div><br></div><div>| DELIMITER opt_as (Sconst =
| NONE)<br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br></=
div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp; if ($3 =3D=3D NONE)<br></div><div>&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; $$ =3D makeDefE=
lem("delimiter", (Node *) makeString("\0"), @1);<br></div><div>&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp; else<br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp; $$ =3D makeDefElem("delimiter", (Node *) makeStr=
ing($3), @1);<br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }=
<br></div><div><br></div><div>/Joel<br></div><div><br></div></body></htm=
l>
--e2b1bf7b48074775abc3b1fb0988ee90--