Subject: Re: client-side fsync() error handling
To: Michael Paquier <michael@paquier.xyz>
References: <d239d1bd-aef0-ca7c-dc0a-da14bdcf0392@2ndquadrant.com>
 <20200212052819.GD1464@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <0412a2fb-cbde-08c6-9ff2-cfab5c27a3b8@2ndquadrant.com>
Date: Thu, 13 Feb 2020 10:02:31 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200212052819.GD1464@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-02-12 06:28, Michael Paquier wrote:
> Now, don't we need to care about durable_rename() and make the
> panic-like failure an optional choice?  From what I can see, this
> routine is used now in the backend for pg_basebackup to rename
> temporary history files or partial WAL segments.

durable_rename() calls fsync_fname(), so it would be covered by this 
change.  The other file access calls in there can be handled by normal 
error handling, I think.  Is there any specific scenario you have in mind?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services