Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xBSYQ-00000003Cz8-3bXy for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Sep 2026 07:47:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xBSYP-0000000DcFI-3Y87 for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Sep 2026 07:47:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xBSYP-0000000DcF9-2JC2 for pgsql-hackers@lists.postgresql.org; Tue, 29 Sep 2026 07:47:09 +0000 Received: from mail-dy2-x0e.google.com ([2607:f8b0:4864:36::e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xBSYN-00000001t0G-1Bnv for pgsql-hackers@postgresql.org; Tue, 29 Sep 2026 07:47:09 +0000 Received: by mail-dy2-x0e.google.com with SMTP id 5a478bee46e88-341d5303884so2720214eec.3 for ; Tue, 29 Sep 2026 00:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790668025; x=1791272825; darn=postgresql.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:from:to:cc :subject:date:message-id:reply-to:content-type; bh=ZuRIuH9F+aDYH5L36f89wIKvz9ZYWs2EkPJvWr40ZFk=; b=V9d4tfZqx2vWfTxdUoYDDdx8U8IZppmESvcqwkk680rDKuxv12vNgY96mKhCmSawlY PIGWb8JCt0Am684MSYbNtDOVw5uXaR2/ymp2vFMPq3VpVZK3mzRoX1vU1AQahZAML8EV 5Kp7WwtVw14FU8rf5/fKyNCD+sF/4mkbJTYqliDuKxgHVIszpTlvyruoKRPtWPtMrNEJ KohkHpPIjVczNuL/PumH8mhd7eYFjDpYRma4eSs++v9rSc/qFj1gOvkfTHzqWeGLHW63 Tsq/P+TvrEOvdI1HcMLkAPBT7r6PoUaRUTZesLfn2pFXPf1iQ+nl9lBVOxDsdj7G090V XTxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790668025; x=1791272825; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZuRIuH9F+aDYH5L36f89wIKvz9ZYWs2EkPJvWr40ZFk=; b=Sg5or6m5pfXrXMrrd68wQ+Jp+M+SBBjuoXC7e038cJY2fqE5F+SXqAK9/oUU62mAY6 WVmX6bFt+1lEMa/dDSOlNd8Egnb0jhHxksUuerCa6lOTgRl9l/vXVKTjYcBUUGmg4oeE gb/dcpzT8Gdc70wwwuUK0cl3F2QFn/PCrRJybClvy+qiFdg4cHouN/WidXhXSkK4NYtB huX/VMGxFVBoQHs2rAKVtZ29Q5xpjM/5qhR4V8eq/ZAU7zlYe8Ilmszd2TR8Mho4L2uy B0mQ7ojD6yUSdF3kMo1nlpYwGSnlp8HWfGJ2To9d+vYPN4/ALeWwiLyvD0hRWAsX5a2I Cukw== X-Forwarded-Encrypted: i=1; AKwUvBzDosdj4wPaB99Di33gc/H3LIp5uWOyA7OrCZtTEoyoHOEQJ3fNDchYgYpzSgDitdkRmZkrvEL9ErXwJC4C@postgresql.org X-Gm-Message-State: AFq9FYK3J7ynGZ3Wub0njoWFIE9u9WsIXgZercppZ3Ic/FxPG9lq8P7E V/i+Rm6KPW60KIavaX3gsuSf0l5Bb1CVjZnLest9irDjgY1YgJW5eYyw X-Gm-Gg: AYBFou0gm1A8cGiVMC1N5XvlpYETDqcD0sJsrhRNxwD1LaIZ9mCC8ljeCX1Svmv34AI db36YtG5obFdwfEOyCXLpNHmZyKNOco6bMOKGrAkyMIpNKbrot6PKnfDFIlSDAOp0tEsGCutnmq rcIXAvfXDuZW8a3dnG0/b75OgZP/3iqNOIb49dvdHhae/QEgi/A6qCmMZnmX/7yHvuhssMMbfyx Le2hyDh55m5tHVqMj5RonpbI3mSgESmdg+LALrt13k/cGGzyi63I3mOlpIfOlqRR/F5ZTqvsl1r Nmo7g8MMmMd6QblyQxgNFQ1y/A2PxGT+NZW0zs4XLgTz6BEhHfXt8RNqyaUGhi6bXoehEB0ipy8 SOls2Iiu8C6oEzSno/oa8opx4hCXJIC+EeTpONSpyJuIU2V2SJq+lmkfqXVlq3qYYIFbzj2rowV SKTFsqFMCBTmLY8EaJc+zxlYxJPSGz0dKQZkgBFk6/nzNTrNSUAw77ckbguC4t00Bez5xmNM9Lw Ch0RCPvDdQJAEI= X-Received: by 2002:a05:7301:4b0e:b0:33e:6ba8:9519 with SMTP id 5a478bee46e88-34271a8dd3bmr11614546eec.25.1790668024641; Tue, 29 Sep 2026 00:47:04 -0700 (PDT) Received: from smtpclient.apple ([128.14.31.162]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-34b2b8a57casm3459815eec.7.2026.09.29.00.47.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Sep 2026 00:47:04 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.100.1.1.12\)) Subject: Re: [PATCH] Add ALTER SYSTEM RELOAD From: Yuhang Qiu In-Reply-To: <1811098.1790278160@sss.pgh.pa.us> Date: Tue, 29 Sep 2026 15:46:51 +0800 Cc: Chao Li , PostgreSQL-development Content-Transfer-Encoding: 7bit Message-Id: <044D2C7B-06C2-4AED-B4FB-64C187B70B0B@gmail.com> References: <5A1F1E3B-D22F-487B-9480-D3DDB5F0C2A1@gmail.com> <1811098.1790278160@sss.pgh.pa.us> To: Tom Lane X-Mailer: Apple Mail (2.3901.100.1.1.12) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi all, Sorry for the late reply. The v1 patch was mainly intended to discuss whether `RELOAD` belongs under `ALTER SYSTEM`, so I did not cover the privilege design in detail. I had in mind a separate ACL for `ALTER SYSTEM` operations, allowing privileges to be granted per operation. If we add more operations, predefined roles may be too broad to allow fine-grained control. > I'm pretty down on this proposal even without the privilege question. > "There's more than one way to do it" isn't a great thing for > security-relevant operations, and this surely is one. > > Also, I don't like the loss of an explainable scope for what > ALTER SYSTEM does. I agree with Tom's concerns about adding a second interface and blurring the scope of the command. I also agree with Andreas about the maintenance cost. `pg_reload_conf()` already provides the reload operation, and the `ALTER SYSTEM` documentation explains how to request a reload. > This lack of intellectual consistency would get ten times worse > if we followed through on the idea of overloading ALTER SYSTEM > with unrelated actions like log rotation and promotion. Agreed. Log rotation and promotion were simply the first operations that came to mind as possible fits for a broader command family. Adding just those two would not give ALTER SYSTEM a coherent scope. Oracle has a much broader ALTER SYSTEM command family, though. If PostgreSQL developed a similarly broad family of instance-level operations, could that give the command a clearer scope? But still, it would increase the overlap with existing functions that concerns Tom, as well as the maintenance cost Andreas noted. Thanks everyone for the reviews. Best regards, Yuhang Qiu