Feedback-ID: ie0a040ee:Fastmail
Message-ID: <0485e0b3-b0ec-4f36-8b61-99692b71990c@eisentraut.org>
Date: Mon, 13 Apr 2026 11:24:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
 Gyan Sreejith <gyan.sreejith@gmail.com>, Peter Smith
 <smithpb2250@gmail.com>, shveta malik <shveta.malik@gmail.com>,
 Shlok Kyal <shlok.kyal.oss@gmail.com>, vignesh C <vignesh21@gmail.com>,
 Euler Taveira <euler@eulerto.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: 
 <OSOPR01MB1215385EAC6A76650444E40B0F54FA@OSOPR01MB12153.jpnprd01.prod.outlook.com>
 <CAJpy0uAwPNG3GN5+jTajnccLe+F1mW6dZh-9112u3QQQYugA=Q@mail.gmail.com>
 <CAA4eK1JyYHPgaPTow5co8wBh8Ga+fx=vqHLhk2zHeqdOGYN4Vg@mail.gmail.com>
 <OS9PR01MB12149FECFFF25973C167F9CFAF54BA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <CAEqnbaULSSQcir8Z8KDXduV4o4NZvJLeBMZN0VW3wh5QZjpEnw@mail.gmail.com>
 <OS9PR01MB1214926DB01BF19C09368188EF548A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <CAHut+PsmdpYZnXKLYJ8n07-ftaPAbvxH9xuNrvm2c6zxS09z7Q@mail.gmail.com>
 <CAEqnbaWsrDhsrBJucqiL7Bx9MKgB3F6imFAE7tF63MZ6okRmAg@mail.gmail.com>
 <CAA4eK1JSg3HKm-cFDv0D5adSk8Kbsd6OG=B=HaOU-tLQt2NZ6Q@mail.gmail.com>
 <4c2eb422-696c-4e34-84e7-6c6cd95781ab@eisentraut.org>
 <OS9PR01MB121494EEBAB83F0076218BB62F550A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <618f670b-b097-4bd1-8d88-a6eaad031c06@eisentraut.org>
 <CAA4eK1+yp31nyES9eO39TjT75XLO6M-siQPRV2AwwVRjOaHqYg@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAA4eK1+yp31nyES9eO39TjT75XLO6M-siQPRV2AwwVRjOaHqYg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/0485e0b3-b0ec-4f36-8b61-99692b71990c%40eisentraut.org>
Precedence: bulk

On 08.04.26 07:30, Amit Kapila wrote:
> On Tue, Apr 7, 2026 at 7:07 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> On 01.04.26 07:05, Hayato Kuroda (Fujitsu) wrote:
>>> Dear Peter E.,
>>>
>>>> Instead of creating a new logging API in pg_createsubscriber locally,
>>>> why not extend logging.c to support a log file.
>>>
>>> I had a concern to extend the common module. Do you have possible idea to use
>>> pg_logging_set_logfile() on others? I cannot, tee command on linux seems enough
>>> for others.
>>
>> pg_upgrade was mentioned.
>>
> 
> I see that pg_upgrade has some specific requirements related to
> verbose/status/report kind of messages which doesn't seem to be
> directly handled by the generic API  pg_log_generic(). For example,
> apart from other things, we need to unset/reset log_file when we want
> to send messages only to the terminal and quite some specific handling
> for status or other kinds of messages. If you think pg_log_generic
> could be extended to handle various upgrade cases then I think it
> would be a good use case for it and we should go-ahead with what you
> are proposing. OTOH, maybe we can give it a separate try and use the
> resulting API for both pg_createsubscriber and pg_upgrade. I am fine
> either way you would like to go-ahead with this.

I have committed these patches.

I would like to apply the frontend logging API to pg_upgrade as well, 
but that's a bigger project for not right now.