Content-Type: multipart/mixed; boundary="------------rTMUnqaVxPwmOK9KowJHFH0z"
Message-ID: <04b04387-92f5-476c-90b0-4064e71c5f37@iki.fi>
Date: Mon, 6 Apr 2026 03:16:47 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Shmem allocated wrong for custom cumulative stats
To: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/04b04387-92f5-476c-90b0-4064e71c5f37%40iki.fi>
Precedence: bulk

This is a multi-part message in MIME format.
--------------rTMUnqaVxPwmOK9KowJHFH0z
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

There's only one call of ShmemAlloc() left in the tree outside shmem.c, 
in StatsShmemInit(), and that call doesn't look right:

The StatsShmemSize() function takes those allocations into account when 
it calculates the size for the "Shared Memory Stats" shmem area, but 
ShmemAlloc() doesn't use that reservation, it uses the general-purpose 
unreserved shmem that then shows up as "<anonymous>" in 
pg_shmem_allocations. The space reserved with ShmemRequestStruct() / 
ShmemInitStruct() goes unused.

We should use the memory that we've reserved, per the attached patch. 
One consequence of this fix though is that the allocations are now only 
MAXALIGNed, while ShmemAlloc() uses CACHELINEALIGN(). Not sure which we 
want.

I noticed this while working on the new shmem allocation functions, but 
it's a pre-existing bug in stable branches too.

- Heikki

--------------rTMUnqaVxPwmOK9KowJHFH0z
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Use-the-allocated-space-properly-for-custom-stats-ki.patch"
Content-Disposition: attachment;
 filename*0="0001-Use-the-allocated-space-properly-for-custom-stats-ki.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA2MmQ5YTJmYzhhNTY3NTFmY2Q4YThhYjc4MGRiNzc4MTM3NGRiNWYwIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZWlra2kgTGlubmFrYW5nYXMgPGhlaWtraS5saW5u
YWthbmdhc0Bpa2kuZmk+CkRhdGU6IE1vbiwgNiBBcHIgMjAyNiAwMjo1NDoxOCArMDMwMApT
dWJqZWN0OiBbUEFUQ0ggMS8xXSBVc2UgdGhlIGFsbG9jYXRlZCBzcGFjZSBwcm9wZXJseSBm
b3IgY3VzdG9tIHN0YXRzIGtpbmQKCi0tLQogc3JjL2JhY2tlbmQvdXRpbHMvYWN0aXZpdHkv
cGdzdGF0X3NobWVtLmMgfCA0ICsrKy0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMo
KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9hY3Rp
dml0eS9wZ3N0YXRfc2htZW0uYyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FjdGl2aXR5L3Bnc3Rh
dF9zaG1lbS5jCmluZGV4IDk1NWZhZjVlYmM3Li41ZTY1YTIxZmE4MyAxMDA2NDQKLS0tIGEv
c3JjL2JhY2tlbmQvdXRpbHMvYWN0aXZpdHkvcGdzdGF0X3NobWVtLmMKKysrIGIvc3JjL2Jh
Y2tlbmQvdXRpbHMvYWN0aXZpdHkvcGdzdGF0X3NobWVtLmMKQEAgLTE4OSw2ICsxODksNyBA
QCBTdGF0c1NobWVtSW5pdCh2b2lkICphcmcpCiAJICogZWZmaWNpZW5jeSB3aW4uCiAJICov
CiAJY3RsLT5yYXdfZHNhX2FyZWEgPSBwOworCXAgKz0gcGdzdGF0X2RzYV9pbml0X3NpemUo
KTsKIAlkc2EgPSBkc2FfY3JlYXRlX2luX3BsYWNlKGN0bC0+cmF3X2RzYV9hcmVhLAogCQkJ
CQkJCSAgcGdzdGF0X2RzYV9pbml0X3NpemUoKSwKIAkJCQkJCQkgIExXVFJBTkNIRV9QR1NU
QVRTX0RTQSwgTlVMTCk7CkBAIC0yNDIsNyArMjQzLDggQEAgU3RhdHNTaG1lbUluaXQodm9p
ZCAqYXJnKQogCQkJCWludAkJCWlkeCA9IGtpbmQgLSBQR1NUQVRfS0lORF9DVVNUT01fTUlO
OwogCiAJCQkJQXNzZXJ0KGtpbmRfaW5mby0+c2hhcmVkX3NpemUgIT0gMCk7Ci0JCQkJY3Rs
LT5jdXN0b21fZGF0YVtpZHhdID0gU2htZW1BbGxvYyhraW5kX2luZm8tPnNoYXJlZF9zaXpl
KTsKKwkJCQljdGwtPmN1c3RvbV9kYXRhW2lkeF0gPSBwOworCQkJCXAgKz0gTUFYQUxJR04o
a2luZF9pbmZvLT5zaGFyZWRfc2l6ZSk7CiAJCQkJcHRyID0gY3RsLT5jdXN0b21fZGF0YVtp
ZHhdOwogCQkJfQogCi0tIAoyLjQ3LjMKCg==

--------------rTMUnqaVxPwmOK9KowJHFH0z--