Message-ID: <0576fa4dbd6e62e027b41e0ef9254896540f1cb4.camel@j-davis.com>
Subject: Re: Statistics Import and Export
From: Jeff Davis <pgsql@j-davis.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Robert Treat <rob@xzilla.net>, Robert Haas <robertmhaas@gmail.com>,
 Andres Freund <andres@anarazel.de>, Nathan Bossart
 <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,  Michael Paquier
 <michael@paquier.xyz>, jian he <jian.universality@gmail.com>, Bruce Momjian
 <bruce@momjian.us>,  Matthias van de Meent <boekewurm+postgres@gmail.com>,
 Magnus Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Peter Smith
 <smithpb2250@gmail.com>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>, alvherre@alvh.no-ip.org
Date: Tue, 25 Mar 2025 11:42:22 -0700
In-Reply-To: 
 <CADkLM=c0dOJZUQuWzVcE2BsJSVRGcX7HkJH8wYjo+OD83WFqcg@mail.gmail.com>
References: 
	<y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
	 <6af48508a32499a8be3398cafffd29fb6188c44b.camel@j-davis.com>
	 <CADkLM=cG8=gde_KjGiQC_wt0K3knJCy_mwvd-sW=f=3M2eSrEg@mail.gmail.com>
	 <rp6int5sqs5bn7g35brqz7w3t7il6tn2dgpm7tr3pev626wnc4@fi7a3enofhct>
	 <Z8j8HXlIIGYPA9L8@nathan>
	 <CADkLM=e-H5H+pY8iA58ie28PVSRJ1HBpzyy1=FWmy0Hm+s4boQ@mail.gmail.com>
	 <6rpmhyrtci4epuzay7y5xvd2cwdwb6zmtt6ofxrvakyawxhm7s@6grajbpr4kij>
	 <CADkLM=ct+i2G=Z+c_8np1+C75uvzjUK_SBsouUvgWMHRs2cnyg@mail.gmail.com>
	 <xe3yjkcthy7f377zjayuckxyd62z5cekgjau3j4vp6elbicson@cx2uiilwmxyy>
	 <CADkLM=f1n2_Vomq0gKab7xdxDHmJGgn=DE48P8fzQOp3Mrs1Qg@mail.gmail.com>
	 <pbjbvxnq36xo2ooufcnlfqsqnxuvggbqxbx3myjtswokshfjbl@hfihx57z4j4t>
	 <CA+TgmoYGuEC=E4TbomRyqO8+Uav=90G0dYXw=rA1d5UmRB76Yg@mail.gmail.com>
	 <bd0513e4b1ea2b2f2d06f02720c6579711cb62a6.camel@j-davis.com>
	 <CABV9wwO5v8Nu8q+xWexMdL3Z+2xS=fFJMQetBSHy3tR64wNHOA@mail.gmail.com>
	 <bec4c2feb4ef51c129ee6e1912fffa911a3c7229.camel@j-davis.com>
	 <CABV9wwP_ajEbLhCzfCO2Sy0180AshYwQFViys=QhyZA7sW2_qw@mail.gmail.com>
	 <CADkLM=dvG_F2giHEAGJ=DGVGNmujUt0vAaXNSDkDXzbzcGQbxQ@mail.gmail.com>
	 <CAJSLCQ10++5GLeoRwNMQMKuaVrikEp2X6feBv=kYDtWmsVy-Pw@mail.gmail.com>
	 <d8a3beed2682fde95936ee779e411b907df1148a.camel@j-davis.com>
	 <CADkLM=c+r05srPy9w+-+nbmLEo15dKXYQ03Q_xyK+riJerigLQ@mail.gmail.com>
	 <CADkLM=ceOSsx_=oe73QQ-BxUFR2Cwqum7-UP_fPe22DBY0NerA@mail.gmail.com>
	 <e7ed5a10113d04be3d02558fe6cff06a42a8777f.camel@j-davis.com>
	 <5812bf576f181e2f94944cab485cee46f611ed3e.camel@j-davis.com>
	 <CADkLM=c0dOJZUQuWzVcE2BsJSVRGcX7HkJH8wYjo+OD83WFqcg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/0576fa4dbd6e62e027b41e0ef9254896540f1cb4.camel%40j-davis.com>
Precedence: bulk

On Tue, 2025-03-25 at 10:53 -0400, Corey Huinker wrote:
>=20
> So this patch swings the pendulum a bit back towards accepting some
> things as errors.

Not exactly. I see patch 0001 as a change to the function signatures
from regclass to schemaname/relname, both for usability as well as
control over ERROR vs WARNING.

There's agreement to do so, so I went ahead and committed that part.

> the best we can do is to draw the error-versus-warning line at a
> place that:
>=20
> * doesn't mess up flawed restores that we would otherwise expect to
> complete at least partially
> * is easy for us to understand
> * is easy for us to explain
> * we can live with for the next couple of decades

The original reason we wanted to issue warnings was to allow ourselves
a chance to change the meaning of parameters, add new parameters, or
even remove parameters without causing restore failures. If there are
any ERRORs that might limit our flexibility I think we should downgrade
those to WARNINGs.

Also, out of a sense of paranoia, it might be good to downgrade some
other ERRORs to WARNINGs, like in 0002.=C2=A0I don't think it's quite as
important as you seem to think, however. It doesn't make a lot of
difference unless the user is running restore with --single-transaction
or --exit-on-error, in which case they probably don't want the restore
to continue if something unexpected happens. I'm fine having the
discussion, though, or we can wait until beta to see what kinds of
problems people encounter.

Regards,
	Jeff Davis