Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBs57-0001BX-42 for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Jun 2023 07:16:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qBs55-0000Kq-NX for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Jun 2023 07:16:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBs55-0000Kg-EP for pgsql-hackers@lists.postgresql.org; Wed, 21 Jun 2023 07:16:43 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qBs52-003m7T-NL for pgsql-hackers@lists.postgresql.org; Wed, 21 Jun 2023 07:16:42 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 988AB2F97341 for ; Wed, 21 Jun 2023 09:16:39 +0200 (CEST) Received: from s980.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 899782E27C22; Wed, 21 Jun 2023 09:16:39 +0200 (CEST) Received: from s473.loopia.se (unknown [172.22.191.6]) by s980.loopia.se (Postfix) with ESMTP id 86D7B22016AC; Wed, 21 Jun 2023 09:16:39 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s981.loopia.se ([172.22.191.6]) by s473.loopia.se (s473.loopia.se [172.22.190.13]) (amavisd-new, port 10024) with UTF8LMTP id 7pu0zF5XWLyy; Wed, 21 Jun 2023 09:16:39 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s981.loopia.se (Postfix) with ESMTPSA id E3FB022B1710; Wed, 21 Jun 2023 09:16:38 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: Remove deprecation warnings when compiling PG ~13 with OpenSSL 3.0~ From: Daniel Gustafsson In-Reply-To: <20230621054459.zp7exzwi37d4ccq2@awork3.anarazel.de> Date: Wed, 21 Jun 2023 09:16:38 +0200 Cc: Michael Paquier , Postgres hackers Content-Transfer-Encoding: 7bit Message-Id: <057B416A-15E8-4597-B06A-8AC8F3BA678B@yesql.se> References: <20230621054459.zp7exzwi37d4ccq2@awork3.anarazel.de> To: Andres Freund X-Mailer: Apple Mail (2.3696.120.41.1.3) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 21 Jun 2023, at 07:44, Andres Freund wrote: > On 2023-06-21 11:53:44 +0900, Michael Paquier wrote: >> I have been annoyed by these in the past when doing backpatches, as >> this creates some noise, and the only place where this counts is >> sha2_openssl.c. Thoughts about doing something like the attached for >> ~13? > > Wouldn't the proper fix be to backpatch 4d3db13621b? Agreed, I'd be more inclined to go with OPENSSL_API_COMPAT. If we still get warnings with that set then I feel those warrant special consideration rather than a blanket suppression. -- Daniel Gustafsson