Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i7Ix7-0007gG-TF for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Sep 2019 12:39:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i7Ix5-0001rL-Cl for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Sep 2019 12:39:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i7Ix4-0001g5-U5 for pgsql-hackers@lists.postgresql.org; Mon, 09 Sep 2019 12:39:27 +0000 Received: from mail-yb1-xb43.google.com ([2607:f8b0:4864:20::b43]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i7Ix1-00065V-J5 for pgsql-hackers@postgresql.org; Mon, 09 Sep 2019 12:39:26 +0000 Received: by mail-yb1-xb43.google.com with SMTP id z2so4546329ybp.9 for ; Mon, 09 Sep 2019 05:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=CK00hEmLbyv12lMxtSjbkdqXiVXcpaXq8V5nq1o/tWE=; b=vs35zVPaGfKqL3kqRWRggq/Vg5Sznpy2jLhtiwC13bm3zYmoF3n18JOJyYFL5LEg1r SiZO9p66Z50mbvHbbNYxW3yqUyaNmUf6c42n0tU0k8lcEYXzHEp15YvQRPmvQYKThFo8 dm3prbfcbigD4lXIz7V9N6N2OMX9wgnO0t4RKWzo5/k56Xb6bJXhg0D87fZEtJ3K5aXn GcCnRx8mS3o2zbVlsJJ1kMnP0scv2dZ0+t455m0/+Ap328hBdjzPRd6hv3vZSSuyyOdc n931EXqQGUl+uBIPRGJDa3aUwQ1HBQzXPR51zcqW6eyE2NtxRrgk3wQH3EIBb4PrIu+l MaeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=CK00hEmLbyv12lMxtSjbkdqXiVXcpaXq8V5nq1o/tWE=; b=nxHtCqSF6z8EVdZC82hbCcl50tzuYXd3jQGtL8Ht6boPsOe3H4UxMAB+R8817QRB6B A0sq7gBvNJUl45s89HQeUT4iO//Qfa35JBxHwynnYLBjXf++4ra1PyN1wD+jrt8jb+md bAZi9xliDvHf62BNaeWxv2YR3+74ZBYSXkUtOeHlwfqFFLtdXqK0DUUzPm5n6Cfu+ANy rhUdCRViYC2kZeEr+6D6ymam6Y2SQ2OMtnP37/xBUwtaLL0UAQuMD8Y/64+mbKXoJC5Q mWrhBAQKpU9SEcuHlyddhJhi3P5VcN70RIiF/wCftcS+C10nDPiasTeaDHxN9Wb3RqfV ccgA== X-Gm-Message-State: APjAAAXPLy/YBHKIlsRl1yjuLiQeOUlNNhTHoAAAT+aebBYCot1sVPdr u6xigiZjUTXGpN8EXjxuhXh9cuiXRhTBgTg2vm+139R3j/o4I/lnVA8yMns9sFnQroTqRq3+lef OxEZgvSVKLZhN7F1XuE/pF1VVBwz+IjJlnYZq2yM4I/4dGwwez89LJay4CQ/4uNyuhcH5Sr3EnU j0sR1azUQhnHNkXJ0= X-Google-Smtp-Source: APXvYqx5URSOvtgm84tByHARUtzQj4sH5+IhKmYAxxo0BItFoBCw1+/ju6BT+psavq9gICAHcjZeyw== X-Received: by 2002:a25:d7d0:: with SMTP id o199mr15197501ybg.162.1568032761221; Mon, 09 Sep 2019 05:39:21 -0700 (PDT) Received: from [192.168.10.146] (99-10-92-30.lightspeed.rlghnc.sbcglobal.net. [99.10.92.30]) by smtp.gmail.com with ESMTPSA id 68sm3056019ywd.21.2019.09.09.05.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2019 05:39:20 -0700 (PDT) From: Andrew Dunstan X-Google-Original-From: Andrew Dunstan Subject: Re: msys2 vs pg_upgrade/test.sh To: Peter Eisentraut , PostgreSQL-development References: <3227042f-cfcc-745a-57dd-fb8c471f8ddf@2ndQuadrant.com> <4a76b98b-4a00-7df2-8912-9363277b604f@2ndquadrant.com> Openpgp: preference=signencrypt Autocrypt: addr=andrew.dunstan@2ndQuadrant.com; prefer-encrypt=mutual; keydata= xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB AAHNL0FuZHJldyBEdW5zdGFuIDxhbmRyZXcuZHVuc3RhbkAybmRRdWFkcmFudC5jb20+wsCY BBMBAgBCAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUJDyV6hBYhBOQ+WEYd/Hy/RGkV pZn6f8tZ/DuBBQJcH/EVAhkBAAoJEJn6f8tZ/DuB7BEH/iDWZEbVft2m2MT6SPjARzTupt/l xLLZ/Cl6n2US2hov5+fBbnR5xvECk/YCOfG9ICvKNlpFjceqNLRKStd8cmndnI+kDw91uNM2 hpL4aJMeW65XCHvqXlOLSwv5chBpXz9NG7FMaJ+q+59sWEWjcTNmjXgkEHn53y+1pc7nSLDe cr5ZI1aB3nGXRm1SoDY5PYZkUKMykW+YBZwgcs/Q5tRaE+siN7DKbz8E628+PerwAkmHPVXN MdJFD6gs4S0gDFA8IxcyIwZU2v4By+brzcJ9Se3FK5BYxBDHtaYZxgSrJAvOUOrLIZPQTQfL TtnVs3C3JTfrxCH1ceHtnA6dRuTOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oK Waqf+wmW4tpDe/VVcxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7 llV0xSSoFiieQBsrGvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8 BoVrRFcdzlIY/NFNhFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C 4R+M6w7o2PLGOjdZ+kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaY L++LAEOqrlvm2TvqQqZRtnEAEQEAAcLAZQQYAQIADwIbDAUCXA6fpAUJDyV6xAAKCRCZ+n/L Wfw7geU4B/9vFFsVmWxerDWgNjyiK80zIPmlw/iwdUlU6FIu0JWLMg4093kvxBs7RMZV9hBq n3ekBvD4IvFsVLJrw9qzSI2FH3UeYy5WXpEs01Ppia60NOlvRDqXbryzuvfe+iYo6bVP3Ikr TPTNYL/BePUTD2DPvSI82SbGTyzuA7SJv6NRqqQDMIy1fU6KyQFLmQJp/QJyhKWzm9jWh8ee w8jVaoMY0Kbq5N7RqisEx1Lu/Iw646UphdYzQNymf+kbiU5Kf4I6DhzV8w9sie1Bo1juNj3I c5/fFJsmxljbnaDbXPcnFsur1Oo9mIHFakgWgOBMuxoWfjONiLjjLh/9+ZIqSSLX Message-ID: <059441e1-e0e0-7079-3081-eec637f9a5b9@2ndQuadrant.com> Date: Mon, 9 Sep 2019 08:39:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <4a76b98b-4a00-7df2-8912-9363277b604f@2ndquadrant.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-MW List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 9/9/19 4:48 AM, Peter Eisentraut wrote: > On 2019-09-09 00:06, Andrew Dunstan wrote: >> Diagnosing this took quite a lot of time and detective work. For some >> reason I don't quite understand, when calling the Windows command >> processor in a modern msys2/WindowsServer2019 installation, you need to >> double the slash, thus: >> >>     cmd //c foo.bat >> >> Some Internet postings at least seem to suggest this is by design. (FSVO >> "design") >> >> I tested this on older versions and the change appears to work, so I >> propose to apply the attached patch. > If we're worried about messing things up for non-msys2 environments, we > could also set MSYS2_ARG_CONV_EXCL instead; see > . > According to that page, that would seem to be the more proper way to do it. > Nice find, thanks, I'll do it that way. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services