Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pevHw-0007GW-1w for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Mar 2023 10:01:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pevHu-0000fX-5v for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Mar 2023 10:01:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pevHt-0000fO-SL for pgsql-hackers@lists.postgresql.org; Wed, 22 Mar 2023 10:01:45 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pevHr-0002dH-LJ for pgsql-hackers@postgresql.org; Wed, 22 Mar 2023 10:01:45 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 9CE912F89378 for ; Wed, 22 Mar 2023 11:01:42 +0100 (CET) Received: from s899.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 8D3532E2893B; Wed, 22 Mar 2023 11:01:42 +0100 (CET) Received: from s472.loopia.se (unknown [172.22.191.5]) by s899.loopia.se (Postfix) with ESMTP id 875E52C8BB0A; Wed, 22 Mar 2023 11:01:42 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s934.loopia.se ([172.22.191.6]) by s472.loopia.se (s472.loopia.se [172.22.190.12]) (amavisd-new, port 10024) with UTF8LMTP id ha15Jk0M2wwa; Wed, 22 Mar 2023 11:01:42 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id 68E797CEA91; Wed, 22 Mar 2023 11:01:40 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: Re: Avoid use deprecated Windows Memory API From: Daniel Gustafsson In-Reply-To: Date: Wed, 22 Mar 2023 11:01:39 +0100 Cc: Ranier Vilela , Aleksander Alekseev , PostgreSQL Hackers , Alvaro Herrera Content-Transfer-Encoding: quoted-printable Message-Id: <05D22864-7030-4B26-8AB2-AC694950DF0B@yesql.se> References: <20220915131347.fjijnfmafcua7m3d@alvherre.pgsql> To: Michael Paquier X-Mailer: Apple Mail (2.3696.120.41.1.2) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 19 Mar 2023, at 23:41, Michael Paquier wrote: >=20 > On Fri, Mar 17, 2023 at 12:19:56PM -0300, Ranier Vilela wrote: >> Rebased to latest Head. >=20 > I was looking at this thread, and echoing Daniel's and Alvaro's > arguments, I don't quite see why this patch is something we need. I > would recommend to mark it as rejected and move on. Unless the claimed performance improvement is measured and provides a = speedup, and the loss of zeroing memory is guaranteed safe, there doesn't seem to = be much value provided. -- Daniel Gustafsson