Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wAYRB-0005Js-0g for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Apr 2026 19:19:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wAYQA-001cLQ-1m for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Apr 2026 19:18:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wAYQA-001cLI-0V for pgsql-hackers@lists.postgresql.org; Wed, 08 Apr 2026 19:18:39 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wAYQ8-000000003Pd-3z9L for pgsql-hackers@lists.postgresql.org; Wed, 08 Apr 2026 19:18:38 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 3BEBD59EFBE for ; Wed, 08 Apr 2026 21:18:36 +0200 (CEST) Received: from s934.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 2799759EA4C; Wed, 08 Apr 2026 21:18:36 +0200 (CEST) Received: from localhost (unknown [172.22.191.6]) by s934.loopia.se (Postfix) with ESMTP id 227877CE915; Wed, 08 Apr 2026 21:18:36 +0200 (CEST) X-Virus-Scanned: amavis at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s472.loopia.se (amavis); dkim=pass (2048-bit key) header.d=proxel.se Received: from s899.loopia.se ([172.22.191.5]) by localhost (s472.loopia.se [172.22.190.12]) (amavis, port 10024) with LMTP id ymgaAp4-sPS5; Wed, 8 Apr 2026 21:18:35 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: andreas@proxel.se X-Loopia-Originating-IP: 147.28.75.140 Received: from [192.168.0.121] (customer-147-28-75-140.stosn.net [147.28.75.140]) (Authenticated sender: andreas@proxel.se) by s899.loopia.se (Postfix) with ESMTPSA id 602A62C8BAB6; Wed, 08 Apr 2026 21:18:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proxel.se; s=loopiadkim1707418970; t=1775675915; bh=z74/HZVK6Vp68ka+XEA7ab8sFH7X4AwIVYgsY6eo1HA=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=c8ELQAvO2M6Fo0FiBlmqzHVeEpGDyiSSuJC1uu9c/EWqYVdm2i70CmyoMepbd+AFx 9Z8YB4oimLz7V7LTgaV6VW//cOd5Q7J9F/GWXEcuv+WpjM2whArWESTmIcIfV+LwX9 Mig/1cF7Gbde9HRehDUCBrHrbSyKQIp7fE84HZxIh1Ih/g9eDktzdZmQaVYsqLpYYd JrwiORml4qM8GEhA3hrduG+gjFsRsinwVe0Vvd5aBQ61fw4S0Y303ZStTULjvZXoSP M2lAXVYT55NdwsesiqNFLIFYTmezX5BZPcbitBj+vyRPUqk2Ms34A1fSmiI3UUgYxl IaCK4TFaDzB8w== Message-ID: <05a2cdbd-5233-4328-9404-3c91b35a4f8c@proxel.se> Date: Wed, 8 Apr 2026 21:18:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: updates for handling optional argument in system functions To: Mark Wong Cc: pgsql-hackers@lists.postgresql.org References: <6de20662-36fd-4e00-a0b0-75d1e9deb5c8@proxel.se> From: Andreas Karlsson Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 4/8/26 8:10 PM, Mark Wong wrote: > What I pondered over a little bit was whether to flip-flop and remove > the original _ext definitions instead and modify their respective > counterparts that I originally removed. I opted to continue editing what > I started because of the comment that reads "System-view support > functions with pretty-print option", but I don't have any strong > opinions either way. > > I've attached v7 with the more succinct descriptions. I would be fine with either too. The comment feels a bit less useful now so it too could either stay or go. I have no strong feelings about it. Setting this as ready for committer since I think the patch is fine as-is and an improvement over the current no matter what is done about the comment or which oids we decide to use. Andreas