Content-Type: multipart/mixed; boundary="------------CRq6FMEyKDgc2xlzMX02Zf0I"
Message-ID: <05a7a760-ba3a-fcff-d7d1-3afb47ea0f7d@enterprisedb.com>
Date: Thu, 24 Mar 2022 17:33:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: Column Filtering in Logical Replication
Content-Language: en-US
To: Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Amit Kapila <amit.kapila16@gmail.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Justin Pryzby <pryzby@telsasoft.com>, Rahila Syed <rahilasyed90@gmail.com>,
 Peter Smith <smithpb2250@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>
References: <202201120041.p24wvsfcsope@alvherre.pgsql>
 <CAA4eK1KONbrck=hQTFSFgwio5rqu-82KZba2HLE_AcVa_RWYcQ@mail.gmail.com>
 <cac80284-7196-6c77-adb9-ef0976a3e21f@enterprisedb.com>
 <CAA4eK1JyoVty_BZOMJdx7VMkBTadvv8oOYrh9xTQ5BY+k-3+OA@mail.gmail.com>
 <d26d24dd-2fab-3c48-0162-2b7f84a9c893@enterprisedb.com>
 <CAA4eK1JJ5qgqbjfYQU9F4R1+OABxec-DQechQXus0fanDjaAVg@mail.gmail.com>
 <OS0PR01MB571614E4A39DD33669D5AFD6940A9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <e4b0fb99-3d74-7333-1e71-74f990b641ee@enterprisedb.com>
 <78b8d385-57cb-9a3f-cfe5-9f300f15eced@enterprisedb.com>
 <822a8e40-287c-59ff-0ea9-35eb759f4fe6@enterprisedb.com>
 <CAA4eK1J9UDnM-xN7viu4eO_DDL_PqMG9F6ZsskqEU7snujXi+A@mail.gmail.com>
 <2b8471f9-3849-c91f-ef82-9181d4bca0a7@enterprisedb.com>
 <CAA4eK1KUpOnFam+2bBuGGX-_pZbmO_ShJV6G=GT-RyM7gQSvWg@mail.gmail.com>
 <16e83ce3-8415-b732-37b2-c3329a2c13a1@enterprisedb.com>
 <9c0dd1f3-c1b9-9c10-eca6-35f22104434a@enterprisedb.com>
 <bded66cd-393d-77bf-44ee-2cbebcc70d7c@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <bded66cd-393d-77bf-44ee-2cbebcc70d7c@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/05a7a760-ba3a-fcff-d7d1-3afb47ea0f7d%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------CRq6FMEyKDgc2xlzMX02Zf0I
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 17.03.22 20:11, Tomas Vondra wrote:
> But the comment describes the error for the whole block, which looks
> like this:
> 
> -- error: replica identity "a" not included in the column list
> ALTER PUBLICATION testpub_fortable ADD TABLE testpub_tbl5 (b, c);
> UPDATE testpub_tbl5 SET a = 1;
> ERROR:  cannot update table "testpub_tbl5"
> DETAIL:  Column list used by the publication does not cover the replica
> identity.
> 
> So IMHO the comment is correct.

Ok, that makes sense.  I read all the comments in the test file again. 
There were a couple that I think could use tweaking; see attached file. 
The ones with "???" didn't make sense to me:  The first one is before a 
command that doesn't seem to change anything, the second one I didn't 
understand the meaning.  Please take a look.

(The patch is actually based on your 20220318c patch, but I'm adding it 
here since we have the discussion here.)
--------------CRq6FMEyKDgc2xlzMX02Zf0I
Content-Type: text/plain; charset=UTF-8;
 name="0001-fixup-Allow-specifying-column-lists-for-logical-repl.patch"
Content-Disposition: attachment;
 filename*0="0001-fixup-Allow-specifying-column-lists-for-logical-repl.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSAyZTYzNTI3OTFlNTQxOGJiMDcyNmEwNTE2NjBkNDQzMTEwNDZmYzI4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogVGh1LCAyNCBNYXIgMjAyMiAxNzozMDozMiArMDEwMApTdWJqZWN0
OiBbUEFUQ0hdIGZpeHVwISBBbGxvdyBzcGVjaWZ5aW5nIGNvbHVtbiBsaXN0cyBmb3IgbG9n
aWNhbCByZXBsaWNhdGlvbgoKLS0tCiBzcmMvdGVzdC9yZWdyZXNzL3NxbC9wdWJsaWNhdGlv
bi5zcWwgfCAxMCArKysrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCsp
LCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3B1
YmxpY2F0aW9uLnNxbCBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3B1YmxpY2F0aW9uLnNxbApp
bmRleCBhZWIxYjU3MmFmLi5kNTAwNTJlZjlkIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdy
ZXNzL3NxbC9wdWJsaWNhdGlvbi5zcWwKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvcHVi
bGljYXRpb24uc3FsCkBAIC0zOTksMTQgKzM5OSwxNCBAQCBDUkVBVEUgVEFCTEUgdGVzdHB1
Yl90Ymw1IChhIGludCBQUklNQVJZIEtFWSwgYiB0ZXh0LCBjIHRleHQsCiAtLSBvawogQUxU
RVIgUFVCTElDQVRJT04gdGVzdHB1Yl9mb3J0YWJsZSBBREQgVEFCTEUgdGVzdHB1Yl90Ymw1
IChhLCBjKTsKIEFMVEVSIFRBQkxFIHRlc3RwdWJfdGJsNSBEUk9QIENPTFVNTiBjOwkJLS0g
bm8gZGljZQotLS0gb2s6IGZvciBpbnNlcnQtb25seSBwdWJsaWNhdGlvbiwgdGhlIGNvbHVt
biBsaXN0IGlzIGFyYml0cmFyeQorLS0gb2s6IGZvciBpbnNlcnQtb25seSBwdWJsaWNhdGlv
biwgYW55IGNvbHVtbiBsaXN0IGlzIGFjY2VwdGFibGUKIEFMVEVSIFBVQkxJQ0FUSU9OIHRl
c3RwdWJfZm9ydGFibGVfaW5zZXJ0IEFERCBUQUJMRSB0ZXN0cHViX3RibDUgKGIsIGMpOwog
CiAvKiBub3QgYWxsIHJlcGxpY2EgaWRlbnRpdGllcyBhcmUgZ29vZCBlbm91Z2ggKi8KIENS
RUFURSBVTklRVUUgSU5ERVggdGVzdHB1Yl90Ymw1X2Jfa2V5IE9OIHRlc3RwdWJfdGJsNSAo
YiwgYyk7CiBBTFRFUiBUQUJMRSB0ZXN0cHViX3RibDUgQUxURVIgYiBTRVQgTk9UIE5VTEws
IEFMVEVSIGMgU0VUIE5PVCBOVUxMOwogQUxURVIgVEFCTEUgdGVzdHB1Yl90Ymw1IFJFUExJ
Q0EgSURFTlRJVFkgVVNJTkcgSU5ERVggdGVzdHB1Yl90Ymw1X2Jfa2V5OwotLS0gZXJyb3I6
IHJlcGxpY2EgaWRlbnRpdHkgKGIsYykgaXMgY292ZXJlZCBieSBjb2x1bW4gbGlzdCAoYSwg
YykKKy0tIGVycm9yOiByZXBsaWNhIGlkZW50aXR5IChiLGMpIGlzIG5vdCBjb3ZlcmVkIGJ5
IGNvbHVtbiBsaXN0IChhLCBjKQogVVBEQVRFIHRlc3RwdWJfdGJsNSBTRVQgYSA9IDE7CiBB
TFRFUiBQVUJMSUNBVElPTiB0ZXN0cHViX2ZvcnRhYmxlIERST1AgVEFCTEUgdGVzdHB1Yl90
Ymw1OwogCkBAIC00MjMsNyArNDIzLDcgQEAgQ1JFQVRFIFBVQkxJQ0FUSU9OIHRlc3RwdWJf
dGFibGVfaW5zIFdJVEggKHB1Ymxpc2ggPSAnaW5zZXJ0LCB0cnVuY2F0ZScpOwogQUxURVIg
UFVCTElDQVRJT04gdGVzdHB1Yl90YWJsZV9pbnMgQUREIFRBQkxFIHRlc3RwdWJfdGJsNSAo
YSk7CQktLSBvawogXGRScCsgdGVzdHB1Yl90YWJsZV9pbnMKIAotLS0gd2l0aCBSRVBMSUNB
IElERU5USVRZIEZVTEwsIGNvbHVtbiBsaXN0cyBhcmUgbm90IGFsbG93ZWQKKy0tIHRlc3Rz
IHdpdGggUkVQTElDQSBJREVOVElUWSBGVUxMCiBDUkVBVEUgVEFCTEUgdGVzdHB1Yl90Ymw2
IChhIGludCwgYiB0ZXh0LCBjIHRleHQpOwogQUxURVIgVEFCTEUgdGVzdHB1Yl90Ymw2IFJF
UExJQ0EgSURFTlRJVFkgRlVMTDsKIApAQCAtNDM0LDExICs0MzQsMTEgQEAgQ1JFQVRFIFRB
QkxFIHRlc3RwdWJfdGJsNiAoYSBpbnQsIGIgdGV4dCwgYyB0ZXh0KTsKIEFMVEVSIFBVQkxJ
Q0FUSU9OIHRlc3RwdWJfZm9ydGFibGUgQUREIFRBQkxFIHRlc3RwdWJfdGJsNjsgLS0gb2sK
IFVQREFURSB0ZXN0cHViX3RibDYgU0VUIGEgPSAxOwogCi0tLSBtYWtlIHN1cmUgY2hhbmdp
bmcgdGhlIGNvbHVtbiBsaXN0IGlzIHVwZGF0ZWQgaW4gU0VUIFRBQkxFCistLSBtYWtlIHN1
cmUgY2hhbmdpbmcgdGhlIGNvbHVtbiBsaXN0IGlzIHVwZGF0ZWQgaW4gU0VUIFRBQkxFID8/
PwogQ1JFQVRFIFRBQkxFIHRlc3RwdWJfdGJsNyAoYSBpbnQgcHJpbWFyeSBrZXksIGIgdGV4
dCwgYyB0ZXh0KTsKIEFMVEVSIFBVQkxJQ0FUSU9OIHRlc3RwdWJfZm9ydGFibGUgQUREIFRB
QkxFIHRlc3RwdWJfdGJsNyAoYSwgYik7CiBcZCsgdGVzdHB1Yl90Ymw3Ci0tLSBvazogd2Un
bGwgc2tpcCB0aGlzIHRhYmxlCistLSBvazogd2UnbGwgc2tpcCB0aGlzIHRhYmxlID8/Pwog
QUxURVIgUFVCTElDQVRJT04gdGVzdHB1Yl9mb3J0YWJsZSBTRVQgVEFCTEUgdGVzdHB1Yl90
Ymw3IChhLCBiKTsKIFxkKyB0ZXN0cHViX3RibDcKIC0tIG9rOiB1cGRhdGUgdGhlIGNvbHVt
biBsaXN0Ci0tIAoyLjM1LjEKCg==

--------------CRq6FMEyKDgc2xlzMX02Zf0I--