Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5PvU-0006m5-UX for pgsql-hackers@arkaria.postgresql.org; Sat, 03 Jun 2023 12:00:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q5PvT-0004As-Qp for pgsql-hackers@arkaria.postgresql.org; Sat, 03 Jun 2023 12:00:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5PvT-0004Aj-Fk for pgsql-hackers@lists.postgresql.org; Sat, 03 Jun 2023 12:00:07 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q5PvR-003PyC-0g for pgsql-hackers@postgresql.org; Sat, 03 Jun 2023 12:00:06 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4f6195d2b3fso667109e87.1 for ; Sat, 03 Jun 2023 05:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685793603; x=1688385603; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8OOtye2IY5o7A4SY2XjxZC16FYxPEhpnZtV2nLpLdLo=; b=TLcPzpXhHSlwuGUa5UtAuy36SGHdh07VpRiu/jtdV13YINnDWwfAEVT/oh/IX93Nf3 vZNeCL+jwXOajygCG7iAM24seIKGyappFQYQlYRviI0qv5pwtnFqWGfYNpUHfWQHCPky +TzxqgmeQy1JZSF+6fNWQxFUWW44QqQa2Pq/+cV2M87iKy5NcseGNjAkUkhQcbirmxUX fms3pEPqwI8rU85TGy61ehQwhx9MCpJ4EMaK2w4E+upTNSfF81F+gfo0hCL6bMoTTKeX Y17kgjO1SsgC3MNZpezX2OiBvC8XiOt7TLVyj6MU0jBLm2fwxzJxGt0UrLxT+OYG5S2o Z+2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685793603; x=1688385603; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8OOtye2IY5o7A4SY2XjxZC16FYxPEhpnZtV2nLpLdLo=; b=elgKR/iUd2j73tn4C39G1/Ox0RzhMUeRZojVYemMNs1X7XXbr59HHxZaXHN7Wbgld6 jmegYDAQ5TZTGzD25iXRYdCvT0EV6yyh5UOSAaK+f4wJX3NeGcr4lra5r/MqtGkN7SH0 h0qzWAraA8W3QNEWBwVCkkWRPo7DaINSRt1V5FVe+HyqCfEdxb2w6worRbG+FJTT+b/3 Fj1ntsdo/B8gDKf+cJ6Ja+qHC8jamw6jA2pAucsn+MrbQQIh/xp7ajB0XffXkORhq/ky N0e1DWiU/NjF/2AtPakQXJB7TjzWiogsijTLbLDpibrYFPsuscJ1LveqaYK85TC4P7Je qbOQ== X-Gm-Message-State: AC+VfDwGxkHxZS5PEXOxuB9X6XC/M0lQxhlum8EH56L4LLhraa5jrYd8 s3gGoTjf9WfrK2PcIKtiYYk= X-Google-Smtp-Source: ACHHUZ6VdY0dohLeONK9bdzMsO7pnOPtShfBmqR8MV06ZEWEJQvO0GdbuyXuqVGXpAnuz5+Z9SujLA== X-Received: by 2002:ac2:5475:0:b0:4f4:b05c:dbca with SMTP id e21-20020ac25475000000b004f4b05cdbcamr2358963lfn.66.1685793603102; Sat, 03 Jun 2023 05:00:03 -0700 (PDT) Received: from [1.0.0.7] ([178.155.22.130]) by smtp.gmail.com with ESMTPSA id w15-20020a19c50f000000b004f62229b6c9sm716lfe.89.2023.06.03.05.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Jun 2023 05:00:02 -0700 (PDT) Message-ID: <05a99ba8-81d5-de15-5f15-0d13045f5877@gmail.com> Date: Sat, 3 Jun 2023 15:00:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Avoid unused value (src/fe_utils/print.c) Content-Language: en-US To: Ranier Vilela , Pg Hackers References: From: Alexander Lakhin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello Ranier, 03.06.2023 13:14, Ranier Vilela wrote: > Hi, > > This is for Postgres 17 (head). > > Per Coverity. > At function print_unaligned_text, variable "need_recordsep", is > unnecessarily set to true and false. Clang' scan-build detects 58 errors "Dead assignment", including that one. Maybe it would be more sensible to eliminate all errors of this class? Best regards, Alexander