From: "Mikhail Kulagin" <m.kulagin@postgrespro.ru>
To: "'Jacob Champion'" <pchampion@vmware.com>,
	<michael@paquier.xyz>
Cc: <pgsql-hackers@postgresql.org>
References: <3d2a6f5d50e741117d6baf83eb67ebf1a8a35a11.camel@vmware.com>
	 <YNLlBncQGBIAMWho@paquier.xyz>
	 <9dc553fe86ba34bff1e0b636c493b527fc7bc030.camel@vmware.com>
	 <YNZ5Bqq4GvhNvbp0@paquier.xyz>
	 <0907fda41fb40b23e2cbdf7eb05a8d61dd5307b3.camel@vmware.com>
	 <YOLAIngluq5wOmgE@paquier.xyz>
	 <39a6bd825fd776f5f9c3a8eb7ca1c62f77cea433.camel@vmware.com>
	 <YOU2xFL/WoHl6ny0@paquier.xyz>
	 <5cf3c71d51a215d4103abcc686c69e79619e7b60.camel@vmware.com>
	 <YOao1wTwiWFsgL4p@paquier.xyz>
 <5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com>
In-Reply-To: <5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com>
Subject: RE: [PATCH] Pull general SASL framework out of SCRAM
Date: Tue, 13 Jul 2021 12:41:27 +0300
Message-ID: <05ce01d777cb$40f31d60$c2d95820$@postgrespro.ru>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_NextPart_000_05CF_01D777E4.66405560"
Content-Language: en-us
Thread-Index: 
 AQKcDhSovvuWAStEribDFndkoDx1ygHovP18AiZatpgCKLDF2QIRu5b9AZ51axcCzNkRRgJN3Xl9AswNskcCTaBlEQFffwJ0qQuY5pA=
Archived-At: 
 <https://www.postgresql.org/message-id/05ce01d777cb%2440f31d60%24c2d95820%24%40postgrespro.ru>
Precedence: bulk

This is a multipart message in MIME format.

------=_NextPart_000_05CF_01D777E4.66405560
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello, hackers!

I got an error while building one of the extensions.
/home/mkulagin/pg-install/postgresql-master/include/internal/libpq-int.h:=
44:10: fatal error: fe-auth-sasl.h: No such file or directory
                  #include "fe-auth-sasl.h"
                  ^~~~~~~~~~~~~~~~           =20

I think the new fe-auth-sasl.h file should be installed too.
Correction proposal in the attached file (but I'm not sure that fix of =
Install.pm is correct).

Regards, Mikhail A. Kulagin
PostgresPro

=20

------=_NextPart_000_05CF_01D777E4.66405560
Content-Type: application/octet-stream;
	name="missing_fe-auth-sasl.h.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="missing_fe-auth-sasl.h.patch"

diff --git a/src/interfaces/libpq/Makefile =
b/src/interfaces/libpq/Makefile=0A=
index 94c3c73e41..61c7dae80b 100644=0A=
--- a/src/interfaces/libpq/Makefile=0A=
+++ b/src/interfaces/libpq/Makefile=0A=
@@ -132,6 +132,7 @@ install: all installdirs install-lib=0A=
 	$(INSTALL_DATA) $(srcdir)/libpq-events.h '$(DESTDIR)$(includedir)'=0A=
 	$(INSTALL_DATA) $(srcdir)/libpq-int.h =
'$(DESTDIR)$(includedir_internal)'=0A=
 	$(INSTALL_DATA) $(srcdir)/pqexpbuffer.h =
'$(DESTDIR)$(includedir_internal)'=0A=
+	$(INSTALL_DATA) $(srcdir)/fe-auth-sasl.h =
'$(DESTDIR)$(includedir_internal)'=0A=
 	$(INSTALL_DATA) $(srcdir)/pg_service.conf.sample =
'$(DESTDIR)$(datadir)/pg_service.conf.sample'=0A=
 =0A=
 installcheck:=0A=
@@ -145,6 +146,7 @@ uninstall: uninstall-lib=0A=
 	rm -f '$(DESTDIR)$(includedir)/libpq-events.h'=0A=
 	rm -f '$(DESTDIR)$(includedir_internal)/libpq-int.h'=0A=
 	rm -f '$(DESTDIR)$(includedir_internal)/pqexpbuffer.h'=0A=
+	rm -f '$(DESTDIR)$(includedir_internal)/fe-auth-sasl.h'=0A=
 	rm -f '$(DESTDIR)$(datadir)/pg_service.conf.sample'=0A=
 =0A=
 clean distclean: clean-lib=0A=
diff --git a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm=0A=
index de22c9ba2c..3af324e3fa 100644=0A=
--- a/src/tools/msvc/Install.pm=0A=
+++ b/src/tools/msvc/Install.pm=0A=
@@ -633,7 +633,7 @@ sub CopyIncludeFiles=0A=
 	CopyFiles(=0A=
 		'Libpq internal headers',=0A=
 		$target . '/include/internal/',=0A=
-		'src/interfaces/libpq/', 'libpq-int.h', 'pqexpbuffer.h');=0A=
+		'src/interfaces/libpq/', 'libpq-int.h', 'pqexpbuffer.h', =
'fe-auth-sasl.h');=0A=
 =0A=
 	CopyFiles(=0A=
 		'Internal headers',=0A=

------=_NextPart_000_05CF_01D777E4.66405560--