Content-Type: multipart/mixed; boundary="------------zUv965TAP1ScgB0a1xQ0eC64"
Message-ID: <062daca9-dfad-4750-9da8-b13388301ad9@gmail.com>
Date: Tue, 15 Apr 2025 21:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: AIO v2.5
To: Andres Freund <andres@anarazel.de>
Cc: Noah Misch <noah@leadboat.com>, pgsql-hackers@postgresql.org,
 Thomas Munro <thomas.munro@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>,
 Robert Haas <robertmhaas@gmail.com>,
 Jakub Wartak <jakub.wartak@enterprisedb.com>,
 Jelte Fennema-Nio <postgres@jeltef.nl>, Antonin Houska <ah@cybertec.at>
References: <20250401151159.51.nmisch@google.com>
 <kas47e54inkpgnirnr3txm5zywxkjobhbx6466sfaolmkjtnlu@xuucqvkchksl>
 <uc62i6vi5gd4bi6wtjj5poadqxolgy55e7ihkmf3mthjegb6zl@zqo7xez7sc2r>
 <q4hmkmjqxcrfx3xav5fgxwzelvwwlm6qshagvc45fbugtikf7v@hygsuz24g3lb>
 <20250402001324.e4.nmisch@google.com>
 <3fhulsvzks4khqahl6tngcnuda7pyrrl7223tmjh2x2spralm3@iisldh6pcowy>
 <8160688e-db8e-4d7d-a7e7-ff366adf9717@gmail.com>
 <4nervqmqplfr23jrjvkp5tsumi6qgouhgjqlubf7ujrudw2epb@6mszddainl4u>
 <6a6756a0-bad5-4ee5-a591-c763af289940@gmail.com>
 <96abefe8-fa72-41f5-8840-0517125c24e3@gmail.com>
 <4qk3ehe6w7x7hfrldei2hefjcb7v7nfmj2owl2ir64craqcapz@kbrao22ljxeb>
Content-Language: en-US
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <4qk3ehe6w7x7hfrldei2hefjcb7v7nfmj2owl2ir64craqcapz@kbrao22ljxeb>
Archived-At: 
 <https://www.postgresql.org/message-id/062daca9-dfad-4750-9da8-b13388301ad9%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------zUv965TAP1ScgB0a1xQ0eC64
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hello Andres,

14.04.2025 19:06, Andres Freund wrote:
> Unfortunately I'm several hundred iterations in, without reproducing the
> issue. I'm bad at statistics, but I think that makes it rather unlikely that I
> will, without changing some aspect.
>
> Was this an assert enabled build? What compiler and what optimization settings
> did you use? Do you have huge pages configured (so that the default
> huge_pages=try would end up with huge pages)?

Yes, I used --enable-cassert; no explicit optimization setting and no huge
pages configured. pg_config says:
CONFIGURE =  '--enable-debug' '--enable-cassert' '--enable-tap-tests' '--with-liburing'
CC = gcc
CPPFLAGS = -D_GNU_SOURCE
CFLAGS = -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels 
-Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security 
-fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -O2

Please look at the complete script attached. I've just run it and got:
iteration 56 (jobs: 44)
Tue Apr 15 06:30:52 PM CEST 2025
dropdb: error: database removal failed: ERROR:  could not read blocks 0..0 in file "global/1213": Operation canceled
2025-04-15 18:31:00.650 CEST [1612266] LOG:  could not read blocks 0..0 in file "global/1213": Operation canceled
2025-04-15 18:31:00.650 CEST [1612266] CONTEXT:  completing I/O on behalf of process 1612271
2025-04-15 18:31:00.650 CEST [1612266] STATEMENT:  DROP DATABASE db3;

I used gcc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0, but now I've also
reproduced the issue with CC=clang (18.1.3 (1ubuntu1)).

Please take a look also at the simple reproducer for the crash inside
pg_get_aios() I mentioned upthread:
for i in {1..100}; do
   numjobs=12
   echo "iteration $i"
   date
   for ((j=1;j<=numjobs;j++)); do
     ( createdb db$j; for k in {1..300}; do
         echo "CREATE TABLE t (a INT); CREATE INDEX ON t (a); VACUUM t;
               SELECT COUNT(*) >= 0 AS ok FROM pg_aios; " \
         | psql -d db$j >/dev/null 2>&1;
       done; dropdb db$j; ) &
   done
   wait
   psql -c 'SELECT 1' || break;
done

it fails for me as follows:
iteration 20
Tue Apr 15 07:21:29 PM EEST 2025
dropdb: error: connection to server on socket "/tmp/.s.PGSQL.55432" failed: No such file or directory
        Is the server running locally and accepting connections on that socket?
...
2025-04-15 19:21:30.675 EEST [3111699] LOG:  client backend (PID 3320979) was terminated by signal 11: Segmentation fault
2025-04-15 19:21:30.675 EEST [3111699] DETAIL:  Failed process was running: SELECT COUNT(*) >= 0 AS ok FROM pg_aios;
2025-04-15 19:21:30.675 EEST [3111699] LOG:  terminating any other active server processes

>> I reproduced this error on three different machines (all are running
>> Ubuntu 24.04, two with kernel version 6.8, one with 6.11), with PGDATA
>> located on tmpfs.
> That's another variable to try - so far I've been trying this on 6.15.0-rc1
> [1].  I guess I'll have to set up a ubuntu 24.04 VM and try with that.
>
> Greetings,
>
> Andres Freund
>
>
> [1] I wanted to play with io_uring changes that were recently merged. Namely
> support for readv/writev of "fixed" buffers. That avoids needing to pin/unpin
> buffers while IO is ongoing, which turns out to be a noticeable bottleneck in
> some workloads, particularly when using 1GB huge pages.

Best regards,
Alexander Lakhin
Neon (https://neon.tech)
--------------zUv965TAP1ScgB0a1xQ0eC64
Content-Type: application/gzip; name="repro.tar.gz"
Content-Disposition: attachment; filename="repro.tar.gz"
Content-Transfer-Encoding: base64

H4sIAO6K/mcAA+1VbW/bNhDuZ/6Km+fGNjJZkuM0WRwFcBsnDZDVgeIB6ydFFmlbtkQqfImb
oT++pxfbShqsn4phQw6wSD53Rz48PqQly6ToqsWbn2iO4xwdHQK27tGhU28LO+j1e+D2jzDG
OTzou+C4Pfeo/wacn0lqY0bpUCKVJFz/Y9yP/OVeYNv+R+zXX+xpzO1pqBaEpCsaS7B1muW/
mSLKUAGpMFyDpaHAwBKg4r+Zd3xZAbV4EtH6cB5riBLBGWDvxLbx282E0nPJ1H3SFXKeQ3YN
wmExyQ4iXTsSfBbPjWRg3YNlMR5OE2ZRNjXz3TAKlWJS7wAdZpZmSiNjax3rhZXEUyNjPoe9
PUjDFc6GruVxPpyMbie3Xh4dKKZNtvVHCxatymkIubn0x+OJd5et6V2+wyDmKJ4ksY2SdiKi
MLGzeU755vJ8OBnuAumUsC+ZQHalB8h2PJx89BrNcub8JE6aOdTY+K/Pg+ur9/7Q/xw8DcXN
NLazXA8/XXqMB3/edo2eHRMS81jTKZyVbTcRc+id7bm7ZS9vxv7Ecw/7Bz0Eo4WABsk9XrN0
kSQKUqZUOGcKPGh9aJGZeuQR9sVsRkKjxUMYGZNWAB4VXiMdhDPNZBBJlFPlIUUJMxFzHeg4
ZcJo9Bw4WM9YBGn4JcDjjYyUjEeP6HGdAmd6ISgOsV8cGmnAGTTL8tUFkzPp5gIhxCRxioKz
IjC86DK6xTj0nd/fEZLNg0gnqIgEUC0PTBa1KbiTfBOeQ8hMSIgh5nCn2D0yde4GQAUB4CZd
iqnymu12z4F9aPrDT+fjP+AtvHM6HQwoC4kLy1DHgkMzhnaecQLNKrfTwDAaaoZNvk67vfTc
wfLUq/yD5f5+p1OtB9AuvgCRZJiDJ0qnzeWgAst8jvn81Dt0BvxJapEWajg9hdH4Ar5ChuUC
ixZTgBXC2ZlN2YPNTZKU4jj3xzcwGb6/HsHVBYz+usI7AZrxlTsgH/zRcDKqvAVWcTM8vjfM
LZbDI+7/VkN7z1C9FhtmNXQmjPwexTVeiNVrxvXjc3RhOJWMPo9dCKNCTr/jsHXUOMQPrICf
c9iANVRQ+gIz9rAjvEOVzrVrivLwMGVP0N5LaB82KOlg2cc3n6tyX/iotNbuca1dAlvJyM7f
KFuyHFE2Kiy087xu3msNCEqgUgXF57hUUAf2SDnGZh3iywvwQ1kClSKrhAh7z7Jx8Qys4QFY
I2i1R74/9r9GwiQUuNCAGqYwxXdypaDTqt8/fIGn6F0NSDHf5pYqLTJC/u1/yFd7tVd7tf+n
fQNUT26BAA4AAA==

--------------zUv965TAP1ScgB0a1xQ0eC64--