Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jljN2-0000Me-9a for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jun 2020 01:29:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jljN1-00088d-0S for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jun 2020 01:29:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jljN0-00088W-Ou for pgsql-hackers@lists.postgresql.org; Thu, 18 Jun 2020 01:29:34 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jljMy-0001RI-GM for pgsql-hackers@lists.postgresql.org; Thu, 18 Jun 2020 01:29:33 +0000 Received: from hnk.local (p2604028-ipngn12401funabasi.chiba.ocn.ne.jp [180.1.110.28]) by oss.nttdata.com (Postfix) with ESMTPSA id 1591860321; Thu, 18 Jun 2020 10:29:28 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: Review for GetWALAvailability() To: Alvaro Herrera Cc: Kyotaro Horiguchi , pgsql-hackers@lists.postgresql.org References: <20200617180437.GA1812@alvherre.pgsql> From: Fujii Masao Message-ID: <06307e6d-6c5a-d987-2a76-b68a2d8dff8a@oss.nttdata.com> Date: Thu, 18 Jun 2020 10:29:27 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200617180437.GA1812@alvherre.pgsql> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020/06/18 3:04, Alvaro Herrera wrote: > I think passing the slot name when the slot is also passed is useless > and wasteful; it'd be better to pass NULL for the name and ignore the > strcmp() in that case -- in fact I suggest to forbid passing both name > and slot. (Any failure there would risk raising an error during > checkpoint, which is undesirable.) Sounds reasonable. > So I propose the following tweaks to your patch, and otherwise +1. Thanks for the patch! It looks good to me. Barring any objections, I will commit the patches in the master and v13 branches later. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION